akallabeth
0d8764263f
[client,sdl] eliminate unused variables
2024-09-24 19:45:20 +02:00
David Fort
57c703cf67
sdl3: various fixes with the clipboard
...
There were various invalid checks with function return values. The patch also
fixes a deadlock between the SDL clipboard data function and the FreeRDP
thread.
2024-09-23 15:35:11 +02:00
akallabeth
239440e28d
[warnings] remove or comment unused macros
2024-09-20 18:49:38 +02:00
akallabeth
7a607dbc53
Merge pull request #10630 from akallabeth/disable-ctad-maybe-unuspported
...
[build,c++] add CXXCompilerFlags to (un)set warnings
2024-09-20 10:48:56 +02:00
akallabeth
699fc70941
[client,sdl] update to current sdl3-api
2024-09-20 10:19:29 +02:00
Armin Novak
02b98e9287
[client,sdl] use constexpr instead of defines
2024-09-20 09:17:03 +02:00
Armin Novak
96052ca2fb
[build,c++] add CXXCompilerFlags to set warnings
...
Just like with the C components and CompilerFlags.cmake add a
configuration for C++ that disables specific warnings only found in C++
code.
2024-09-20 09:16:30 +02:00
akallabeth
84719a4d83
[client,sdl] fix class constructors and operators
...
delete unused move/copy constructors and operators
2024-09-18 23:33:50 +02:00
Armin Novak
3905ef0b01
[client,sdl] split sdl_client_thread_run
...
the function can easily be split into three funcions covering a specific
part of the thread loop. Makes the whole thing less complex and easier
to read.
2024-09-18 13:01:46 +02:00
akallabeth
8ef4b2aefa
[client,SDL] move thread cleanup to own function
...
The cleanup code for the RDP thread of the SDL clients grew quite
complex. Move to a function to reduce complexity and make the main
thread more readable again.
2024-09-18 11:48:35 +02:00
akallabeth
b7601ec755
[client,SDL] remove goto usage, replace with RAII
...
* use std::uniqe_ptr to clean up malloced strings
* use ScopeGuard to run cleanup code whenever the function is exited
2024-09-18 11:48:35 +02:00
akallabeth
ed2c5e9a5b
[client,sdl] add scope guard
...
add a class wrapping a cleanup function called when the class instance
is out of scope. useful to clean up C resources in a lambda function
2024-09-18 11:48:34 +02:00
akallabeth
586f40631f
[warnings] fix shorten-64-to-32
2024-09-17 16:13:48 +02:00
David Fort
688f450fc2
SDL3 client: improve the treatment of clipboard data requests
...
This patch adds a success flag on clipboard data requests, so that we can react
correctly in the SDL handler. I've also made some errors non fatal like if you requests
a kind of data that doesn't exist the client should not terminateit's for that.
2024-09-17 11:37:48 +02:00
akallabeth
965d231e49
[return checks] fix use of CloseHandle
2024-09-16 08:22:31 +02:00
akallabeth
94020c183c
[return checks] fix use of ResetEvent
2024-09-16 06:48:09 +02:00
akallabeth
7d67b8e204
[return checks] fix use of SetEvent
2024-09-16 06:47:58 +02:00
akallabeth
2638d9d894
[warnings] fix casts
2024-09-12 13:30:00 +02:00
akallabeth
773eed8878
[client,sdl] use auto for variable declaration
2024-09-12 13:29:53 +02:00
akallabeth
e00661d338
[warnings] fix dead store warnings
2024-09-12 13:29:46 +02:00
akallabeth
c9b0c9ecd5
[warnings] remove unused variables
2024-09-12 10:08:10 +02:00
akallabeth
cc6850bf21
[warnings] fix format nonliteral
...
add pragma to suppress format nonliteral warnings where appropriate
2024-09-12 09:08:53 +02:00
akallabeth
2ae0c456b4
[client,sdl] fix float casts
2024-09-12 09:08:49 +02:00
akallabeth
2175428df5
[client,SDL] default webview to off
...
The AAD webview is currently not working as expected, disable until
resolved.
2024-09-11 22:23:33 +02:00
akallabeth
993756e575
[client,sdl] fix SDL3 compilation error
2024-09-11 21:50:30 +02:00
akallabeth
06097575a4
[client,sdl] fix redundant initializer
2024-09-11 20:50:36 +02:00
akallabeth
eec69bde0f
[client,sdl] fix c++ string find, use char overload
2024-09-11 20:50:14 +02:00
akallabeth
9fed64eb0d
[client,SDL] SdlEventUpdateTriggerGuard
...
Delete copy & move assingment operators
2024-09-11 20:48:39 +02:00
akallabeth
edf6ab89f7
[warnings] fix dead store
2024-09-10 14:43:11 +02:00
akallabeth
189abc73f3
[client,sdl] fix missing field initializer warnings
2024-09-10 14:42:42 +02:00
akallabeth
2a641aa834
[client,sdl3] update to new API
2024-09-10 12:46:27 +02:00
akallabeth
d93d9765b3
[client,sdl] add minimize shortcut
2024-09-10 12:28:36 +02:00
David Fort
3a9a820092
sdl3: fix build with last version of SDL3
2024-09-05 14:57:11 +02:00
akallabeth
8b92e17e60
modernize includes
2024-09-04 22:00:12 +02:00
akallabeth
5e123735fa
[warnings] fixed sign-compare
2024-09-04 10:14:05 +02:00
akallabeth
baa70d1ab6
[warnings] fix compare integers of different signs
2024-09-03 15:10:46 +02:00
akallabeth
5a4a1a40ad
fix declaration and implementation parameter names
2024-09-03 12:24:53 +02:00
akallabeth
cbae4155fb
[client,SDL] delete unused copy & move constructors
2024-09-03 12:17:20 +02:00
akallabeth
bd637c6cd1
[warnings] fix various clang-tidy warnings
2024-08-29 17:13:50 +02:00
akallabeth
500495dc00
[warnings] fix SDL3 related issues
2024-08-29 16:03:51 +02:00
akallabeth
ceae258e37
[warnings] fix clang-tidy issues in clients
2024-08-29 15:34:27 +02:00
akallabeth
1d33095500
[warnings] fix cert-err33-c
...
Fix unused return values, cast to void if on purpose
2024-08-29 10:19:27 +02:00
Armin Novak
d71af44bb1
[warnings] disable warnings for generated code
...
* Disable clang-tidy in test build directories
* Disable compiler warnings for test binary directories.
These contain generated code we can not change, so the warnings are just noise
2024-08-28 09:18:30 +02:00
akallabeth
56d660f258
[cmake] mark dependency includes SYSTEM
...
Mark all dependency include paths SYSTEM so warnings from system headers
are excluded from ci warning statistics
2024-08-26 11:10:49 +02:00
akallabeth
49dc431045
[client,sdl] add support for /monitors argument
2024-08-23 14:00:47 +02:00
akallabeth
37008506c2
[client,sdl] remove tab from dialog messages
2024-08-20 13:31:41 +02:00
akallabeth
39e8c077d4
[client,sdl] improve VerifyCertificate message
...
* Use FreeRDP_CertificateCallbackPreferPEM for callbacks
* Add notBefore and notAfter dates to callback messages
2024-08-20 12:42:51 +02:00
David Fort
4e6f7fb989
[sdl3] fix build against last SDL3
2024-08-12 11:50:02 +02:00
Armin Novak
44b07721ec
[client,X11] fix ActionScript
...
* Unify script calls
* Update documentation
* Fix home directory
2024-07-25 09:42:03 +02:00
akallabeth
e72bec8441
[client,SDL] fix thread termination order
...
* Wait in SDL thread until RDP thread has terminated to avoid race
conditions during autoreconnect
* Fix exit code mappings in case the connection was cancelled
2024-07-19 09:10:32 +02:00
