akallabeth
5f9ef68b07
[warnigs] fixed readability-non-const-parameter
2024-10-01 13:05:23 +02:00
akallabeth
47c5070805
Merge pull request #10635 from akallabeth/initialize-variables
...
Initialize variables
2024-09-30 16:04:20 +02:00
akallabeth
a820912a24
[winpr,utils] fix sterror_r detection and use
2024-09-30 15:41:50 +02:00
akallabeth
f529345d84
[warnings] fix Wcast-qual
2024-09-30 09:31:36 +02:00
akallabeth
26003e59cc
[va_list] initialize with ={0};
2024-09-24 11:06:18 +02:00
akallabeth
42e3c6fff8
[winpr,utils] fix winpr_strerror argument types
...
errno is of type int, so use a signed INT32 as argument type to avoid
warings with sign conversions
2024-09-20 10:57:21 +02:00
Armin Novak
bed6e7968e
[winpr,utils] fix plausibility checks in IniFile_Load_File
2024-09-18 11:47:01 +02:00
akallabeth
586f40631f
[warnings] fix shorten-64-to-32
2024-09-17 16:13:48 +02:00
akallabeth
ca260e13bb
[winpr,asn1] fix sign extraction for ASN1 integer
...
ASN1 integer might not be full 32bit integers, so extract the sign from
the first byte and append 0x80000000 after the rest of the integer was
successfully read.
2024-09-17 10:03:50 +02:00
akallabeth
bb242b9a89
[return checks] fix use of WaitForSingleObject
2024-09-16 08:22:37 +02:00
akallabeth
965d231e49
[return checks] fix use of CloseHandle
2024-09-16 08:22:31 +02:00
akallabeth
94020c183c
[return checks] fix use of ResetEvent
2024-09-16 06:48:09 +02:00
akallabeth
7c8c14294f
[return checks] fix use of ReleaseMutex
2024-09-16 06:48:06 +02:00
akallabeth
7d67b8e204
[return checks] fix use of SetEvent
2024-09-16 06:47:58 +02:00
akallabeth
0de75b305c
[warnings] fix unchecked return
2024-09-15 10:19:56 +02:00
akallabeth
a1cef8dd85
[warnings] silence and fix unused results
2024-09-14 21:29:28 +02:00
akallabeth
5a711f5ae4
[winpr,collections] fix cast to float
2024-09-14 08:24:45 +02:00
akallabeth
7ef9345743
Merge pull request #10549 from hardening/rcg2
...
core, channels: client-side remote credential guard
2024-09-13 08:24:14 +02:00
akallabeth
fb5934007a
[doxygen] add basic documentation for new API
...
* Add basic documentation for new functions/structs/data types since
3.0.0
2024-09-12 20:09:19 +02:00
akallabeth
c84655cd62
[warnings] remove const params
...
Avoid const TYPE* const type declarations
2024-09-12 14:29:25 +02:00
akallabeth
a1a1fc8658
[warnings] fix mismatches between declaration and implementation
2024-09-12 13:32:44 +02:00
akallabeth
f74fd1ab0f
[warnings] silence unused macro warnings
...
* Add WINPR_PRAGMA_DIAG_IGNORED_UNUSED_MACRO
* Silence usages that
2024-09-12 13:30:08 +02:00
akallabeth
adc4f2abf8
[warnings] fix unused variables
2024-09-12 13:29:58 +02:00
akallabeth
cc6850bf21
[warnings] fix format nonliteral
...
add pragma to suppress format nonliteral warnings where appropriate
2024-09-12 09:08:53 +02:00
akallabeth
384cd284d8
[warnings] use WINPR_CAST_CONST_AWAY
...
on locations that require (ugly) const to non const casts usw
WINPR_CAST_CONST_AWAY to do proper compiler specific casts to avoid
warnings
2024-09-11 23:41:50 +02:00
David Fort
a4bd5ba886
core, channels: client-side remote credential guard
...
This patch implements the client-side part of the remote credential guard feature
as described in MS-RDPEAR. The 2 main changes are: shipping the TSRemoteGuardaCreds in
NLA, and implement the rdpear channel that allows LSASS to remote all the calls to
our client. For now it's UNIX only as the windows implementation would be implemented
in a completely different way.
To test, you may establish you ccache and then connect with (RCG enabled on the server):
xfreerdp /remoteGuard /u:<user> /d:<domain> /v<server>
That should log you in, and in the session you should not be asked for credentials when
doing mstsc /remoteGuard /v:<other server>.
2024-09-11 17:15:11 +02:00
akallabeth
c1918ac189
[winpr,wlog] fix cast warning
2024-09-10 14:42:52 +02:00
akallabeth
9738fc40f3
Merge pull request #10548 from akallabeth/serial-port
...
[BSD] build-serial-port
2024-09-09 09:41:12 +02:00
akallabeth
b980bf2e14
[winpr,clipboard] use endian safe bitmap read/write
2024-09-04 21:56:44 +02:00
akallabeth
0eb0cff367
[winpr,utils] fix integer size warnings
2024-09-04 12:50:43 +02:00
akallabeth
5aff241096
Merge pull request #10554 from akallabeth/tidy-silence
...
Tidy silence
2024-09-04 10:35:22 +02:00
akallabeth
5e123735fa
[warnings] fixed sign-compare
2024-09-04 10:14:05 +02:00
akallabeth
ebbfe598dc
[winpr,utils] unify bitmap reading
...
* clipboard synthesizer needs to read the bitmap header, use the function
from utils/image
* check bitmap header in utils/image and abort if wrong
2024-09-04 09:07:18 +02:00
akallabeth
72ae7fb54f
[nolint] add cert-dcl37-c,cert-dcl51-cpp
2024-09-03 12:24:48 +02:00
Armin Novak
fe4cb6de65
[warnings] fix float/double warnings
2024-09-02 16:20:20 +02:00
akallabeth
6fb7bfd043
[winpr,unwind] fix _Unwind_GetLanguageSpecificData
...
The function has various return value definitions (void* or uintptr_t)
and no proper API versioning. So cast to the expected type regardless of
actual definition and silence linter for this specific line.
2024-08-31 11:17:54 +02:00
akallabeth
1dea19ac5f
[warnings] clang-tidy suppress warnings
...
* Suppress NOLINT(bugprone-suspicious-include)
* Suppress __STDC_WANT_LIB_EXT1__ 1 // NOLINT(bugprone-reserved-identifier,cert-dcl37-c,cert-dcl51-cpp)
2024-08-30 16:01:11 +02:00
akallabeth
500495dc00
[warnings] fix SDL3 related issues
2024-08-29 16:03:51 +02:00
akallabeth
6a3564407e
[warnings] fix clang-tidy issues in winpr
2024-08-29 15:20:39 +02:00
akallabeth
9c9d74e920
[warnings] fix redundant casts
2024-08-29 12:03:09 +02:00
akallabeth
15456e1ee1
[warnings] fix implicit widening conversion
2024-08-29 10:47:20 +02:00
akallabeth
1d33095500
[warnings] fix cert-err33-c
...
Fix unused return values, cast to void if on purpose
2024-08-29 10:19:27 +02:00
akallabeth
efde29f362
[winpr,utils] Set Queue_Enqueue only once
...
In #10527 performance was measured and SetEvent did take a lot of time
in these measurements. The reset is only required once though, so use a
more fine grained trigger condition.
2024-08-29 08:30:32 +02:00
akallabeth
d0addb52bd
[winpr,utils] Reset CountdownEvent_AddCount only once
...
In #10527 performance was measured and ResetEvent did take a lot of time
in these measurements. The reset is only required once though, so use a
more fine grained trigger condition.
2024-08-29 08:30:21 +02:00
Armin Novak
d71af44bb1
[warnings] disable warnings for generated code
...
* Disable clang-tidy in test build directories
* Disable compiler warnings for test binary directories.
These contain generated code we can not change, so the warnings are just noise
2024-08-28 09:18:30 +02:00
David Fort
c7b519472b
Merge pull request #10494 from fifthdegree/asn1_int_fix
...
Fix ASN.1 integer decoding
2024-08-21 22:46:37 +02:00
Isaac Klein
3fb7bd92cc
Don't accept 0-length ASN.1 integers for decoding
2024-08-21 14:02:26 -04:00
Armin Novak
17d44e847f
[coverity] fix various warnings
2024-08-21 09:47:34 +02:00
Isaac Klein
9c413abee1
Fix ASN.1 integer decoding
...
Treat ASN.1 encoded integers with a leading zero byte and the MSB of the
second byte set as non-negative
2024-08-20 19:14:02 -04:00
akallabeth
4b7727bd4e
[winpr,utils] fix PNG bpp extraction
2024-08-19 11:50:15 +02:00
