Ilya Shipitsin
14c15c680d
resolve several possible null pointer dereference
...
issue detected by cppcheck
[channels/drive/client/drive_main.c:454] -> [channels/drive/client/drive_main.c:443]: (warning) Either the condition '!irp' is redundant or there is possible null pointer dereference: irp.
[client/X11/xf_window.c:582] -> [client/X11/xf_window.c:580]: (warning) Either the condition '!xfc' is redundant or there is possible null pointer dereference: xfc.
[winpr/libwinpr/path/test/TestPathShell.c:40] -> [winpr/libwinpr/path/test/TestPathShell.c:43]: (warning) Either the condition '!path' is redundant or there is possible null pointer dereference: path.
[winpr/libwinpr/path/test/TestPathShell.c:49] -> [winpr/libwinpr/path/test/TestPathShell.c:52]: (warning) Either the condition '!path' is redundant or there is possible null pointer dereference: path.
2018-03-24 17:46:39 +05:00
Armin Novak
2517755d25
Fixed thread function return and parameters.
2018-03-07 14:36:55 +01:00
Martin Fleisz
9b4de7903f
drive: Fix possible NULL ptr access
2018-03-06 16:34:36 +01:00
David Fort
a132922376
Add checks for DR channel
2017-10-04 10:30:47 +02:00
David Fort
b624ecbfce
Fix for #4161
...
The checks were wrong, fix them.
2017-10-02 20:57:27 +02:00
Armin Novak
d1ebc39b07
Fixed file errno mapping.
2017-07-24 15:05:48 +02:00
Armin Novak
9a2c9c47d7
Fixed buffer read.
2017-07-24 11:32:54 +02:00
Armin Novak
6a06c8d991
Additional error checks for drive channel.
2017-07-24 11:31:48 +02:00
Armin Novak
478ca97a16
Fixed resource cleanup.
2017-07-20 09:35:41 +02:00
Norbert Federa
36b8f54c5e
Fixed a few compiler warnings
2017-07-10 17:52:05 +02:00
weizhenwei
bd94dcc6d5
remove duplicate code when freeing drive
2017-06-23 09:28:42 +08:00
weizhenwei
3b52a60d31
remove useless NULL pointer check before free
2017-06-23 09:21:16 +08:00
weizhenwei
61b24bf0b3
add NULL pointer check and set freed pointers to NULL afterward
2017-06-22 17:53:51 +08:00
weizhenwei
a2ecf403b2
fix memory leak at drive_register_drive_path() and drive_free()
2017-06-21 15:26:28 +08:00
joy.you
921f0b7480
fixed issue:#3974
...
ConvertToUnicode failed
2017-05-27 16:10:41 +08:00
Armin Novak
ed2c675a83
Fixed path length check.
2017-05-18 09:43:02 +02:00
Armin Novak
6b960a4319
Fix #3962 : Remove trailing slashes from path.
2017-05-17 16:43:16 +02:00
Armin Novak
73e89bffcc
Cleaned up includes.
2017-04-19 08:27:22 +02:00
David PHAM-VAN
5a66fe841a
Misc Fixes
2017-03-17 14:07:33 -07:00
David PHAM-VAN
d6f78df195
Verify ConvertFromUnicode return values
2017-03-16 16:27:01 -07:00
David PHAM-VAN
c7924b554d
Rewrite drive channel using WinPR functions
2017-03-13 14:18:46 -07:00
Norbert Federa
f71b6b46e8
fix string format specifiers
...
- fixed invalid, missing or additional arguments
- removed all type casts from arguments
- added missing (void*) typecasts for %p arguments
- use inttypes defines where appropriate
2016-12-16 13:48:43 +01:00
Norbert Federa
c6e6b44143
countless WLog/printf format specifier fixes
2016-11-25 17:06:25 +01:00
Marc-André Moreau
dee76617d9
channels: remove thread-local storage usage
2016-11-15 11:41:01 -05:00
Armin Novak
9f5da483dc
Reformatted files touched in last 2 commits.
2016-10-06 13:43:12 +02:00
Armin Novak
88a3b8dd76
Initializing channel context in each thread.
2016-10-06 13:43:12 +02:00
Norbert Federa
90cdfa7646
cmake: replaced STATIC_CHANNELS with BUILTIN_CHANNELS
2016-06-15 13:36:27 +02:00
Marc-André Moreau
4d629a7999
freerdp: UWP porting
2016-03-29 16:03:15 -04:00
Armin Novak
5acd80dd5b
Exporting channel entry points.
2016-02-29 15:18:19 +01:00
Martin Haimberger
52405a3e79
Remove WIN32ERROR type
...
All return values are UINT now.
2015-08-27 05:38:20 -07:00
Martin Haimberger
65fd259610
misc fixes:
...
fixed all bugs from the review
checking all WaitFor*Object/s calls
2015-07-30 06:49:21 -07:00
Martin Haimberger
58ada13dd9
fixed some remakes and compiler errors
2015-07-22 02:36:24 -07:00
Martin Haimberger
6ab0187d84
Merge remote-tracking branch 'upstream/master' into mh-channel
...
Conflicts:
channels/audin/client/oss/audin_oss.c
channels/drive/client/drive_main.c
channels/printer/client/printer_cups.c
channels/printer/client/printer_main.c
channels/rail/client/rail_main.c
channels/rdpgfx/client/rdpgfx_main.c
channels/rdpsnd/client/oss/rdpsnd_oss.c
channels/remdesk/client/remdesk_main.c
channels/remdesk/server/remdesk_main.c
channels/tsmf/client/tsmf_media.c
2015-07-15 01:57:07 -07:00
Martin Haimberger
b8c110d19b
introduced channel error reporting system
...
The rdpContext gets an event which will
get set if an error occoured in a channel.
If a thread or a void callback has to report an
error it will get signaled by this system.
2015-07-15 00:50:35 -07:00
Armin Novak
cf9f975341
Replaced snprintf with sprintf_s
2015-07-03 13:26:15 +02:00
Martin Haimberger
6e4e1c2773
Merge remote-tracking branch 'upstream/master' into mh-stream-fix
...
Conflicts:
client/Windows/wf_cliprdr.c
2015-06-18 03:06:40 -07:00
Martin Haimberger
d3d60520e5
hardend channel drive
2015-06-18 03:04:32 -07:00
David FORT
12f873f1f9
Fixed MessageQueue and callers
2015-05-29 14:24:14 +02:00
Marc-André Moreau
fdd2dc7601
freerdp: patch valgrind leaks, cleanup
2014-12-03 14:17:27 -05:00
Armin Novak
e390dd0eeb
Fixed null pointer dereference.
2014-11-17 01:19:40 +01:00
Zhang Zhaolong
60f283cffb
drive: fix contents lost when cut-paste a folder.
2014-08-18 16:00:34 +08:00
Hardening
ef11358668
Enhance ListDictonnary
...
This patch enhances ListDictionnary so that you can set callbacks for
keys and for values.
2014-04-18 18:26:04 +02:00
Marc-André Moreau
951368a1ce
Merge branch 'master' of github.com:FreeRDP/FreeRDP
2014-02-27 13:58:29 -05:00
Zhang Zhaolong
5157555d5b
drive: minor code formatting.
2014-02-12 11:34:33 +08:00
Marc-André Moreau
5ff847a6e6
wfreerdp: fix multiple warnings
2014-02-10 01:06:11 -05:00
Armin Novak
04854b292c
Using new API for MessageQueue.
2013-11-12 15:18:18 +01:00
Marc-André Moreau
bfa6410641
Merge pull request #1578 from ntwerdochlib/drive_channel_tweak
...
Minor optimization in Drive Channel
2013-11-07 09:18:50 -08:00
Nik Twerdochlib
c35c2bdeb6
Minor optimization in DeviceServiceEntry when setting up
...
to share all drives. Removed the call to strlen() and use
the return value from _snprintf
2013-11-07 11:43:22 -05:00
Marc-André Moreau
9b394a0189
channels/rdpdr: make use of MessageQueue for drive redirection
2013-11-03 21:01:36 -05:00
Marc-André Moreau
5406ebd5d8
channels/drive: refactoring
2013-11-03 19:10:33 -05:00
