Rewritten long mode page walk - large code cleanup and few bugfixes

This commit is contained in:
Stanislav Shwartsman 2009-05-30 15:09:38 +00:00
parent a98a917c98
commit 222129db4b
5 changed files with 236 additions and 247 deletions

View File

@ -1,5 +1,5 @@
/////////////////////////////////////////////////////////////////////////
// $Id: cpu.h,v 1.599 2009-05-28 08:26:17 sshwarts Exp $
// $Id: cpu.h,v 1.600 2009-05-30 15:09:38 sshwarts Exp $
/////////////////////////////////////////////////////////////////////////
//
// Copyright (C) 2001 MandrakeSoft S.A.
@ -3055,6 +3055,7 @@ public: // for now...
BX_SMF bx_phy_address translate_linear(bx_address laddr, unsigned curr_pl, unsigned rw);
#if BX_SUPPORT_PAE
BX_SMF bx_phy_address translate_linear_PAE(bx_address laddr, bx_address &lpf_mask, Bit32u &combined_access, unsigned curr_pl, unsigned rw);
BX_SMF int check_entry_PAE(const char *s, Bit64u entry, Bit64u reserved, unsigned rw, bx_bool *nx_fault);
#endif
BX_SMF BX_CPP_INLINE bx_phy_address dtranslate_linear(bx_address laddr, unsigned curr_pl, unsigned rw)
@ -3093,6 +3094,9 @@ public: // for now...
#endif
BX_SMF void pagingCR0Changed(Bit32u oldCR0, Bit32u newCR0) BX_CPP_AttrRegparmN(2);
BX_SMF void pagingCR4Changed(Bit32u oldCR4, Bit32u newCR4) BX_CPP_AttrRegparmN(2);
#if BX_SUPPORT_PAE
BX_SMF bx_bool CheckPDPTR(bx_bool pg, bx_bool pae, bx_address cr3_val);
#endif
BX_SMF void reset(unsigned source);
BX_SMF void shutdown(void);

View File

@ -1,5 +1,5 @@
/////////////////////////////////////////////////////////////////////////
// $Id: paging.cc,v 1.174 2009-04-07 16:12:19 sshwarts Exp $
// $Id: paging.cc,v 1.175 2009-05-30 15:09:38 sshwarts Exp $
/////////////////////////////////////////////////////////////////////////
//
// Copyright (C) 2001 MandrakeSoft S.A.
@ -301,6 +301,36 @@ static unsigned priv_check[BX_PRIV_CHECK_SIZE];
// | +------------> u/s of current access
// +---------------> Current CR0.WP value
/* PAE PML4: bits [51 .. physical address width] */
#define PAGING_PAE_PML4_RESERVED_BITS \
(BX_PHY_ADDRESS_RESERVED_BITS | BX_CONST64(0x80))
/* PAE PDPE: bits [51 .. physical address width] */
#define PAGING_LONG_MODE_PDPE_RESERVED_BITS \
(BX_PHY_ADDRESS_RESERVED_BITS)
#define PAGING_PAE_PDPE1G_RESERVED_BITS \
(BX_PHY_ADDRESS_RESERVED_BITS | BX_CONST64(0x3FFFE000))
/* PAE PDPE: bits [51 .. physical address width] */
#define PAGING_PAE_PDPE_RESERVED_BITS \
(BX_PHY_ADDRESS_RESERVED_BITS | BX_CONST64(0x1E6))
/* PAE PDE: bits [51 .. physical address width] */
#define PAGING_PAE_PDE_RESERVED_BITS (BX_PHY_ADDRESS_RESERVED_BITS)
/* PAE PTE: bits [51 .. physical address width] */
#define PAGING_PAE_PTE_RESERVED_BITS (BX_PHY_ADDRESS_RESERVED_BITS)
/* PAE PDE2M: bits [51 .. physical address width], [20:13] */
#define PAGING_PAE_PDE2M_RESERVED_BITS \
(PAGING_PAE_PDE_RESERVED_BITS | BX_CONST64(0x001FE000))
/* PSE PDE4M: bits [21:17] */
#define PAGING_PSE_PDE4M_RESERVED_BITS \
(BX_PHY_ADDRESS_RESERVED_BITS | BX_CONST64(0x003E0000))
#define PAGE_DIRECTORY_NX_BIT (BX_CONST64(0x8000000000000000))
// Each entry in the TLB cache has 3 entries:
//
@ -457,6 +487,31 @@ BX_CPU_C::SetCR3(bx_address val)
BX_CPU_THIS_PTR cr3 = val;
}
#if BX_SUPPORT_PAE
bx_bool BX_CPU_C::CheckPDPTR(bx_bool pg, bx_bool pae, bx_address cr3_val)
{
if (pg && pae && !long_mode())
{
cr3_val &= 0xffffffe0;
for (int n=0; n<4; n++) {
Bit64u pdptr;
// read PDPE cache entry
bx_phy_address entry_pdpe_addr = (bx_phy_address) (cr3_val | (n << 3));
access_read_physical(entry_pdpe_addr, 8, (Bit8u*)(&pdptr));
BX_DBG_PHY_MEMORY_ACCESS(BX_CPU_ID, entry_pdpe_addr, 8, BX_READ, (Bit8u*)(&pdptr));
if (pdptr & 0x1) {
if (pdptr & PAGING_PAE_PDPE_RESERVED_BITS)
return 0;
}
}
}
return 1; /* PDPTRs are fine */
}
#endif
// Called to initialize the TLB upon startup.
// Unconditional initialization of all TLB entries.
void BX_CPU_C::TLB_init(void)
@ -514,7 +569,7 @@ void BX_CPU_C::TLB_flush(void)
BX_CPU_THIS_PTR PDPE_CACHE.valid = 0;
#endif
#if BX__SUPPORT_LARGE_PAGES
#if BX_SUPPORT_LARGE_PAGES || BX_SUPPORT_PAE
BX_CPU_THIS_PTR TLB.split_large = 0; // flush whole TLB
#endif
@ -540,7 +595,7 @@ void BX_CPU_C::TLB_flushNonGlobal(void)
if (!(tlbEntry->accessBits & TLB_GlobalPage)) {
tlbEntry->lpf = BX_INVALID_TLB_ENTRY;
}
#if BX_SUPPORT_LARGE_PAGES
#if BX_SUPPORT_LARGE_PAGES || BX_SUPPORT_PAE
else if (~tlbEntry->lpf_mask > 0xfff)
BX_CPU_THIS_PTR TLB.split_large = 1;
#endif
@ -565,7 +620,7 @@ void BX_CPU_C::TLB_invlpg(bx_address laddr)
BX_DEBUG(("TLB_invlpg(0x"FMT_ADDRX"): invalidate TLB entry", laddr));
#if BX_SUPPORT_LARGE_PAGES
#if BX_SUPPORT_LARGE_PAGES || BX_SUPPORT_PAE
bx_bool large = 0;
if (BX_CPU_THIS_PTR TLB.split_large) {
@ -665,40 +720,40 @@ void BX_CPU_C::page_fault(unsigned fault, bx_address laddr, unsigned user, unsig
exception(BX_PF_EXCEPTION, error_code, 0);
}
/* PAE PML4: bits [51 .. physical address width], [7] - support 1G paging */
#define PAGING_PAE_PML4_RESERVED_BITS \
(BX_PHY_ADDRESS_RESERVED_BITS | BX_CONST64(0x80))
#if BX_SUPPORT_PAE
#if BX_SUPPORT_1G_PAGES
int BX_CPU_C::check_entry_PAE(const char *s, Bit64u entry, Bit64u reserved, unsigned rw, bx_bool *nx_fault)
{
if (!(entry & 0x1)) {
BX_DEBUG(("%s: entry not present", s));
return ERROR_NOT_PRESENT;
}
/* PAE PDPE: bits [51 .. physical address width], [7] - support 1G paging */
#define PAGING_PAE_PDPE_RESERVED_BITS \
(BX_PHY_ADDRESS_RESERVED_BITS)
#define PAGING_PAE_PDPE1G_RESERVED_BITS \
(PAGING_PAE_PDPE_RESERVED_BITS | BX_CONST64(0x3FFFE000))
#else
/* PAE PDPE: bits [51 .. physical address width], [7] - support 1G paging */
#define PAGING_PAE_PDPE_RESERVED_BITS \
(BX_PHY_ADDRESS_RESERVED_BITS | BX_CONST64(0x80))
#if BX_PHY_ADDRESS_WIDTH == 32
if (entry & BX_CONST64(0x000fffff00000000)) {
BX_PANIC(("%s: 0x%08x%08x: Only 32 bit physical address space is emulated !", s, GET32H(entry), GET32L(entry)));
}
#endif
if (entry & reserved) {
BX_DEBUG(("%s: reserved bit is set %08x:%08x", s, GET32H(entry), GET32L(entry)));
return ERROR_RESERVED | ERROR_PROTECTION;
}
#if BX_SUPPORT_X86_64
if (entry & PAGE_DIRECTORY_NX_BIT) {
if (! BX_CPU_THIS_PTR efer.get_NXE()) {
BX_DEBUG(("%s: NX bit set when EFER.NXE is disabled", s));
return ERROR_RESERVED | ERROR_PROTECTION;
}
if (rw == BX_EXECUTE) {
BX_DEBUG(("%s: non-executable page fault occured", s));
*nx_fault = 1;
}
}
#endif
/* PAE PDE: bits [51 .. physical address width] */
#define PAGING_PAE_PDE_RESERVED_BITS (BX_PHY_ADDRESS_RESERVED_BITS)
/* PAE PDE2M: bits [51 .. physical address width], [20:13] */
#define PAGING_PAE_PDE2M_RESERVED_BITS \
(PAGING_PAE_PDE_RESERVED_BITS | BX_CONST64(0x001FE000))
/* PAE PTE: bits [51 .. physical address width] */
#define PAGING_PAE_PTE_RESERVED_BITS (BX_PHY_ADDRESS_RESERVED_BITS)
#define PAGE_DIRECTORY_NX_BIT (BX_CONST64(0x8000000000000000))
#if BX_SUPPORT_PAE
return -1;
}
// Translate a linear address to a physical address in PAE paging mode
bx_phy_address BX_CPU_C::translate_linear_PAE(bx_address laddr, bx_address &lpf_mask, Bit32u &combined_access, unsigned curr_pl, unsigned rw)
@ -709,11 +764,12 @@ bx_phy_address BX_CPU_C::translate_linear_PAE(bx_address laddr, bx_address &lpf_
Bit64u pml4;
bx_phy_address pml4_addr = 0;
#endif
unsigned priv_index, nx_fault = 0;
bx_bool isWrite = (rw & 1); // write or r-m-w
unsigned priv_index;
bx_bool nx_fault = 0, isWrite = (rw & 1); // write or r-m-w
unsigned pl = (curr_pl == 3);
int fault;
combined_access = 0;
combined_access = 0x06;
#if BX_SUPPORT_X86_64
if (long_mode()) {
@ -723,29 +779,9 @@ bx_phy_address BX_CPU_C::translate_linear_PAE(bx_address laddr, bx_address &lpf_
access_read_physical(pml4_addr, 8, &pml4);
BX_DBG_PHY_MEMORY_ACCESS(BX_CPU_ID, pml4_addr, 8, BX_READ, (Bit8u*)(&pml4));
if (!(pml4 & 0x1)) {
BX_DEBUG(("PML4: entry not present"));
page_fault(ERROR_NOT_PRESENT, laddr, pl, rw);
}
#if BX_PHY_ADDRESS_WIDTH == 32
if (pml4 & BX_CONST64(0x000fffff00000000)) {
BX_PANIC(("PML4 0x%08x%08x: Only 32 bit physical address space is emulated !", GET32H(pml4), GET32L(pml4)));
}
#endif
if (pml4 & PAGING_PAE_PML4_RESERVED_BITS) {
BX_DEBUG(("PML4: reserved bit is set PML4=%08x:%08x", GET32H(pml4), GET32L(pml4)));
page_fault(ERROR_RESERVED | ERROR_PROTECTION, laddr, pl, rw);
}
if (pml4 & PAGE_DIRECTORY_NX_BIT) {
if (! BX_CPU_THIS_PTR efer.get_NXE()) {
BX_DEBUG(("PML4: NX bit set when EFER.NXE is disabled"));
page_fault(ERROR_RESERVED | ERROR_PROTECTION, laddr, pl, rw);
}
if (rw == BX_EXECUTE) {
BX_DEBUG(("PML4: non-executable page fault occured"));
nx_fault = 1;
}
}
fault = check_entry_PAE("PML4", pml4, PAGING_PAE_PML4_RESERVED_BITS, rw, &nx_fault);
if (fault >= 0)
page_fault(fault, laddr, pl, rw);
pdpe_addr = (bx_phy_address)((pml4 & BX_CONST64(0x000ffffffffff000)) |
((laddr & BX_CONST64(0x0000007fc0000000)) >> 27));
@ -772,78 +808,61 @@ bx_phy_address BX_CPU_C::translate_linear_PAE(bx_address laddr, bx_address &lpf_
pdpe = BX_CPU_THIS_PTR PDPE_CACHE.entry[(laddr >> 30) & 3];
}
if (!(pdpe & 0x1)) {
BX_DEBUG(("PAE PDPE: entry not present"));
page_fault(ERROR_NOT_PRESENT, laddr, pl, rw);
}
#if BX_PHY_ADDRESS_WIDTH == 32
if (pdpe & BX_CONST64(0x000fffff00000000)) {
BX_PANIC(("PAE PDPE 0x%08x%08x: Only 32 bit physical address space is emulated !", GET32H(pdpe), GET32L(pdpe)));
}
#endif
fault = check_entry_PAE("PDPE", pdpe, long_mode() ? BX_PHY_ADDRESS_RESERVED_BITS : PAGING_PAE_PDPE_RESERVED_BITS, rw, &nx_fault);
if (fault >= 0)
page_fault(fault, laddr, pl, rw);
#if BX_SUPPORT_X86_64
if (pdpe & PAGE_DIRECTORY_NX_BIT) {
if (! BX_CPU_THIS_PTR efer.get_NXE()) {
BX_DEBUG(("PDPE: NX bit set when EFER.NXE is disabled"));
page_fault(ERROR_RESERVED | ERROR_PROTECTION, laddr, pl, rw);
}
if (rw == BX_EXECUTE) {
BX_DEBUG(("PDPE: non-executable page fault occured"));
nx_fault = 1;
}
}
if (long_mode()) {
#if BX_SUPPORT_1G_PAGES
// 1G pages support
if (pdpe & 0x80) {
if (pdpe & PAGING_PAE_PDPE1G_RESERVED_BITS) {
BX_DEBUG(("PAE 1G PDPE: reserved bit is set: PDPE=%08x:%08x", GET32H(pdpe), GET32L(pdpe)));
if (pdpe & 0x80) {
if (pdpe & PAGING_PAE_PDPE1G_RESERVED_BITS) {
BX_DEBUG(("PAE 1G PDPE: reserved bit is set: PDPE=%08x:%08x", GET32H(pdpe), GET32L(pdpe)));
page_fault(ERROR_RESERVED | ERROR_PROTECTION, laddr, pl, rw);
}
// Combined access is just access from the pde (no pte involved).
combined_access = (pml4 & pdpe) & 0x06; // U/S and R/W
priv_index =
(BX_CPU_THIS_PTR cr0.get_WP() << 4) | // bit 4
(pl<<3) | // bit 3
(combined_access | isWrite); // bit 2,1,0
if (!priv_check[priv_index] || nx_fault)
page_fault(ERROR_PROTECTION, laddr, pl, rw);
if (BX_CPU_THIS_PTR cr4.get_PGE())
combined_access |= (pdpe & 0x100); // G
// Update PML4 A bit if needed.
if (!(pml4 & 0x20)) {
pml4 |= 0x20;
access_write_physical(pml4_addr, 8, &pml4);
BX_DBG_PHY_MEMORY_ACCESS(BX_CPU_ID, pml4_addr, 8, BX_WRITE, (Bit8u*)(&pml4));
}
// Update PDPE A bit if needed.
if (!(pdpe & 0x20)) {
pdpe |= 0x20;
access_write_physical(pdpe_addr, 8, &pdpe);
BX_DBG_PHY_MEMORY_ACCESS(BX_CPU_ID, pdpe_addr, 8, BX_WRITE, (Bit8u*)(&pdpe));
}
// Make up the physical page frame address.
ppf = (bx_phy_address)((pdpe & BX_CONST64(0x000fffffc0000000)) | (laddr & 0x3ffff000));
lpf_mask = 0x3fffffff;
return ppf;
}
#else
if (pdpe & 0x80) {
BX_DEBUG(("PAE PDPE: page size bit set when reserved"));
page_fault(ERROR_RESERVED | ERROR_PROTECTION, laddr, pl, rw);
}
// Combined access is just access from the pde (no pte involved).
combined_access = (pml4 & pdpe) & 0x06; // U/S and R/W
#if BX_SUPPORT_GLOBAL_PAGES
if (BX_CPU_THIS_PTR cr4.get_PGE())
combined_access |= (pdpe & 0x100); // G
#endif
priv_index =
(BX_CPU_THIS_PTR cr0.get_WP() << 4) | // bit 4
(pl<<3) | // bit 3
(combined_access & 0x06) | // bit 2,1
(isWrite); // bit 0
if (!priv_check[priv_index] || nx_fault)
page_fault(ERROR_PROTECTION, laddr, pl, rw);
// Update PML4 A bit if needed.
if (!(pml4 & 0x20)) {
pml4 |= 0x20;
access_write_physical(pml4_addr, 8, &pml4);
BX_DBG_PHY_MEMORY_ACCESS(BX_CPU_ID, pml4_addr, 8, BX_WRITE, (Bit8u*)(&pml4));
}
// Update PDPE A bit if needed.
if (!(pdpe & 0x20)) {
pdpe |= 0x20;
access_write_physical(pdpe_addr, 8, &pdpe);
BX_DBG_PHY_MEMORY_ACCESS(BX_CPU_ID, pdpe_addr, 8, BX_WRITE, (Bit8u*)(&pdpe));
}
// Make up the physical page frame address.
ppf = (bx_phy_address)((pdpe & BX_CONST64(0x000fffffc0000000)) | (laddr & 0x3ffff000));
lpf_mask = 0x3fffffff;
return ppf;
}
#endif
#endif
if (pdpe & PAGING_PAE_PDPE_RESERVED_BITS) {
BX_DEBUG(("PAE PDPE: reserved bit is set: PDPE=%08x:%08x", GET32H(pdpe), GET32L(pdpe)));
page_fault(ERROR_RESERVED | ERROR_PROTECTION, laddr, pl, rw);
}
#endif
bx_phy_address pde_addr = (bx_phy_address)((pdpe & BX_CONST64(0x000ffffffffff000))
| ((laddr & 0x3fe00000) >> 18));
@ -851,27 +870,9 @@ bx_phy_address BX_CPU_C::translate_linear_PAE(bx_address laddr, bx_address &lpf_
access_read_physical(pde_addr, 8, &pde);
BX_DBG_PHY_MEMORY_ACCESS(BX_CPU_ID, pde_addr, 8, BX_READ, (Bit8u*)(&pde));
if (!(pde & 0x1)) {
BX_DEBUG(("PAE PDE: entry not present"));
page_fault(ERROR_NOT_PRESENT, laddr, pl, rw);
}
#if BX_PHY_ADDRESS_WIDTH == 32
if (pde & BX_CONST64(0x000fffff00000000)) {
BX_PANIC(("PAE PDE 0x%08x%08x: Only 32 bit physical address space is emulated !", GET32H(pde), GET32L(pde)));
}
#endif
#if BX_SUPPORT_X86_64
if (pde & PAGE_DIRECTORY_NX_BIT) {
if (! BX_CPU_THIS_PTR efer.get_NXE()) {
BX_DEBUG(("PDE: NX bit set when EFER.NXE is disabled"));
page_fault(ERROR_RESERVED | ERROR_PROTECTION, laddr, pl, rw);
}
if (rw == BX_EXECUTE) {
BX_DEBUG(("PDE: non-executable page fault occured"));
nx_fault = 1;
}
}
#endif
fault = check_entry_PAE("PDE", pde, PAGING_PAE_PDE_RESERVED_BITS, rw, &nx_fault);
if (fault >= 0)
page_fault(fault, laddr, pl, rw);
// Ignore CR4.PSE in PAE mode
if (pde & 0x80) {
@ -888,20 +889,19 @@ bx_phy_address BX_CPU_C::translate_linear_PAE(bx_address laddr, bx_address &lpf_
}
#endif
#if BX_SUPPORT_GLOBAL_PAGES
if (BX_CPU_THIS_PTR cr4.get_PGE())
combined_access |= (pde & 0x100); // G
#endif
priv_index =
(BX_CPU_THIS_PTR cr0.get_WP() << 4) | // bit 4
(pl<<3) | // bit 3
(combined_access & 0x06) | // bit 2,1
(isWrite); // bit 0
(combined_access | isWrite); // bit 2,1,0
if (!priv_check[priv_index] || nx_fault)
page_fault(ERROR_PROTECTION, laddr, pl, rw);
#if BX_SUPPORT_GLOBAL_PAGES
if (BX_CPU_THIS_PTR cr4.get_PGE())
combined_access |= (pde & 0x100); // G
#endif
#if BX_SUPPORT_X86_64
if (long_mode()) {
// Update PML4 A bit if needed.
@ -910,16 +910,16 @@ bx_phy_address BX_CPU_C::translate_linear_PAE(bx_address laddr, bx_address &lpf_
access_write_physical(pml4_addr, 8, &pml4);
BX_DBG_PHY_MEMORY_ACCESS(BX_CPU_ID, pml4_addr, 8, BX_WRITE, (Bit8u*)(&pml4));
}
// Update PDPE A bit if needed.
if (!(pdpe & 0x20)) {
pdpe |= 0x20;
access_write_physical(pdpe_addr, 8, &pdpe);
BX_DBG_PHY_MEMORY_ACCESS(BX_CPU_ID, pdpe_addr, 8, BX_WRITE, (Bit8u*)(&pdpe));
}
}
#endif
// Update PDPE A bit if needed.
if (!(pdpe & 0x20)) {
pdpe |= 0x20;
access_write_physical(pdpe_addr, 8, &pdpe);
BX_DBG_PHY_MEMORY_ACCESS(BX_CPU_ID, pdpe_addr, 8, BX_WRITE, (Bit8u*)(&pdpe));
}
// Update PDE A/D bits if needed.
if (((pde & 0x20)==0) || (isWrite && ((pde & 0x40)==0))) {
pde |= (0x20 | (isWrite<<6)); // Update A and possibly D bits
@ -934,11 +934,6 @@ bx_phy_address BX_CPU_C::translate_linear_PAE(bx_address laddr, bx_address &lpf_
return ppf;
}
if (pde & PAGING_PAE_PDE_RESERVED_BITS) {
BX_DEBUG(("PAE PDE: reserved bit is set PDE=%08x:%08x", GET32H(pde), GET32L(pde)));
page_fault(ERROR_RESERVED | ERROR_PROTECTION, laddr, pl, rw);
}
// 4k pages, Get page table entry
bx_phy_address pte_addr = (bx_phy_address)((pde & BX_CONST64(0x000ffffffffff000)) |
((laddr & 0x001ff000) >> 9));
@ -946,31 +941,9 @@ bx_phy_address BX_CPU_C::translate_linear_PAE(bx_address laddr, bx_address &lpf_
access_read_physical(pte_addr, 8, &pte);
BX_DBG_PHY_MEMORY_ACCESS(BX_CPU_ID, pte_addr, 8, BX_READ, (Bit8u*)(&pte));
if (!(pte & 0x1)) {
BX_DEBUG(("PAE PTE: entry not present"));
page_fault(ERROR_NOT_PRESENT, laddr, pl, rw);
}
#if BX_PHY_ADDRESS_WIDTH == 32
if (pte & BX_CONST64(0x000fffff00000000)) {
BX_PANIC(("PAE PTE 0x%08x%08x: Only 32 bit physical address space is emulated !", GET32H(pte), GET32L(pte)));
}
#endif
if (pte & PAGING_PAE_PTE_RESERVED_BITS) {
BX_DEBUG(("PAE PTE: reserved bit is set PTE=%08x:%08x", GET32H(pte), GET32L(pte)));
page_fault(ERROR_RESERVED | ERROR_PROTECTION, laddr, pl, rw);
}
#if BX_SUPPORT_X86_64
if (pte & PAGE_DIRECTORY_NX_BIT) {
if (! BX_CPU_THIS_PTR efer.get_NXE()) {
BX_DEBUG(("PTE: NX bit set when EFER.NXE is disabled"));
page_fault(ERROR_RESERVED | ERROR_PROTECTION, laddr, pl, rw);
}
if (rw == BX_EXECUTE) {
BX_DEBUG(("PTE: non-executable page fault occured"));
nx_fault = 1;
}
}
#endif
fault = check_entry_PAE("PTE", pte, PAGING_PAE_PTE_RESERVED_BITS, rw, &nx_fault);
if (fault >= 0)
page_fault(fault, laddr, pl, rw);
combined_access = (pde & pte) & 0x06; // U/S and R/W
#if BX_SUPPORT_X86_64
@ -979,37 +952,36 @@ bx_phy_address BX_CPU_C::translate_linear_PAE(bx_address laddr, bx_address &lpf_
}
#endif
#if BX_SUPPORT_GLOBAL_PAGES
if (BX_CPU_THIS_PTR cr4.get_PGE())
combined_access |= (pte & 0x100); // G
#endif
priv_index =
(BX_CPU_THIS_PTR cr0.get_WP() << 4) | // bit 4
(pl<<3) | // bit 3
(combined_access & 0x06) | // bit 2,1
(isWrite); // bit 0
(combined_access | isWrite); // bit 2,1,0
if (!priv_check[priv_index] || nx_fault)
page_fault(ERROR_PROTECTION, laddr, pl, rw);
#if BX_SUPPORT_X86_64
if (long_mode()) {
// Update PML4 A bit if needed.
if (!(pml4 & 0x20)) {
pml4 |= 0x20;
access_write_physical(pml4_addr, 8, &pml4);
BX_DBG_PHY_MEMORY_ACCESS(BX_CPU_ID, pml4_addr, 8, BX_WRITE, (Bit8u*)(&pml4));
}
}
#if BX_SUPPORT_GLOBAL_PAGES
if (BX_CPU_THIS_PTR cr4.get_PGE())
combined_access |= (pte & 0x100); // G
#endif
// Update PDPE A bit if needed.
if (!(pdpe & 0x20)) {
pdpe |= 0x20;
access_write_physical(pdpe_addr, 8, &pdpe);
BX_DBG_PHY_MEMORY_ACCESS(BX_CPU_ID, pdpe_addr, 8, BX_WRITE, (Bit8u*)(&pdpe));
#if BX_SUPPORT_X86_64
if (long_mode()) {
// Update PML4 A bit if needed.
if (!(pml4 & 0x20)) {
pml4 |= 0x20;
access_write_physical(pml4_addr, 8, &pml4);
BX_DBG_PHY_MEMORY_ACCESS(BX_CPU_ID, pml4_addr, 8, BX_WRITE, (Bit8u*)(&pml4));
}
// Update PDPE A bit if needed.
if (!(pdpe & 0x20)) {
pdpe |= 0x20;
access_write_physical(pdpe_addr, 8, &pdpe);
BX_DBG_PHY_MEMORY_ACCESS(BX_CPU_ID, pdpe_addr, 8, BX_WRITE, (Bit8u*)(&pdpe));
}
}
#endif
// Update PDE A bit if needed.
if (!(pde & 0x20)) {
@ -1033,10 +1005,6 @@ bx_phy_address BX_CPU_C::translate_linear_PAE(bx_address laddr, bx_address &lpf_
#endif // BX_SUPPORT_PAE
/* PSE PDE4M: bits [21:17] */
#define PAGING_PSE_PDE4M_RESERVED_BITS \
(BX_PHY_ADDRESS_RESERVED_BITS | BX_CONST64(0x003E0000))
// Translate a linear address to a physical address
bx_phy_address BX_CPU_C::translate_linear(bx_address laddr, unsigned curr_pl, unsigned rw)
{
@ -1116,22 +1084,21 @@ bx_phy_address BX_CPU_C::translate_linear(bx_address laddr, unsigned curr_pl, un
// Combined access is just access from the pde (no pte involved).
combined_access = pde & 0x06; // U/S and R/W
#if BX_SUPPORT_GLOBAL_PAGES
if (BX_CPU_THIS_PTR cr4.get_PGE())
combined_access |= pde & 0x100; // {G}
#endif
priv_index =
#if BX_CPU_LEVEL >= 4
(BX_CPU_THIS_PTR cr0.get_WP() << 4) | // bit 4
#endif
(pl<<3) | // bit 3
(combined_access & 0x06) | // bit 2,1
(isWrite); // bit 0
(combined_access | isWrite); // bit 2,1,0
if (!priv_check[priv_index])
page_fault(ERROR_PROTECTION, laddr, pl, rw);
#if BX_SUPPORT_GLOBAL_PAGES
if (BX_CPU_THIS_PTR cr4.get_PGE())
combined_access |= pde & 0x100; // G
#endif
// Update PDE A/D bits if needed.
if (((pde & 0x20)==0) || (isWrite && ((pde & 0x40)==0))) {
pde |= (0x20 | (isWrite<<6)); // Update A and possibly D bits
@ -1166,22 +1133,21 @@ bx_phy_address BX_CPU_C::translate_linear(bx_address laddr, unsigned curr_pl, un
combined_access = (pde & pte) & 0x06; // U/S and R/W
#endif
#if BX_SUPPORT_GLOBAL_PAGES
if (BX_CPU_THIS_PTR cr4.get_PGE())
combined_access |= (pte & 0x100); // G
#endif
priv_index =
#if BX_CPU_LEVEL >= 4
(BX_CPU_THIS_PTR cr0.get_WP() << 4) | // bit 4
#endif
(pl<<3) | // bit 3
(combined_access & 0x06) | // bit 2,1
(isWrite); // bit 0
(combined_access | isWrite); // bit 2,1,0
if (!priv_check[priv_index])
page_fault(ERROR_PROTECTION, laddr, pl, rw);
#if BX_SUPPORT_GLOBAL_PAGES
if (BX_CPU_THIS_PTR cr4.get_PGE())
combined_access |= (pte & 0x100); // G
#endif
// Update PDE A bit if needed.
if (!(pde & 0x20)) {
pde |= 0x20;
@ -1204,7 +1170,7 @@ bx_phy_address BX_CPU_C::translate_linear(bx_address laddr, unsigned curr_pl, un
// Calculate physical memory address and fill in TLB cache entry
paddress = ppf | poffset;
#if BX_SUPPORT_LARGE_PAGES
#if BX_SUPPORT_LARGE_PAGES || BX_SUPPORT_PAE
if (lpf_mask > 0xfff)
BX_CPU_THIS_PTR TLB.split_large = 1;
#endif

View File

@ -1,5 +1,5 @@
/////////////////////////////////////////////////////////////////////////
// $Id: proc_ctrl.cc,v 1.296 2009-05-07 12:00:02 sshwarts Exp $
// $Id: proc_ctrl.cc,v 1.297 2009-05-30 15:09:38 sshwarts Exp $
/////////////////////////////////////////////////////////////////////////
//
// Copyright (C) 2001 MandrakeSoft S.A.
@ -1429,11 +1429,11 @@ bx_address get_cr4_allow_mask(void)
allowMask |= (1<<3); /* DE */
#if BX_SUPPORT_LARGE_PAGES
allowMask |= (1<<4);
allowMask |= (1<<4); /* PSE */
#endif
#if BX_SUPPORT_PAE
allowMask |= (1<<5);
allowMask |= (1<<5); /* PAE */
#endif
#if BX_CPU_LEVEL >= 5

View File

@ -1,5 +1,5 @@
/////////////////////////////////////////////////////////////////////////
// $Id: vmx.cc,v 1.17 2009-05-28 08:26:17 sshwarts Exp $
// $Id: vmx.cc,v 1.18 2009-05-30 15:09:38 sshwarts Exp $
/////////////////////////////////////////////////////////////////////////
//
// Copyright (c) 2009 Stanislav Shwartsman
@ -244,6 +244,7 @@ VMX_error_code BX_CPU_C::VMenterLoadCheckVmControls(void)
vm->vm_tpr_threshold = VMread32(VMCS_32BIT_CONTROL_TPR_THRESHOLD);
vm->virtual_apic_page_addr = (bx_phy_address) VMread64(VMCS_64BIT_CONTROL_VIRTUAL_APIC_PAGE_ADDR);
vm->executive_vmcsptr = (bx_phy_address) VMread64(VMCS_64BIT_CONTROL_EXECUTIVE_VMCS_PTR);
//
// Check VM-execution control fields
@ -412,6 +413,13 @@ VMX_error_code BX_CPU_C::VMenterLoadCheckVmControls(void)
return VMXERR_VMENTRY_INVALID_VM_CONTROL_FIELD;
}
if (vm->vmentry_ctrls & VMX_VMENTRY_CTRL1_DEACTIVATE_DUAL_MONITOR_TREATMENT) {
if (! BX_CPU_THIS_PTR in_smm) {
BX_ERROR(("VMFAIL: VMENTRY from outside SMM with dual-monitor treatment enabled"));
return VMXERR_VMENTRY_INVALID_VM_CONTROL_FIELD;
}
}
if (vm->vmentry_msr_load_cnt > 0) {
if ((vm->vmentry_msr_load_addr & 0xf) != 0 || ! IsValidPhyAddr(vm->vmentry_msr_load_addr)) {
BX_ERROR(("VMFAIL: VMCS VMENTRY CTRL: msr load addr malformed"));
@ -1952,6 +1960,13 @@ void BX_CPU_C::VMLAUNCH(bxInstruction_c *i)
VMexit(0, state_load_error | (1 << 31), qualification);
}
#if BX_SUPPORT_PAE
if (! CheckPDPTR(BX_CPU_THIS_PTR cr0.get_PG(), BX_CPU_THIS_PTR cr4.get_PAE(), BX_CPU_THIS_PTR cr3)) {
BX_ERROR(("VMEXIT: Guest State PDPTRs Checks Failed"));
VMexit(0, VMX_VMEXIT_VMENTRY_FAILURE_GUEST_STATE | (1 << 31), VMENTER_ERR_GUEST_STATE_PDPTR_LOADING);
}
#endif
Bit32u msr = LoadMSRs(BX_CPU_THIS_PTR vmcs.vmentry_msr_load_cnt, BX_CPU_THIS_PTR vmcs.vmentry_msr_load_addr);
if (msr) {
BX_ERROR(("VMEXIT: Error when loading guest MSR 0x%08x", msr));
@ -2042,6 +2057,7 @@ void BX_CPU_C::VMPTRLD(bxInstruction_c *i)
bx_address eaddr = BX_CPU_CALL_METHODR(i->ResolveModrm, (i));
Bit64u pAddr = read_virtual_qword(i->seg(), eaddr); // keep 64-bit
if ((pAddr & 0xfff) != 0 || ! IsValidPhyAddr(pAddr)) {
BX_ERROR(("VMFAIL: invalid or not page aligned physical address !"));
VMfail(VMXERR_VMPTRLD_INVALID_PHYSICAL_ADDRESS);
return;
}
@ -2057,12 +2073,13 @@ void BX_CPU_C::VMPTRLD(bxInstruction_c *i)
BX_READ, (Bit8u*)(&revision));
if (revision != VMX_VMCS_REVISION_ID) {
BX_ERROR(("VMPTRLD: not expected (%d != %d) VMCS revision id !", revision, VMX_VMCS_REVISION_ID));
VMfail(VMXERR_VMPTRLD_INCORRECT_VMCS_REVISION_ID);
return;
}
set_VMCSPTR(pAddr);
VMsucceed();
else {
set_VMCSPTR(pAddr);
VMsucceed();
}
}
#else
BX_INFO(("VMPTRLD: required VMX support, use --enable-vmx option"));
@ -2407,6 +2424,7 @@ void BX_CPU_C::VMWRITE(bxInstruction_c *i)
enc_64 = read_virtual_qword_64(i->seg(), eaddr);
}
if (enc_64 >> 32) {
BX_ERROR(("VMWRITE: not supported field !"));
VMfail(VMXERR_UNSUPPORTED_VMCS_COMPONENT_ACCESS);
return;
}
@ -2644,6 +2662,7 @@ void BX_CPU_C::VMWRITE(bxInstruction_c *i)
case VMCS_IO_RDI:
case VMCS_IO_RIP:
case VMCS_GUEST_LINEAR_ADDR:
BX_ERROR(("VMWRITE: write to read/only field %08x", encoding));
VMfail(VMXERR_VMWRITE_READ_ONLY_VMCS_COMPONENT);
return;

View File

@ -591,13 +591,13 @@ typedef struct bx_VMCS
// VM-Entry Control Fields
//
#define VMX_VMENTRY_CTRL1_LOAD_DBG_CTRLS (1 << 2) /* legacy must be '1 */
#define VMX_VMENTRY_CTRL1_X86_64_GUEST (1 << 9)
#define VMX_VMENTRY_CTRL1_SMM_ENTER (1 << 10)
#define VMX_VMENTRY_CTRL1_DUAL_MONITOR_TREATMENT (1 << 11)
#define VMX_VMENTRY_CTRL1_LOAD_PERF_GLOBAL_CTRL_MSR (1 << 13)
#define VMX_VMENTRY_CTRL1_LOAD_PAT_MSR (1 << 14)
#define VMX_VMENTRY_CTRL1_LOAD_EFER_MSR (1 << 15)
#define VMX_VMENTRY_CTRL1_LOAD_DBG_CTRLS (1 << 2) /* legacy must be '1 */
#define VMX_VMENTRY_CTRL1_X86_64_GUEST (1 << 9)
#define VMX_VMENTRY_CTRL1_SMM_ENTER (1 << 10)
#define VMX_VMENTRY_CTRL1_DEACTIVATE_DUAL_MONITOR_TREATMENT (1 << 11)
#define VMX_VMENTRY_CTRL1_LOAD_PERF_GLOBAL_CTRL_MSR (1 << 13)
#define VMX_VMENTRY_CTRL1_LOAD_PAT_MSR (1 << 14)
#define VMX_VMENTRY_CTRL1_LOAD_EFER_MSR (1 << 15)
#ifdef BX_VMX_ENABLE_ALL
@ -609,7 +609,7 @@ typedef struct bx_VMCS
(VMX_VMENTRY_CTRL1_LOAD_DBG_CTRLS | \
VMX_VMENTRY_CTRL1_X86_64_GUEST | \
VMX_VMENTRY_CTRL1_SMM_ENTER | \
VMX_VMENTRY_CTRL1_DUAL_MONITOR_TREATMENT)
VMX_VMENTRY_CTRL1_DEACTIVATE_DUAL_MONITOR_TREATMENT)
#endif