Commit Graph

54249 Commits

Author SHA1 Message Date
Axel Dörfler
fd3e3e7bfb BTwoDimensionalLayout: Removed duplicated code.
* Probably some refactoring leftovers.
2015-07-30 19:49:53 +02:00
Axel Dörfler
99b4affab6 Added BWindow::ResizeToPreferred().
* B_AUTO_UPDATE_SIZE_LIMITS only really makes sense for resizable
  windows, and it only sets the minimum/maximum window size.
* ResizeToPreferred() resizes the window to its preferred size, and
  also supports height-for-width layouts.
2015-07-30 19:49:48 +02:00
Dario Casalinuovo
7bdc7eec03 Media: Refresh window also at QUIT event.
* Since the Media preferences are always watching for media
  status, it's good to clean up the window when the media services
  are not running. This avoid the user try to use controls where
  services are down.
2015-07-30 19:14:13 +02:00
Dario Casalinuovo
922d2034b2 Media: Reinit media also when the restart thread finish 2015-07-30 13:23:27 +02:00
Dario Casalinuovo
1ce097dbb0 BMediaRoster: Wait with more calm for services to be up.
* Needed to avoid the app restarting things too fast. This
  is a problem that should be solved, added a TODO.
2015-07-30 13:23:24 +02:00
Automatic Committer
5f01992f3a Update pci.ids from pciids.sourceforge.net 2015-07-30 05:20:27 +02:00
Adrien Destugues
f93dab03ec getifaddrs: don't fail if there are no interfaces.
* This is not an error, just return an empty list.
* Same behavior as *BSD implementation.
2015-07-29 22:54:49 +02:00
Adrien Destugues
2df7158917 DHCPClient: don't use AI_ADDRCONFIG
* The DHCP Client is the one configuring interfaces, so it makes no
sense to request address resolution for already configured interfaces
only.
* Fixes #12208
2015-07-29 22:54:47 +02:00
Augustin Cavalier
f9ab315e02 DHCPClient: Check return code of SetAddress().
This should break DHCP for everyone it currently works for (according
to our analysis). If it doesn't, we have yet another (set of) bug(s).
2015-07-29 15:06:04 -04:00
Augustin Cavalier
b3e2208e52 ffmpeg plugin: Remove [L]GPL, FFmpeg is not in the tree anymore. 2015-07-29 15:02:21 -04:00
Augustin Cavalier
1c62023701 NetworkAddress: Fix things yet again.
If I had used my head instead of blindly c&p'ing the suggested code
from Axel's message, I would have realized that Unset() unsets fStatus
too. Not a bright thing to do on my part...
2015-07-29 15:00:53 -04:00
Augustin Cavalier
1690d2f4dd BNetworkAddress: Fix review comments (again).
Axel changed his mind about the status on Unset(), and I messed
up the fStatus setters.
2015-07-29 14:41:55 -04:00
Dario Casalinuovo
7482390ab4 Media: Improve both notifications and quit mechanism
* Media is now waiting for media_server to start if the window
  is closed before to finish, this was proposed by stippi.
* Moved out anything related to notifications as they are now
  managed by the media_kit.
* Solved some TODOs and minor issues too.
2015-07-29 18:05:04 +02:00
Dario Casalinuovo
8acd164f8c Add new version of launch_media_server
* Due to the needs to provide a peaceful UX, i moved out the
  notifications mechanism from the Media preflet and i have
  integrated it with the launch and shutdown functions of MediaDefs.h.
* This implied to introduce a new launch_media_server function
  similar to the shutdown_media_server allowing to specify a custom
  notification function too.
* Both functions then are reworked to send by default notifications
  to the Deskbar, this was needed because in a lot of situations
  the mechanism failed without correctly noticing the user.
* The one argument launch_media_server is considered to be deprecated,
  the default argument is removed to mantain binary compatibility but
  make new apps to automatically use the new one with just the default
  arguments. This is needed due to conflicts in overloading.
* Improve notifications by indirectly extending localization
  to old BeOS apps.
2015-07-29 18:03:32 +02:00
Stefano Ceccherini
e716f48778 ChannelSlider: don't check be_control_look for NULL
Also if0 the code that draws the old/dano look so it's more clear that
it's not called intentionally.
2015-07-29 15:20:11 +02:00
Fredrik Holmqvist
0cd38980a3 Add unit tests specific for #12208. Pass depends on network.
NetworkAddressTest passes (most) tests when you have network.
When no network interface (ie -net none in QEMU) tests take forever and
more tests fail.
When network interface exists but is disabled in Haiku, tests are fast but
more tests fail.
2015-07-28 22:13:23 +02:00
Stefano Ceccherini
9b7802354f BChannelSlider: Fixed memory leak.
At least, I think so.
Check allocations in BChannelSlider::ThumbFor()-
Also updated copyright and e-mail address.
2015-07-28 21:40:21 +02:00
Augustin Cavalier
ef34aca426 WebPositive: Fix "new tab opens search page".
Fixes #12251.
2015-07-28 13:24:17 -04:00
Humdinger
2bcaf0d83b Update/add fftw packages for Haiku gcc2hybrid. 2015-07-28 17:57:34 +02:00
Markus Himmel
e4eecdb5c0 Correctly show normal-sized preview after returning from a very wide one
If the height had been reduced due to a very wide window being shown,
it was not reset to its full value when switching back to a more
narrow preview. Fix this by relayouting the window.

Signed-off-by: Augustin Cavalier <waddlesplash@gmail.com>
2015-07-28 11:31:29 -04:00
Augustin Cavalier
d682f9fc9c BNetworkAddress: Address review comments.
Thanks Axel and Rene!
2015-07-28 10:14:58 -04:00
Augustin Cavalier
71b756a054 BNetworkAddress: Fix setting fStatus all over the place.
Relevant quote from IRC:
<pdziepak> i would expect all overloads of SetTo to return status_t
<pdziepak> actually, i don't think what i would expect from class with such interface
<pdziepak> bugs probably
2015-07-27 16:17:59 -04:00
Dario Casalinuovo
5934b30b95 media_server: Fix deadlock when killing from ProcessController 2015-07-27 20:25:31 +02:00
Dario Casalinuovo
009034bdf0 Media: Display alert before to quit when restarting
* Fixes 10770.
* While more complex solutions are proposed, i think
  of it as a way to get out of an eventual deadlock or
  to protect from accident close.
2015-07-27 20:25:26 +02:00
Dario Casalinuovo
40de3cd148 BMediaRoster: Definitely undertake the MediaRosterUndertaker
* On a more deep analysis i figured out that other than being
  a bad pratice quitting the BLooper explicitly was cause of
  more problems, such as the regression after my patches which
  led to have a zombie media_addon_server after media services
  restart. This should hopefully place a final stone on the
  BMediaRoster::Quit() issue as with the previous commit
  i've removed every attempt to do this in the system. For
  any application developer listening, this means that quitting
  the BMediaRoster is highly discouraged, don't do it.
2015-07-27 18:28:57 +02:00
Dario Casalinuovo
3f5483c79b desklink: Fix problems with BMediaRoster Quit
* Improved the situation so that it should be always
  synchronized. Improved error message, and detection
  of media services not being run.
2015-07-27 18:28:53 +02:00
Rene Gollent
9123fde7b9 Debugger: Implement #9783.
TeamDebugger:
- When we're notified that the target team has called exec(), take all
  necessary steps to prepare. These include saving settings for the old
  team, clearing out breakpoints, resetting signal dispositions, and
  removing the old team's image list. Also set a flag indicating an exec
  is pending for later processing.
- On image load notification, if the pending flag is set, check if the
  new image is the app image, and if so update the team's name to
  the new image, load that respective team's settings, and set a
  temporary breakpoint in its main() so the user has a chance to
  perform any additional desired actions before starting execution
  in the new executable.
2015-07-26 14:37:28 -04:00
Rene Gollent
10bbf8cb8d Debugger: TeamWindow refactor.
- When asked to load settings, post a message and do so in the window's
  message loop. This avoids a lock order reversal when asked to do so
  later as a result of exec() changing the target image out.
2015-07-26 14:37:28 -04:00
Rene Gollent
754b42a5a1 Debugger: Add rename event for Team.
Team:
- Add listener hook and event type for rename events. These occur on exec()
  since at this point we're running a different executable.

TeamWindow:
- Factor out code for generating window title into a helper, and use from both
  window initialization and newly implemented rename listener hook.
2015-07-26 14:37:27 -04:00
Rene Gollent
25c638c20b Debugger: Adjust ThreadHandler.
- SetBreakpointAndRun() now takes an additional argument indicating if this
  invocation is for a fresh run of a team or not, as continuing the thread's
  execution needs to be done differently in the two cases.
2015-07-26 14:37:26 -04:00
Rene Gollent
8f21b17520 Debugger: Add more helpers to Team.
ClearImages():
- Removes all existing images from the team's image list and notifies callers.
  To be used in case of an exec().

ClearSignalDispositionMappings():
- Remove any existing custom signal disposition mappings. This is intended to
  be used in preparation for loading new ones from a team after exec() is
  called.
2015-07-26 14:37:26 -04:00
Adrien Destugues
209cd3dd4f Remove second half of useless condition.
Thanks to Ingo for reviewing!
2015-07-26 20:31:10 +02:00
Adrien Destugues
58164f4a49 PVS 122,123: useless checks. 2015-07-26 16:57:10 +02:00
Adrien Destugues
7895cfc69b PVS 114: useless check.
We return a few line above if err is != 0.
2015-07-26 16:57:09 +02:00
Adrien Destugues
0e17424c6f PVS 112: check result of memcmp against 0. 2015-07-26 16:57:07 +02:00
Adrien Destugues
3ec6800839 PVS 109: useless check
error was already checked one line above.
2015-07-26 16:57:06 +02:00
Adrien Destugues
2f8639483a PVS 170: use boolean for if comparison
Direct use of strcmp result in if is against our coding style.
2015-07-26 16:57:05 +02:00
Adrien Destugues
67d9a9cb16 PVS 104: duplicate if check. 2015-07-26 16:57:03 +02:00
Adrien Destugues
c13e346a48 PVS 95-103: useless error checks
These conditions were always true, remove them.
2015-07-26 16:57:02 +02:00
Adrien Destugues
69ee6a6d62 PVS 78-85: useless checks
* These were always true, so remove them.
2015-07-26 16:57:01 +02:00
Adrien Destugues
32a6b04592 PVS76: useless check of null pointer
Refactor BResources::WriteResource to return early in case of errors,
instead of checking permanently if (error == B_OK). Makes the code more
readable and removes some useless checks.
2015-07-26 16:56:59 +02:00
Alexander von Gluck IV
89de782660 test/kits/net: Fix build of cookie_test 2015-07-26 09:55:45 -05:00
Alexander von Gluck IV
eef1c442a3 test/kits/net: Fix build of NetEndpointTest 2015-07-26 09:47:50 -05:00
Jérôme Duval
2a868d7645 glibc: replace extern __inline with __extern_inline.
* this helps to comply with C99. As a reminder, some of these headers
are also used by x86_gcc2 src/libs/stdc++.
2015-07-26 10:09:22 +02:00
Jérôme Duval
189156a069 Boot stdio.h: define a bunch of functions required by c++ headers. 2015-07-26 10:07:21 +02:00
Jérôme Duval
4fb4b32043 Force use of std::isnan() in agg_conv_curve.h.
cmath could be included before inclusion of this header, thus undefining isnan.
2015-07-25 23:42:14 +02:00
Jérôme Duval
9cd62a24e5 Fixed C++11 warnings.
invalid suffix on literal; C++11 requires a space between literal and string macro
[-Werror=literal-suffix]
2015-07-25 23:42:13 +02:00
Jérôme Duval
66fdfe3270 setmime: hash() conflicts with std::hash.
* found with GCC6
2015-07-25 23:42:13 +02:00
Jérôme Duval
d0017f3766 libtracker.so: fixed parenthesis warning on not operator...
* "logical not is only applied to the left hand side of comparison"
* found with GCC6
2015-07-25 23:42:13 +02:00
Jérôme Duval
b2a0b6323e screenshot: fixed parenthesis warning on not operator...
* "logical not is only applied to the left hand side of comparison"
* found with GCC6
2015-07-25 23:42:12 +02:00