Commit Graph

41429 Commits

Author SHA1 Message Date
Michael Lotz
e339322a88 Fix hrev43405 by moving the reference above the autolocker.
The change in hrev43405 wasn't correct, as it put the reference
object definition after the one of the corresponding locker, causing
the reference to be released before the unlock would happen.

Finally fixes #8187. Thanks Ingo for pointing that out.
2011-12-10 21:35:40 +01:00
Michael Lotz
bcc4a523b6 Fix invalid use of iterator after erase and lock corruption.
* The call to _TeamDied() causes the team that the iterator points to
  be removed from the map. Therefore the iterator becomes invalid and
  may not be accessed anymore (including incrementing it). As we've had
  to unlock, anything might have happened to to map, so take the safe
  route and just start over.
* For each dead team that was found the AppManager was unlocked, but
  there were no balancing lock calls, therefore causing the lock count
  to get corrupted.
2011-12-10 21:23:35 +01:00
Michael Lotz
5585262bb1 Revert hrev43455 and instead just align the size.
While this isn't really correct, it works for the use case it is
intended and doesn't open the can of worms we get when trying to do
memalign() across platforms (due to build tools use of KMessage).
2011-12-10 21:03:14 +01:00
Michael Lotz
33f0ed7a03 Revert hrev43457.
This reverts commit 82929f8a76.
2011-12-10 21:03:13 +01:00
Michael Lotz
8eff10a8bf Revert hrev43458.
This reverts commit 80e6a84bf0.
2011-12-10 21:03:13 +01:00
Michael Lotz
a173514ad1 Revert hrev43459.
This reverts commit c8a48d783c.
2011-12-10 21:03:12 +01:00
Siarzhuk Zharski
a188dae8be Fixing Coverity issues. No functional changes
CID 3490
CID 3491
CID 8928
CID 10630
CID 10631
CID 10664
CID 10731
CID 10754
CID 11049
CID 11141
CID 11147
CID 11148
2011-12-10 20:46:40 +01:00
Michael Lotz
c8a48d783c Same as hrev43457 (- the error) but for the bootloader heap. 2011-12-10 19:15:10 +01:00
Michael Lotz
80e6a84bf0 Fix alignment mask, sorry for the noise. 2011-12-10 19:09:30 +01:00
Michael Lotz
82929f8a76 Add a simplistic memalign() to the runtime_loader heap.
As KMessage now makes use of memalign() the simple heap in the
runtime_loader needs to provide that as well. Fixes build.
2011-12-10 19:07:33 +01:00
Michael Lotz
9a87646122 Only free the old buffer if we owned it and set owning flag.
* If we cloned the buffer due to misalignment, only free the old buffer
  if we actually own it (i.e. if it was allocated by us).
* Set the KMESSAGE_OWNS_BUFFER flag after cloning the buffer. Previously
  the buffer was leaked in the clone case.
2011-12-10 18:46:29 +01:00
Michael Lotz
d0aa07489c Ensure proper alignment instead of just checking for it.
* If there is an alignment requirement then better use memalign() to
  make sure that it is met.
* Since the BMessageAdapter possibly sets a buffer directly, make a
  properly aligned copy of the buffer if it happens to be misaligned.
2011-12-10 17:55:47 +01:00
Michael Lotz
268ddbd76f Fix a few function signatures in the guarded heap.
* Not including malloc.h caused the memalign() signature to not be a C
  signature, therefore leading to linking errors. Fix the missing
  include and explicitly add extern "C" as well.
* Some remaining asterisk style cleanup.
2011-12-10 17:24:10 +01:00
Michael Lotz
3de380692a Update the guarded heap areas after fork.
We don't actually use them for anything yet though.
2011-12-10 17:24:09 +01:00
Fredrik Holmqvist
3cb6104e08 libbe_build has references to math functions so on platforms that has them defined in lib m include it. This allows Haiku to be built with gold as host linker. 2011-12-10 17:11:55 +01:00
Fredrik Holmqvist
76375d6811 Point don't use any math functions. 2011-12-10 17:11:55 +01:00
Niels Sascha Reedijk
0d1be1a57a Merge catalogs from Pootle. 2011-12-10 10:21:48 +01:00
Peter Polacik
8f03c411b0 A makefile/Jamfile engines How To added
* This document was written during GCI 2011
  by Peter Poláčik and is explaining how to use
  makefile and Jamfile engines to start and
  setup new development projects for Haiku.

Signed-off-by: Siarzhuk Zharski <zharik@gmx.li>
2011-12-10 08:31:18 +01:00
Alexander von Gluck IV
802ac6355d Style cleanup, space after switch as it is not a function 2011-12-09 21:26:43 -06:00
Alexander von Gluck IV
79ac92f311 Style cleanup of connector detection
* remove xxx_xxx variables
* small bit of code consolidation
* build fix due to missed braces in IGP change
2011-12-09 21:26:42 -06:00
Alexander von Gluck IV
4faf6f2276 Style cleanup. Variable rename, fill out IGP TODO a little better 2011-12-09 21:26:42 -06:00
Alexander von Gluck IV
afdf055d48 Contextual style cleanup
* Remove un-needed line breaks
* Remove un-needed parentheses
2011-12-09 21:26:42 -06:00
Alexander von Gluck IV
0cd5024dbb Pointer style cleanup; Variable consolidation 2011-12-09 21:26:41 -06:00
Alexander von Gluck IV
61cf713381 Include file style cleanup, no functional change 2011-12-09 21:26:41 -06:00
Rene Gollent
9147ed0fd6 Remove obsolete TODO.
At least as far as I can tell, the template parameters are actually exported
as part of the DIESubprogram name itself, and don't need to be separately
retrieved.
2011-12-09 20:22:12 -05:00
Alexander von Gluck IV
654dc4bfab Use bridge encoder flag vs making direct calls to check 2011-12-09 16:47:26 -06:00
Alexander von Gluck IV
7a13bce56d More work towards DP support.
* add DPBridge encoder flag and set during connector detection
* if external bridge found, do external DDC setup
* pass connectorIndex vs displayIndex to encoder_*_setup
* some of the DP AUX channel stuff should go into accelerant
  common code some day like i2c.
2011-12-09 16:39:22 -06:00
Alexander von Gluck IV
60b7d1defb Add i2c DP AUX communication calls
* remove posix return
* pass GPIO hwLine through vs connector index
* variable scope cleanup
* make lowest level dp aux AtomBIOS call static, non-public
  as it is always called by connector code
2011-12-09 15:36:33 -06:00
Rene Gollent
11d60eaa36 Fix handling of modifiers.
When retrieving modifiers, we're actually pulling them off the type
in reverse order. Consequently we need to build the type's modifier string
similarly.

If the first modifier is a const, prepend it to type name instead.
2011-12-09 11:35:33 -05:00
Michael Lotz
b5cc636fa4 Make a copy of the mode list as it might be realloced later.
The fModes array is realloc'ed as needed when adding modes. Therefore
the fModes pointer handed in to AddModes() becomes invalid once
_MakeSpace() returns in that function causing a freed memory block to
be used as input.

To avoid that we make a copy of the base mode list and then use that to
add the modes for each color space.
2011-12-09 16:00:35 +01:00
Michael Lotz
6ba5fa4d64 Ensure 0 termination of the buffer being converted to a string.
The file content isn't normally 0 terminated, so making a string out of
it would usually result in reading beyond the allocated buffer to find
the string length, possibly leading to a crash.
2011-12-09 15:29:10 +01:00
Alexander von Gluck IV
232ba1d6f6 Remove un-needed posix return 2011-12-08 18:00:10 -06:00
Alexander von Gluck IV
247a279283 Add calls to read and write data from AUX connector
* clean up previously changed error returns in 8c01b4. For
  some reason I thought B_ERROR was the only non-positive
  status.
* add VESA DisplayPort defines. Only a subset so it's local
  to radeon_hd for now.
* this completes basic AUX transaction code, still untested
2011-12-08 17:57:22 -06:00
Alexander von Gluck IV
8c01b45a65 Style fix, return B_ERROR instead of hacking together a neg. return code. 2011-12-08 17:11:22 -06:00
Alexander von Gluck IV
36de623307 Speak aux data via AtomBIOS call
* add function to speak DP AUX data via AtomBIOS call
* clean up connector index variable names
2011-12-08 17:03:26 -06:00
Rene Gollent
309993503f Additional sanity checking.
Also ensure that the return parameter isn't touched unless we
definitely succeeded.
2011-12-08 17:10:10 -05:00
Rene Gollent
5f1b3713c0 Add support for parameters when building function names.
When asked for a fully qualified DIE name, we now add the parameters
of functions as well. This allows them to show up in, e.g. the function
list view. Still needs some work but basically functional.
2011-12-08 17:05:15 -05:00
Rene Gollent
6066a80794 Fix handling of variable specifications.
In the case of variables that refer to static members of compound types,
the specification will be a reference to a DIEMember rather than a
DIEVariable in DWARF3. Relax our restrictions accordingly.
2011-12-08 16:31:04 -05:00
Ingo Weinhold
a5c5479710 media addon server: Fix incorrect array offset for safe mode
Missed that when back porting 323b65468e.
2011-12-08 22:17:58 +01:00
Alex Wilson
29ef6eb52d Fix BMenu behaviour/ABI by reinstating BMenu::InvalidateLayout()
It turns out,this is an old method added by Be, and is not really related to BView::InvalidateLayout(bool). In fact BMenu::InvalidateLayout() does something separate, but related to the BView method. I was wrong to delete this method, since it needs to have action taken each time it is called, so moving these actions into LayoutInvalidated() only worked sometimes (when the BView was considered to have a valid layout).

I have added a comment for future hackers so that they don't delete this method.
2011-12-08 14:09:35 -07:00
Alexander von Gluck IV
104c404c7e Move connector code into new connector source file.
* clean up some comments
* most of this movement is prep for AUX display transactions
2011-12-08 14:03:43 -06:00
Alexander von Gluck IV
4540f5e929 Create connector source file, move connector bus calls into it
* this will help break apart some of the sources
* display bus communications really don't belong with GPU operations
* rename functions to better describe their actions
2011-12-08 13:42:47 -06:00
Rene Gollent
be63c91230 Fix incomplete/incorrect type lookup.
- Add accesor to CompoundType to expose the particular compound kind.

- Implement aforementioned accessor in DwarfCompoundType, and ensure
  DwarfTypeFactory populates it appropriately.

- Modify GlobalTypeLookup to make use of the address and compound
  subtype kinds when trying to match a type.

Due to the lack of matching against the subtype, we would previously wind
up matching anonymous compound types against those of their parents, resulting
in the wrong type getting assigned to their value nodes.

Fixes #8190.
2011-12-07 21:54:44 -05:00
czeidler
8cfe0f458c When calculating the min, max and pref size, relax the range of the right and bottom tab. These tabs are set to the layout borders again when solving the layout. 2011-12-08 11:22:09 +13:00
Michael Lotz
c5fd97e486 Remove needless call to String(), there's an operator for that.
The operator const char*() automatically converts to the needed type
so the explicit BString::String() call isn't needed here. Thanks to
Clemens for pointing that out.
2011-12-07 17:09:14 +01:00
Alex Wilson
8f0b7c3fb8 Update doxygen docs for Layout, LayoutItem on invalidation. 2011-12-06 23:39:16 -07:00
Alex Wilson
ea0a06e213 Remove redundant checks for fParent before calling _InvalidateParentLayout(). 2011-12-06 22:35:46 -07:00
Rene Gollent
4cc7fee152 Fix broken debug output. 2011-12-06 21:32:09 -05:00
Rene Gollent
e0031e05f9 Merge branch 'master' of ssh://git.haiku-os.org/haiku 2011-12-06 21:27:45 -05:00
François Revol
8408920712 Fix rect calculation.
Not sure what the intended height is though. 16 or 17?
2011-12-07 03:05:58 +01:00