Commit Graph

36450 Commits

Author SHA1 Message Date
Oliver Tappe
aae7a46913 * fix warnings in mediaplayer
git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@38272 a95241bf-73f2-0310-859d-f6bbb57e9c96
2010-08-19 17:03:06 +00:00
Oliver Tappe
b401b82842 * fix warnings in mail
git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@38271 a95241bf-73f2-0310-859d-f6bbb57e9c96
2010-08-19 16:47:10 +00:00
Oliver Tappe
6ff66b0bc0 * fixed warnings in icon-o-matic (one of which was actually a style issue ;-)
git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@38270 a95241bf-73f2-0310-859d-f6bbb57e9c96
2010-08-19 16:35:07 +00:00
Oliver Tappe
4b920fd031 * fix warnings in diskusage
git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@38269 a95241bf-73f2-0310-859d-f6bbb57e9c96
2010-08-19 16:28:42 +00:00
Oliver Tappe
7f2103fe25 Fix warnings in charactermap
* no need to overload ScrollTo() with a non-related method - renamed local
  ScrollTo() to ScrollToBlock()


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@38268 a95241bf-73f2-0310-859d-f6bbb57e9c96
2010-08-19 15:59:50 +00:00
Oliver Tappe
3605272d0f * turns out src/kits/tracker was low hanging fruit, as it didn't contain any
warnings at all - enabled -Werror for all kits

git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@38267 a95241bf-73f2-0310-859d-f6bbb57e9c96
2010-08-19 15:54:21 +00:00
Oliver Tappe
1662a36480 * fix the single remaining gcc2-warning in media kit and enable -Werror for it
git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@38266 a95241bf-73f2-0310-859d-f6bbb57e9c96
2010-08-19 15:46:54 +00:00
Oliver Tappe
269ebc04b9 Fix #6373, second try
* make BDADDR_* macros refer to value types instead of addresses
* adjust all interfaces using bdaddr_t* to use (mostly const) refs instead,
  which IMHO makes the interface & code clearer
* that got rid of a couple of const incorrectness casts
* some cleanup along the way


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@38265 a95241bf-73f2-0310-859d-f6bbb57e9c96
2010-08-19 15:29:02 +00:00
Adrien Destugues
e2fc6dba84 Remove useless debug output.
git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@38264 a95241bf-73f2-0310-859d-f6bbb57e9c96
2010-08-19 14:56:03 +00:00
Oliver Tappe
32a2294fdc * revert r38213, as it introduces initialization problems
git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@38263 a95241bf-73f2-0310-859d-f6bbb57e9c96
2010-08-19 14:40:17 +00:00
Adrien Destugues
a8e3f94438 Rewrite and simplify argument parsing of terminal. This makes runnning Terminal -f someApp work.
git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@38262 a95241bf-73f2-0310-859d-f6bbb57e9c96
2010-08-19 08:53:19 +00:00
Stefano Ceccherini
49550a2089 Fix Build
git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@38261 a95241bf-73f2-0310-859d-f6bbb57e9c96
2010-08-19 04:12:25 +00:00
Stefano Ceccherini
2aef272550 Change Path() to GetPath(), and made it accept a reference instead of
a pointer. Style changes.


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@38260 a95241bf-73f2-0310-859d-f6bbb57e9c96
2010-08-19 03:57:58 +00:00
Rene Gollent
1e7a45fd7a Fix build.
git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@38259 a95241bf-73f2-0310-859d-f6bbb57e9c96
2010-08-19 01:48:03 +00:00
Andreas Färber
04e09d1be8 shortcut_catcher: Suppress #pragma export
Fix some more #pragma export warnings treated as errors on ppc.


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@38258 a95241bf-73f2-0310-859d-f6bbb57e9c96
2010-08-19 00:24:09 +00:00
Andreas Färber
f7d8abc530 Mail: Always include posix/regex.h
PowerPC was special-cased to not include posix/regex.h but a local copy.
This caused a warning for undefining __STDC__ and a pointer signedness error.


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@38257 a95241bf-73f2-0310-859d-f6bbb57e9c96
2010-08-18 23:58:57 +00:00
Andreas Färber
eb7f7576c9 OpenGL: Fix warnings on ppc
#pragma export on
and
#pragma export off
result in warnings on ppc, which are now treated as errors.


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@38256 a95241bf-73f2-0310-859d-f6bbb57e9c96
2010-08-18 23:42:48 +00:00
Rene Gollent
c36933ad2e Fetch ICU PPC optional package from the default optional packages dir.
git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@38255 a95241bf-73f2-0310-859d-f6bbb57e9c96
2010-08-18 23:22:42 +00:00
Andreas Färber
6f5eadd525 ppc: Add ICU package
As an interim solution for fixing the build,
download an ICU package from Haiku Ports.


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@38254 a95241bf-73f2-0310-859d-f6bbb57e9c96
2010-08-18 23:06:15 +00:00
Rene Gollent
316c84b2b4 Update WebPositive to r544 - fixes compatibility break due to
recent layout kit changes.



git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@38253 a95241bf-73f2-0310-859d-f6bbb57e9c96
2010-08-18 22:59:13 +00:00
Alex Wilson
1eeda2bd42 Fix style violations I've commited in r38207 and r38251, the first pointed out by Ingo <- thanks!
git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@38252 a95241bf-73f2-0310-859d-f6bbb57e9c96
2010-08-18 22:06:15 +00:00
Alex Wilson
a881dd4a37 Fix regression caused by me in r38207, pointed out by diver in #6407, thanks!
git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@38251 a95241bf-73f2-0310-859d-f6bbb57e9c96
2010-08-18 22:01:57 +00:00
Stefano Ceccherini
2d05ca4e7a Actually return B_NO_MEMORY in case of error (was a regression introduced
in r38247.
Small style fixes (more to come)


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@38250 a95241bf-73f2-0310-859d-f6bbb57e9c96
2010-08-18 20:03:07 +00:00
Stefano Ceccherini
d3485a2648 Renamed some members to fit our guidelines
(and to make the code more readable)


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@38249 a95241bf-73f2-0310-859d-f6bbb57e9c96
2010-08-18 19:57:53 +00:00
Oliver Tappe
8f88fe1d98 * fix CID-258: BView::SetViewOverlay() shouldn't crash if given a NULL bitmap.
Coverity was complaining because we did a half-ass check against NULL only to
pass that NULL pointer on to a function that deref'd it.

git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@38248 a95241bf-73f2-0310-859d-f6bbb57e9c96
2010-08-18 19:55:51 +00:00
Stefano Ceccherini
1c9ed76e33 Fix CID 879. We leaked some stuff in case of error. Removed useless check.
git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@38247 a95241bf-73f2-0310-859d-f6bbb57e9c96
2010-08-18 19:53:08 +00:00
Oliver Tappe
65341d518f Someone familiar with BBitmap, please review:
* BBitmap could leak fWindow in operator=()
* two copy constructors didn't initialize the members properly, which
  could cause crashes in _CleanUp()
* minor cleanup
Actually found this while staring at CID 254-257, which were false alarm, though.


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@38246 a95241bf-73f2-0310-859d-f6bbb57e9c96
2010-08-18 19:44:15 +00:00
Axel Dörfler
6ec5758fe7 * Cleanup - this is very ugly code, and the API is also not really good; we
really should get rid of the current mail kit some day.
* Fixed another memory leak I stumpled upon.


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@38245 a95241bf-73f2-0310-859d-f6bbb57e9c96
2010-08-18 18:20:42 +00:00
Axel Dörfler
02b5d2e4e3 * Stefano was right, there was another leak - I've fixed them all now in a
nicer way.


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@38244 a95241bf-73f2-0310-859d-f6bbb57e9c96
2010-08-18 17:55:23 +00:00
Oliver Tappe
e1a6422727 Fix #6458 - crash in BTextView when entering Japanese characters
* when I changed InsertText() to adjust the caret position recently, I
  forgot to drop that adjustment from all callers - _HandleInputMethodChanged()
  was still doing it, leading to out of bounds access

git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@38243 a95241bf-73f2-0310-859d-f6bbb57e9c96
2010-08-18 17:33:48 +00:00
Axel Dörfler
4af303359b * We need to reset the blockNumber, or else we'll discard the wrong blocks
which has rather desastrous consequences - thanks to Stippi for the heads
  up :-)


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@38242 a95241bf-73f2-0310-859d-f6bbb57e9c96
2010-08-18 16:44:51 +00:00
Stefano Ceccherini
64bd6d9651 Fix CID 890. dest was leaked on error. To me it seems that src is leaked too,
and there's even a comment that says we are leaking memory.
Coverity doesn't complain, though, so I wonder if I'm wrong. Please someone
have a second look.


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@38241 a95241bf-73f2-0310-859d-f6bbb57e9c96
2010-08-18 16:25:31 +00:00
Stefano Ceccherini
5026e5cca4 Fix CID 885 by creating the image struct later.
Also small style fixes.
Added a TODO about unloading the addon.


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@38240 a95241bf-73f2-0310-859d-f6bbb57e9c96
2010-08-18 16:11:18 +00:00
Stephan Aßmus
ab45ec86ab More helpful debugger message.
git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@38239 a95241bf-73f2-0310-859d-f6bbb57e9c96
2010-08-18 15:45:24 +00:00
Stephan Aßmus
3c3dac1aa0 Fixed the build.
git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@38238 a95241bf-73f2-0310-859d-f6bbb57e9c96
2010-08-18 15:44:56 +00:00
Axel Dörfler
28de0904dc * Added non-const sockaddr casts.
* Automatic whitespace cleanup.
* This also fixes the build; I wanted to commit this earlier.


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@38237 a95241bf-73f2-0310-859d-f6bbb57e9c96
2010-08-18 15:41:33 +00:00
Stephan Aßmus
3f918dc3fa Fixed a race condition that could corrupt memory: Usually, clients of this
API will call AddDirectory() in whatever random thread, not in the AddOnMonitor
looper thread however. The looper thread will try to process pending node
monitor events every second which may happen concurrently to the thread
adding to the fPendingEntries list for initial processing of new directories.
Could have affected any of the AddOnMonitor clients, like media_server and
input_server.


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@38235 a95241bf-73f2-0310-859d-f6bbb57e9c96
2010-08-18 13:55:36 +00:00
Stephan Aßmus
c6077ae7ec Cleanup: No need to check the BMessenger status twice. No need to
keep the BMessageRunner message around.


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@38234 a95241bf-73f2-0310-859d-f6bbb57e9c96
2010-08-18 13:50:50 +00:00
Axel Dörfler
f072d0a87a * The "route" command now uses BNetworkAddress instead of its home brewn
solution, too.


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@38233 a95241bf-73f2-0310-859d-f6bbb57e9c96
2010-08-18 13:04:50 +00:00
Axel Dörfler
c141a31f83 * Fixed CID 1447 which was an actual bug which completely voided the whole
discard mechanism eventually causing the conflicts between the file cache
  and the block cache it intended to fix.


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@38232 a95241bf-73f2-0310-859d-f6bbb57e9c96
2010-08-18 12:23:38 +00:00
Axel Dörfler
7ac6de66a4 * Removed a few superfluous "else" keywords.
git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@38231 a95241bf-73f2-0310-859d-f6bbb57e9c96
2010-08-18 11:58:27 +00:00
Adrien Destugues
24fcc1eecb Fix parsing of numbers in svg files : the code used obsolete atod instead of strtod and led to numbers in the form 2.5e-4 to make the parsing fail as 'e' was interpreted as the end of the number.
Fixes #5728.


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@38230 a95241bf-73f2-0310-859d-f6bbb57e9c96
2010-08-18 11:50:49 +00:00
Axel Dörfler
3e86abbd71 * Added an extra check as requested by CID 1567, but also added a comment why
this (and other checks) should not be necessary in the first place.


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@38229 a95241bf-73f2-0310-859d-f6bbb57e9c96
2010-08-18 11:39:39 +00:00
Axel Dörfler
d74f5f5bb5 * Cleaned up the code which also closes CID 176 which was not a bug, though.
git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@38228 a95241bf-73f2-0310-859d-f6bbb57e9c96
2010-08-18 11:26:23 +00:00
Axel Dörfler
adc92cdef7 * Fixed CID 1750: the team args could be leaked in exec_team() on error.
* Also fixed a leak of the same object in team_create_thread_start() I spotted
  while looking into it.


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@38227 a95241bf-73f2-0310-859d-f6bbb57e9c96
2010-08-18 11:07:20 +00:00
Stephan Aßmus
132cbf8cf7 Updated indentation and style.
git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@38226 a95241bf-73f2-0310-859d-f6bbb57e9c96
2010-08-18 10:59:56 +00:00
Stephan Aßmus
81db321da2 Updated header indentation, no functional change.
git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@38225 a95241bf-73f2-0310-859d-f6bbb57e9c96
2010-08-18 10:38:30 +00:00
Stephan Aßmus
52ede95cd7 * Removed outdated USE_MULTI_LOCKER build option
* Don't acquire the read-lock in WindowForClientLooperPort,
   since MultiLocker does not support nested read-locks.
   Use an assert instead, however the method does not appear
   to be used anywhere at the moment.


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@38224 a95241bf-73f2-0310-859d-f6bbb57e9c96
2010-08-18 10:10:27 +00:00
Adrien Destugues
e20a602919 * Use Shift instead of Option as modifier to load workspace settings, as it conflicts with option+N used to open a new
terminal
 * Also ensure that the terminal end up on the current workspace if there is a problem with the settings or the key isn't 
pressed.


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@38223 a95241bf-73f2-0310-859d-f6bbb57e9c96
2010-08-18 09:57:17 +00:00
Adrien Destugues
b234b3fc4e The color attributes were lost in scrollback buffer since the 256-color change.
git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@38222 a95241bf-73f2-0310-859d-f6bbb57e9c96
2010-08-18 08:48:45 +00:00