Aren/haiku
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity
41,798 Commits 9 Branches 0 Tags 473 MiB
d452ff664c
Commit Graph

41798 Commits

This Branch
This Branch
All Branches
Author SHA1 Message Date
Philippe Saint-Pierre
dafbb16406 Tracker (FSUtils): negative passed to unsigned parameter 
BVolume::BlockSize() might return a negative value (error code) and it
was passed as parameter of CalcItemsAndSize() as a size_t (unsigned).

Thus the check for an error code failed.

CID 4171.
 2012-01-04 19:31:17 -05:00
Philippe Saint-Pierre
aa11dcae4d Tracker (InfoWindow): small memory leak fix 
In the case of a broken symlink, a Model object was leaked when trying
to get the icon of the target.

CID 5844.
 2012-01-04 19:23:12 -05:00
François Revol
68aea33966 Try another load address for PPC CFE loader. 
This is the address the OpenFirmware is loaded to by CFE on the Amiga X-1000.
Doesn't seem to help much though.
 2012-01-05 01:03:28 +01:00
Philippe Saint-Pierre
c56f0ce1c3 FindPanel: Avoid NULL deference; CID 352. 2012-01-04 18:44:21 -05:00
Michael Lotz
f13be4928b Pad the transfer buffer to prevent out of bounds access. 
The HIDReportItem reads 32 bit chunks from the report buffer. To avoid
having to check the remaining buffer space on each extraction, we pad
the buffer so it is always valid to read 32 bits at a time. Also add
a comment explaining why we do it that way.

Thanks to Johannes Anderwald for pointing out the potential out of
bound access!
 2012-01-04 23:33:07 +01:00
Jérôme Duval
90b92dab5c added memrchr to string.h, guarded by __USE_GNU. Also guards strchrnul. 
Original patch by Dario Casalinuovo.
BUG: Ticket #8265
 2012-01-05 00:17:41 +01:00
Philippe Saint-Pierre
d390c06551 PoseView: Fix assertion in InitDirentIterator 
The dynamic_cast was called twice, and the assert was
done on the first attempt. Now it just cast once, assert on this
and pass it further as before.

CID 3122.
 2012-01-04 18:11:12 -05:00
Philippe Saint-Pierre
fcfd687380 Tracker: memory leak fix 
In MoveRefsToTrash(), the srcList wasn't deleted after usage.

CID 5849.
 2012-01-04 00:01:26 -05:00
Philippe Saint-Pierre
f30530e387 ffmpeg (gif codec): Init len variable 
It was already fixed upstream. CID 9309.
 2012-01-03 23:35:14 -05:00
Philippe Saint-Pierre
1923ea178d ffmpeg: infinite loop (als decoder) 
CID 3176.  Patch proposed upstream.
 2012-01-03 22:49:01 -05:00
Philippe Saint-Pierre
9d991e3c99 Firewire: uninit buffers returned 
Probably a copy-paste error caused the wrong variables being returned
in fw_xfer_alloc_buf() for the received transfers.

CID 10746.
 2012-01-03 20:24:17 -05:00
Philippe Saint-Pierre
f08709bbea No functional change; invert the order of includes. 2012-01-03 18:51:25 -05:00
Philippe Saint-Pierre
82556487af MediaConverter: Move a NULL check 
To avoid a NULL dereference, moving a NULL check earlier.

CID 5955.
 2012-01-02 23:27:59 -05:00
Philippe Saint-Pierre
7cd8f5f9b9 TextView: initialize buttons variable 
CID 10751.
 2012-01-02 22:46:30 -05:00
Philippe Saint-Pierre
f54fc2dcfe Terminal: NULL dereference fix 
An inversion in a condition could lead to a NULL dereference.

CID 11039.
 2012-01-02 22:30:28 -05:00
Philippe Saint-Pierre
4040b622f4 VM: Memory leak fix in case of bad driver settings file 
CID 5891.
 2012-01-02 22:12:09 -05:00
Philippe Saint-Pierre
7d0a351c0a Wonderbrush translator: memory leak fix 
A Buffer in archive_bitmap wasn't free'd upon completion. CID 5751.
 2012-01-02 21:29:02 -05:00
Philippe Saint-Pierre
c5e599ac1a IconUtils: memory leak fix 
The intermediate step BBitmap in scale2x wasn't deleted. CID 10692.
 2012-01-02 21:07:55 -05:00
Philippe Saint-Pierre
0891b95e63 Installer: Resource leak fix (CID 10693). 2012-01-02 20:54:49 -05:00
Philippe Saint-Pierre
fccd8899fc People: memory leak fix. CID 10694. 2012-01-02 19:27:21 -05:00
Philippe Saint-Pierre
be6c4d6a5d mail kit: fix memory leak. 
CID 896.
 2012-01-02 19:13:28 -05:00
Philippe Saint-Pierre
728d429e7d spamdbm: use the std::nothrow variant of new operator. 2012-01-02 18:55:19 -05:00
Philippe Saint-Pierre
d79ded8a44 Mail: various checks of malloc returns + memory leak fix 
CID 891.
 2012-01-02 18:32:38 -05:00
Urias McCullough
de9c457a38 Disabled DEBUG=1 in several of the 3rd party ffmpeg subdirs 
Signed-off-by: Matt Madia <mattmadia@gmail.com>
 2012-01-02 17:15:28 -05:00
Urias McCullough
f1b76720ea Disable DEBUG build of 3rd party libgutenprint 
Signed-off-by: Matt Madia <mattmadia@gmail.com>
 2012-01-02 17:15:27 -05:00
Philippe Saint-Pierre
0106325bc4 Time preference: Fix a memory leak 
Accidentally introduced with an earlier commit.
 2012-01-02 16:52:52 -05:00
Philippe Saint-Pierre
93f68d97bf ProcessController: fix a small resource leak 
fSettingsFile wasn't deleted in the destructor.  CID 1414.
 2012-01-02 14:55:55 -05:00
Philippe Saint-Pierre
9e4224613c SoundFile.cpp: do a NULL check before deferencing. 
CID 296.
 2012-01-02 14:26:07 -05:00
Philippe Saint-Pierre
e9132cc34c Time preferences: use std::nothrow variant of new operator 
Also make sure to avoid an eventual negative array size. CID 10934.
 2012-01-02 13:54:39 -05:00
Philippe Saint-Pierre
9668d19918 echo driver: replace usage of strncpy by strlcpy 
Usage of strncpy in this context could lead to a non null terminated string.
various coding style fix.

CID 2217.
 2012-01-02 13:19:30 -05:00
Matt Madia
d1b515136e Fixed typo in the comment of the default mail charset string. 
Spotted by RQ and mentioned on #8147. Thanks!
 2012-01-02 12:44:29 -05:00
Niels Sascha Reedijk
c9d16a1694 Update the userguide from i18n.haiku-os.org 2012-01-02 08:17:34 +01:00
Niels Sascha Reedijk
646c788ab6 Update documentation from i18n.haiku-os.org 2012-01-02 08:16:11 +01:00
Philippe Saint-Pierre
e480c1b658 echo driver: replace strncpy by strlcpy 
using strncpy could possibly lead to a non null terminated string.
also some coding style fix.

CID 2216.
 2012-01-01 19:42:16 -05:00
Philippe Saint-Pierre
12892428fc cmedia driver: coding style fix 2011-12-31 17:07:30 -05:00
Philippe Saint-Pierre
848762a7d4 firewire: unchecked return of acquire_sem_etc, coding style 2011-12-31 16:41:01 -05:00
Fredrik Holmqvist
9aec8e8424 Remove strlen from PPC glibc as well. 
This should fix the PPC build. Sorry for that, k thx bye.
 2011-12-31 21:32:57 +01:00
Niels Sascha Reedijk
ea32b03e6a Update translations from Pootle. 2011-12-31 10:43:40 +01:00
Humdinger
c89d69fa89 Added Modern Greek catkeys. Thanks translators. 2011-12-31 08:01:15 +01:00
Humdinger
feaa147442 Added GCI student Harsh Vardhan as French translator. 2011-12-31 08:01:14 +01:00
Philippe Saint-Pierre
a527d1d5b8 NFS: various checks added if malloc succeeded. (also coding style fix). 2011-12-31 00:14:47 -05:00
Philippe Saint-Pierre
f8464b965d dp83815 network driver: replace sprintf by snprintf, code style 2011-12-30 21:57:00 -05:00
Philippe Saint-Pierre
a42c52c07e devfs: Fix memory leak 
Following r25662 (where devfs was migrated to the new driver architecture),
the issue noted in CID 872 and already fixed in r25643 was reintroduced.
 2011-12-30 20:50:48 -05:00
Philippe Saint-Pierre
fbbed9473f AC97 driver: replace some usage of strcpy() by strlcpy() 
CID 8921, CID 8920, CID 8919, CID 8922.  Also fixes some coding
style issues.
 2011-12-30 00:08:00 -05:00
Philippe Saint-Pierre
c7199625ef Marvell Wifi driver: NULL check before dereferencing 
CID 5911.
 2011-12-29 23:27:44 -05:00
Philippe Saint-Pierre
258c1019f1 usb_disk: avoid to use variables after having been free'd() 
CID 10543
 2011-12-29 22:58:52 -05:00
Philippe Saint-Pierre
eb94592703 acpi_manager: Uninit var returned in EcRead() 
In case of failure in EcRead(), rather than returning the proper status,
an uninit variable was returned. CID 11145.
 2011-12-29 17:37:58 -05:00
Philippe Saint-Pierre
5e783d6ad7 libgutenprint: channel.c: Defer assigment after NULL check 
To avoid hypothetical NULL dereference. CID 10821, CID 10822

(patch sent upstream)
 2011-12-29 15:51:38 -05:00
Philippe Saint-Pierre
3ad5b0818e ATA bus_manager: return value (signed) put in unsigned variable 
This might have been occulting an eventual error code.

CID 4095.
 2011-12-29 14:54:47 -05:00
Philippe Saint-Pierre
91a7326a04 Fix wrong order of arguments in memset() 
CID 4119.
 2011-12-29 14:29:43 -05:00