Commit Graph

41735 Commits

Author SHA1 Message Date
Philippe Saint-Pierre 7cd8f5f9b9 TextView: initialize buttons variable
CID 10751.
2012-01-02 22:46:30 -05:00
Philippe Saint-Pierre f54fc2dcfe Terminal: NULL dereference fix
An inversion in a condition could lead to a NULL dereference.

CID 11039.
2012-01-02 22:30:28 -05:00
Philippe Saint-Pierre 4040b622f4 VM: Memory leak fix in case of bad driver settings file
CID 5891.
2012-01-02 22:12:09 -05:00
Philippe Saint-Pierre 7d0a351c0a Wonderbrush translator: memory leak fix
A Buffer in archive_bitmap wasn't free'd upon completion. CID 5751.
2012-01-02 21:29:02 -05:00
Philippe Saint-Pierre c5e599ac1a IconUtils: memory leak fix
The intermediate step BBitmap in scale2x wasn't deleted. CID 10692.
2012-01-02 21:07:55 -05:00
Philippe Saint-Pierre 0891b95e63 Installer: Resource leak fix (CID 10693). 2012-01-02 20:54:49 -05:00
Philippe Saint-Pierre fccd8899fc People: memory leak fix. CID 10694. 2012-01-02 19:27:21 -05:00
Philippe Saint-Pierre be6c4d6a5d mail kit: fix memory leak.
CID 896.
2012-01-02 19:13:28 -05:00
Philippe Saint-Pierre 728d429e7d spamdbm: use the std::nothrow variant of new operator. 2012-01-02 18:55:19 -05:00
Philippe Saint-Pierre d79ded8a44 Mail: various checks of malloc returns + memory leak fix
CID 891.
2012-01-02 18:32:38 -05:00
Urias McCullough de9c457a38 Disabled DEBUG=1 in several of the 3rd party ffmpeg subdirs
Signed-off-by: Matt Madia <mattmadia@gmail.com>
2012-01-02 17:15:28 -05:00
Urias McCullough f1b76720ea Disable DEBUG build of 3rd party libgutenprint
Signed-off-by: Matt Madia <mattmadia@gmail.com>
2012-01-02 17:15:27 -05:00
Philippe Saint-Pierre 0106325bc4 Time preference: Fix a memory leak
Accidentally introduced with an earlier commit.
2012-01-02 16:52:52 -05:00
Philippe Saint-Pierre 93f68d97bf ProcessController: fix a small resource leak
fSettingsFile wasn't deleted in the destructor.  CID 1414.
2012-01-02 14:55:55 -05:00
Philippe Saint-Pierre 9e4224613c SoundFile.cpp: do a NULL check before deferencing.
CID 296.
2012-01-02 14:26:07 -05:00
Philippe Saint-Pierre e9132cc34c Time preferences: use std::nothrow variant of new operator
Also make sure to avoid an eventual negative array size. CID 10934.
2012-01-02 13:54:39 -05:00
Philippe Saint-Pierre 9668d19918 echo driver: replace usage of strncpy by strlcpy
Usage of strncpy in this context could lead to a non null terminated string.
various coding style fix.

CID 2217.
2012-01-02 13:19:30 -05:00
Matt Madia d1b515136e Fixed typo in the comment of the default mail charset string.
Spotted by RQ and mentioned on #8147. Thanks!
2012-01-02 12:44:29 -05:00
Niels Sascha Reedijk c9d16a1694 Update the userguide from i18n.haiku-os.org 2012-01-02 08:17:34 +01:00
Niels Sascha Reedijk 646c788ab6 Update documentation from i18n.haiku-os.org 2012-01-02 08:16:11 +01:00
Philippe Saint-Pierre e480c1b658 echo driver: replace strncpy by strlcpy
using strncpy could possibly lead to a non null terminated string.
also some coding style fix.

CID 2216.
2012-01-01 19:42:16 -05:00
Philippe Saint-Pierre 12892428fc cmedia driver: coding style fix 2011-12-31 17:07:30 -05:00
Philippe Saint-Pierre 848762a7d4 firewire: unchecked return of acquire_sem_etc, coding style 2011-12-31 16:41:01 -05:00
Fredrik Holmqvist 9aec8e8424 Remove strlen from PPC glibc as well.
This should fix the PPC build. Sorry for that, k thx bye.
2011-12-31 21:32:57 +01:00
Niels Sascha Reedijk ea32b03e6a Update translations from Pootle. 2011-12-31 10:43:40 +01:00
Humdinger c89d69fa89 Added Modern Greek catkeys. Thanks translators. 2011-12-31 08:01:15 +01:00
Humdinger feaa147442 Added GCI student Harsh Vardhan as French translator. 2011-12-31 08:01:14 +01:00
Philippe Saint-Pierre a527d1d5b8 NFS: various checks added if malloc succeeded. (also coding style fix). 2011-12-31 00:14:47 -05:00
Philippe Saint-Pierre f8464b965d dp83815 network driver: replace sprintf by snprintf, code style 2011-12-30 21:57:00 -05:00
Philippe Saint-Pierre a42c52c07e devfs: Fix memory leak
Following r25662 (where devfs was migrated to the new driver architecture),
the issue noted in CID 872 and already fixed in r25643 was reintroduced.
2011-12-30 20:50:48 -05:00
Philippe Saint-Pierre fbbed9473f AC97 driver: replace some usage of strcpy() by strlcpy()
CID 8921, CID 8920, CID 8919, CID 8922.  Also fixes some coding
style issues.
2011-12-30 00:08:00 -05:00
Philippe Saint-Pierre c7199625ef Marvell Wifi driver: NULL check before dereferencing
CID 5911.
2011-12-29 23:27:44 -05:00
Philippe Saint-Pierre 258c1019f1 usb_disk: avoid to use variables after having been free'd()
CID 10543
2011-12-29 22:58:52 -05:00
Philippe Saint-Pierre eb94592703 acpi_manager: Uninit var returned in EcRead()
In case of failure in EcRead(), rather than returning the proper status,
an uninit variable was returned. CID 11145.
2011-12-29 17:37:58 -05:00
Philippe Saint-Pierre 5e783d6ad7 libgutenprint: channel.c: Defer assigment after NULL check
To avoid hypothetical NULL dereference. CID 10821, CID 10822

(patch sent upstream)
2011-12-29 15:51:38 -05:00
Philippe Saint-Pierre 3ad5b0818e ATA bus_manager: return value (signed) put in unsigned variable
This might have been occulting an eventual error code.

CID 4095.
2011-12-29 14:54:47 -05:00
Philippe Saint-Pierre 91a7326a04 Fix wrong order of arguments in memset()
CID 4119.
2011-12-29 14:29:43 -05:00
Philippe Saint-Pierre d2a423e499 driver_settings: Replace type of bufferSize from size_t to ssize_t
At various locations, checks are made so that bufferSize is >= 0, which never
occurs. CID 4197.
2011-12-29 14:08:15 -05:00
Philippe Saint-Pierre b6e4d1a9dc BufferedDataIO::Flush(), use ssize_t rather than size_t
Write() was returing an ssize_t and Flush() was expecting a ssize_t,
but a size_t was instead used. CID 11052.
2011-12-29 13:43:15 -05:00
Fredrik Holmqvist 79423142ff Stylefixes as pointed out by Axel and some minor changes possible in cpp.
No functional change.
2011-12-29 18:59:00 +01:00
Philippe Saint-Pierre 114ab70975 Change style of boolean expression to enhance readability. 2011-12-29 12:40:32 -05:00
Fredrik Holmqvist 87dfde44f7 Stop using glibc's asm strlen and use our own.
Mostly done because olta want less dependency on glibc.
It should also make porting a tiny bit simpler.

Testresults, mean values on Haiku from libMicro:
 * with glibc: strlen_10: 0.03859S, strlen_1k: 1.67075S.
 * with strlen.cpp: strlen_10: 0.03854S, strlen_1k: 1.66938S.

So at least on my machine it's possible to beat glibc ;)
2011-12-29 17:41:03 +01:00
Fredrik Holmqvist 55cf69968f Rename strlen.c strnlen.c to strlen.cpp strnlen.cpp.
No changes in the files themselves in this commit.
2011-12-29 15:43:23 +01:00
Alex Wilson 981c729bdc Fix potential uninitialized variable bug in BLayout::AllUnarchived().
BMessage::GetInfo() doesn't set the count output var in error cases.
2011-12-28 22:57:20 -07:00
Alex Wilson 9f0292314d Fix typo in BLayout::AllArchived().
BLayout::AllArchived() was forwarding to BArchivable, skipping BLayoutItem.
2011-12-28 22:37:59 -07:00
Alex Wilson f1e81e6172 Fix bug in BLayout::RemoveView().
Fix typo-induced bug causing (in many cases) the wrong item to be removed from the layout!
Also, improve performance from O(n * m) to O(n), although n and m will always be quite small in practice, we might as well.
2011-12-28 22:29:58 -07:00
Alexander von Gluck IV 2cb6157746 Add Juniper LE+XT pci id's 2011-12-28 17:15:45 -06:00
Philippe Saint-Pierre 0fa5c8f528 Constant expression result
Usage of | rather than & to check a binary mask.  CID 11031.
2011-12-27 23:27:20 -05:00
Urias McCullough baadc350b5 Fix ASSERT that wasn't altered back in hrev39770, allows debug build to succeed
Signed-off-by: Matt Madia <mattmadia@gmail.com>
2011-12-27 23:05:56 -05:00
Urias McCullough 2aef344ad2 Fix another mouse preference issue specific to gcc4 debug build
Signed-off-by: Matt Madia <mattmadia@gmail.com>
2011-12-27 22:58:39 -05:00