Commit Graph

49767 Commits

Author SHA1 Message Date
John Scipione
c2db663cdf Add skeleton docs for BPicture and BPictureButton 2014-03-07 13:55:42 -05:00
John Scipione
e3e82c7972 GIFTranslator: Increment settings refcount
So that the settings object won't be destroyed when released on the
the view destructor.

Fixes #10646
2014-03-06 19:19:04 -05:00
John Scipione
b365777b74 Add curly braces, int created 2014-03-06 19:07:58 -05:00
John Scipione
89e849e326 GIFTranslator: Style, alphbetize 2014-03-06 18:40:04 -05:00
John Scipione
138c12e0a4 GIFTranslator: rename msgr to messsenger
put BView::AllAttached() last (does nothing)
2014-03-06 18:39:19 -05:00
John Scipione
7bad8fc1f6 GIFTranslator: accidentially deleted this twice 2014-03-06 18:37:32 -05:00
John Scipione
2433b9e64f Error if Write less than expected 2014-03-06 18:19:21 -05:00
John Scipione
9592cbe5d8 GIFTranslator: Return false if read fails 2014-03-06 17:18:44 -05:00
John Scipione
1fe1074e8d GIFTranslator: Line strings up visually 2014-03-06 17:18:43 -05:00
John Scipione
5d89b2f16a GIFTranslator: Layout GIFView better
http://25.media.tumblr.com/9aa37387e4240aa5828d34b4dc7163af/tumblr_n20583ipj11r0f0hfo1_500.png

Also delete controls in destructor to not leak memory
2014-03-06 17:18:42 -05:00
John Scipione
2d612ef7ae GIFTranslator: Whitespace style fixes
Also remove break in last case.
2014-03-06 16:50:30 -05:00
John Scipione
9d41bc18bb GIFTranslator: Combine nested if statements
...into single conditional
2014-03-06 16:50:29 -05:00
John Scipione
78bfaa98e1 GIFTranslator: try hard to not throw an exception
... by calling new(std::nothrow)

Also try really hard not to leak any memory in the process.

Lots of error checking added to check if reads and writes fail
returning B_IO_ERROR and if initialization fails returning B_NO_MEMORY
2014-03-06 16:48:48 -05:00
John Scipione
33ef87cd9e GIFTranslator: style fixes 2014-03-06 16:38:41 -05:00
John Scipione
ead17dec08 GIFTranslator: Style fix, rename cs to colorSpace 2014-03-06 16:19:50 -05:00
John Scipione
7b46114834 GIFTranslator: call new(std::nothrow) BBitmap again
... to prevent throwing a std::bad_alloc exception if there isn't
enough memory to allocate a new BBitmap.

This effectively reverts 116e78d4d4

Thanks Axel and AnEvilYak and sorry for the noise.
2014-03-06 16:19:48 -05:00
Humdinger
15791c196f Sentence casing "Low latency" and "Power saving". 2014-03-06 17:31:32 +01:00
Adrien Destugues
9f487be84b Add vim 7.4 package. 2014-03-06 11:18:07 +01:00
David Höppner
fe309ca2a3 setarch: list available architectures
Signed-off-by: Oliver Tappe <zooey@hirschkaefer.de>
2014-03-06 09:27:43 +01:00
Adrien Destugues
0009559ca3 Style fixes. 2014-03-06 08:59:04 +01:00
Sean Thames
54e1893c41 Changed enable notification button to a checkb Changed variable names to more appropriate names. Fixed a potential issue with fNotificationBox getting out of sync. Fixed a potential issue of starting the Notification Server more than once.
Signed-off-by: Adrien Destugues <pulkomandy@pulkomandy.tk>
2014-03-06 08:59:03 +01:00
John Scipione
01be25aefe GIFTranslator: Refactor filling out BBitmap
* Remove the NULL check since BBitmaps don't return NULL but check
  that it IsValid() instead.
* Fill out the *out pointer directly instead of creating a temporary
  bitmap pointer.
* Rename err to result.
* Return B_OK unconditionally if we get to the end of the function.

Thanks again Jérôme
2014-03-05 15:36:10 -05:00
John Scipione
c030befbf9 GIFTranslator: Reorder includes
Thanks Jérôme
2014-03-05 15:36:04 -05:00
John Scipione
5adf9d6ee5 Use doxygen style comments as per guidelines
Thanks Axel!
2014-03-05 15:34:53 -05:00
Ingo Weinhold
5b5f099fc0 Fix DebugAnalyzer gcc 4 build 2014-03-05 21:05:15 +01:00
Adrien Destugues
8e0b2cb0f4 Add various useful packages for x86 part of gcc2hybrid.
Some steps towards libpak...
2014-03-05 20:11:35 +01:00
Adrien Destugues
2580b20edd WebPositive: fix cmd+esc handling
* Don't show the menu in MenusBeginning, this is invoked for all
shortcuts, so cmd+C and others would show the menu. Fixes #9186.
* Instead, show the interface specifically for the CMD+ESC case. Also,
send that key event to the default window handler so the menu opens.
Before, this was mistakenly sent to the "stop" button. Fixes #10523.
2014-03-05 17:21:17 +01:00
François Revol
8e8f7748d3 Update the HardwareChecker script
to work post-PM, however nothing makes any use of it yet.
2014-03-05 02:06:55 +01:00
John Scipione
75d4568c15 DebugNow: Shrink the text a bit, fixes #8170 2014-03-04 18:13:29 -05:00
John Scipione
782f6a4fae DebugNow: Internationalize text
Translation instructions are "keep it short and all uppercase,
5 characters or less".

Now non-English languages can join the fun:

DEBUG JETZT
DEBUG AHORA
DEBUG ORA
DEBUG が現在

... this might be a bit of a challenge for some languages.
2014-03-04 18:11:51 -05:00
John Scipione
0f7a8c1da4 DebugNow: Style fixes, export class def to header
Update copyright header, make colors static const, * goes with type
2014-03-04 18:05:21 -05:00
John Scipione
008f676344 Add gif, jpeg, and png mimetype support to WebPositive 2014-03-04 16:31:47 -05:00
John Scipione
6283e77947 BSeparatorItem: horizontal, not vertical line 2014-03-04 14:34:43 -05:00
John Scipione
5d10a74cfb BSeparatorItem: Style fix, rename archive to data
... missed it in a few places, trying to make variables names consistent.

Update hrev in docs
2014-03-04 14:28:20 -05:00
John Scipione
379ede58af Style fixes to BMenuItem::GetContentSize and update docs
Rename width and height to _width and _height matching the header.

Update the documentation for this method as well.
2014-03-04 14:17:46 -05:00
John Scipione
9b39e22db2 Add BSeparatorItem class documentation 2014-03-04 14:15:45 -05:00
John Scipione
4479c8fda7 Style fixes to BSeparatorItem class.
Mostly meant for documentation with a few other style corrections as well.

Update copyright header.
2014-03-04 14:15:20 -05:00
Adrien Destugues
217f090f9e malloc_debug: align allocations
* Align all allocations of more than 8 bytes to 8-byte.
* Avoids hitting ASSERTs in WebKit when built in debug mode (it assumes
at least 8 byte alignment)
2014-03-04 17:29:30 +01:00
John Scipione
81abd9ed03 GIFTranslator: gifSave not gitSave, habit
Also move comment before function. No functional change intended.
2014-03-04 01:47:43 -05:00
John Scipione
f4b507313b GIFTranslator: error if out of bounds
Error out if we're trying to access an out-of-bounds array index
(which should never happen, but let's check just in case.)
2014-03-04 01:22:55 -05:00
John Scipione
2dcb2d8684 GIFTranslator: Increase ENTRY_COUNT to 4354
Fixes #10618

Why 4354?

4354 = 4096 + 256 + 1 + 1
4096 for the image data, 256 for the color codes,
1 for the clear code, 1 for the end code
2014-03-04 01:22:55 -05:00
John Scipione
9504d99506 GIFTranslator: rename cs and size to codeSize 2014-03-04 01:22:54 -05:00
John Scipione
4389d32381 GIFTranslator: Read the left and top image coordinates 2014-03-04 01:22:53 -05:00
John Scipione
5a7193d558 GIFTranslator: Replace magic constants
Introduce GIFPrivate.h to define these magic constants

Also, make sure that we don't go over LZ_MAX_CODE bits
2014-03-04 01:22:53 -05:00
John Scipione
c14b552e41 GIFTranslator: check if NULL before accessing member 2014-03-04 01:22:52 -05:00
John Scipione
4ac43a1be4 GIFTranslator: use ENTRY_COUNT define instead of 4096 2014-03-04 01:22:52 -05:00
John Scipione
5b53a45a94 GIFTranslator: Use array notation instead of pointer 2014-03-04 01:22:51 -05:00
John Scipione
84bff75245 GIFTranslator: Log info messages with LOG_INFO not LOG_ERR 2014-03-04 01:22:50 -05:00
John Scipione
6ff3ca264d GIFTranslator: Style change, uchar => unsigned char 2014-03-04 01:22:50 -05:00
John Scipione
071f3a6ea0 GIFTranslator: don't call an implicit constructor for Memblock 2014-03-04 01:22:49 -05:00