* SharedBitmap can be pointed to a resource (later the icons will
likely be fetched from somewhere else).
* SharedBitmap caches 16, 32, and 64 icons.
* Added icon resources for WonderBrush and Paladin dummy packages.
In the case of a modified type pointing to an unspecified base type,
i.e. const void*, gcc appears to omit the DW_AT_type attribute entirely.
This had the result that such variables wouldn't appear in the var list.
If we encounter such a case, simply assume that the base type is unspecified
rather than failing early.
* For #9894
* No clue how that is going to work, seems mulitple
GPU onboard.. we will likely just use the first
card we see.
* We may need to remove one of these if additional
work is required to switch GPU's.
src/add-ons/translators/wonderbrush/WonderBrushView.cpp: In constructor 'WonderBrushView::WonderBrushView(const BRect&, const char*, uint32, uint32, TranslatorSettings*)':
src/add-ons/translators/wonderbrush/WonderBrushView.cpp:58:8: warning: variable 'xbold' set but not used [-Wunused-but-set-variable]
src/add-ons/translators/wonderbrush/WonderBrushView.cpp:58:15: warning: variable 'ybold' set but not used [-Wunused-but-set-variable]
src/add-ons/translators/wonderbrush/WonderBrushView.cpp:64:8: warning: variable 'yplain' set but not used [-Wunused-but-set-variable]
Unlike the header or field members, the 'what' field is always a 32-bit
integer, rather than being arch-dependent. This would cause us to bail
out early without ever trying to process/resolve children.
ResolvePICFunctionAddress() needs to restore the CPUState object back
to how it was when it was originally passed in. Fixes various issues
that would occur as a result.
- Add Architecture::ResolvePICFunctionAddress() and pull out the
previous code in DwarfImageDebugInfo into the x86-specific
implemementation.
- PIC handling works a bit differently on x86-64 than it does on x86
since x86-64 is likely to use RIP-relative addressing. Implement
ArchitectureX8664::ResolvePICFunctionAddress() accordingly.
Define HAVE_ARPA_INET_H for the wget build. Otherwise, e.g. inet_ntoa
would get an implicit declaration with a return type of int, leading to
the returned character pointer getting truncated on x86-64, and
consequently random crashes.
* Added methods to fill the package list view, creating PackageRows
from PackageInfos, various TODOs.
* Some additions in the info classes, UserRating needs language.
Take into account the operand and offset size as needed, otherwise
we'd potentially use the wrong value for our calculations.
Gets return values somewhat working on x86-64, though in some cases
looking up a PLT slot's destination fails, for as yet undetermined
reasons.
If the subroutine address in question required us to in a different
image, that lookup would overwrite our pointer to the starting image.
If said lookup then also failed, a crash would occur when performing
operations to look up the next return value, since the image pointer
would then be NULL.
DisassemblerX8664::GetNextInstructionInfo() was mistakenly truncating the
instruction address due to a copy-and-paste bug when it was initially
spawned off DisassemblerX86. This would result in the temporary breakpoints
for skipping over function calls never getting set properly, leading to us
stepping into the PLT on a step over.
