Commit Graph

51071 Commits

Author SHA1 Message Date
John Scipione a76808e72e Tracker: Unchecked dynamic_cast in FilePanelPriv.cpp, CID 300327 2014-08-10 15:06:27 -04:00
John Scipione e5355e2814 Tracker: Unchecked return values
Check that find_directory() and path.Append() succeeded.
2014-08-10 15:06:26 -04:00
John Scipione 38f3b29c70 Tracker: Check dynamic_cast 2014-08-10 15:06:26 -04:00
John Scipione f0b515eca1 Tracker: Check dereference NULL pointers
field->Menu() could return NULL, field->Menu()->FindMarked() could return NULL.
2014-08-10 15:06:25 -04:00
John Scipione 8fbb387b1b Tracker: check dynamic_cast 2014-08-10 15:06:25 -04:00
John Scipione fbf61796ca Tracker: Check dynamic_cast
ASSERT that it is not NULL as it shouldn't be.
2014-08-10 15:06:24 -04:00
John Scipione a2400cc5ca Tracker: some style fixes to FindPanel 2014-08-10 15:06:24 -04:00
John Scipione dc28a571c6 Refactor FindPanel::Draw()
Check if pointers are NULL before dereferencing them.
2014-08-10 15:06:23 -04:00
John Scipione dddea1f72f Tracker: Prefer textControl->Text()
over textControl->TextView()->Text(), also SetText()
2014-08-10 15:06:23 -04:00
John Scipione 73de7ce4ec Tracker: check that textControl->TextView() isn't NULL 2014-08-10 15:06:22 -04:00
John Scipione a2b0a3c08a Tracker: refactor FindPanel::SetUpAddRemoveButtons()
Instead of passing the box in we can just use FindView to get it,
that's what other methods do. Also, check if removeButton exists
in AddAttrRow() first instead of doing it in this method.
2014-08-10 15:06:22 -04:00
John Scipione 350af1ce3f Tracker: Unchecked dynamic_cast, CID 1210857 2014-08-10 15:06:21 -04:00
John Scipione e85fa8f787 Tracker: Unchecked dynamic_cast, CID 1210856 2014-08-10 15:06:21 -04:00
John Scipione ce04484e6b Tracker: Dereference NULL pointer, CID 1032279
Also a bit of a refactor of GetDefaultAttrName(), check for NULL explicitly,
rename result to attrName
2014-08-10 15:06:20 -04:00
John Scipione 861d997e49 Tracker: Unchecked dynamic_cast, CID 1032264
Also some minor refactoring, rename string to textEntryString,
check before dereferencing potentially NULL pointers.
2014-08-10 15:06:20 -04:00
John Scipione 08b7ddae76 Tracker: Unchecked dynamic_cast, CID 1032263 2014-08-10 15:06:19 -04:00
John Scipione 1e09ea53e3 Tracker: Check return values, CID 991051 & CID 991052
The CIDs are about mkdir, we want to check that either the command
succeeded or failed because the directory already exists.

However, we also want to check the return value of find_directory()
and Append() to make sure they succeeded as well.
2014-08-10 15:06:19 -04:00
John Scipione 1995f1a63d Tracker: Check for negative size, CID 610924 2014-08-10 15:06:18 -04:00
John Scipione 1371d18c36 Tracker: Unchecked dynamic_cast, CID 603126 2014-08-10 15:06:18 -04:00
John Scipione f0eb64b40d Tracker: Unchecked dynamic_cast, CID 603125 2014-08-10 15:06:17 -04:00
John Scipione 404b6d40d3 Tracker: Unchecked dynamic_cast, CID 603123 2014-08-10 15:06:17 -04:00
John Scipione ee090c5313 Tracker: Unchecked return value, CID 602471 2014-08-10 15:06:16 -04:00
John Scipione 1cdaa16d12 Tracker: Unchecked dynamic_cast, CID 600353
... and possibly others.
2014-08-10 15:06:16 -04:00
John Scipione 6ef1768d76 Tracker: Unchecked dynamic_cast, CID 600349 2014-08-10 15:06:15 -04:00
John Scipione 9fc1e7ffae Tracker: Unchecked dynamic_cast, CID 600348 2014-08-10 15:06:15 -04:00
John Scipione d2af6ff104 Tracker: Unchecked dynamic_cast, CID 600347 2014-08-10 15:06:15 -04:00
John Scipione bee19b9428 Tracker: Unchecked dynamic_cast, CID 600346 2014-08-10 15:06:14 -04:00
John Scipione 35237fd8f3 Tracker: Unchecked dynamic_cast, CID 500345 2014-08-10 15:06:14 -04:00
John Scipione d6e0dbfe30 Tracker: Unchecked dynamic_cast, CID 600343 2014-08-10 15:06:13 -04:00
John Scipione bbd3b2d914 Tracker: Unchecked dynamic_cast, CID 600340 2014-08-10 15:06:13 -04:00
John Scipione cfc444a631 Tracker: Unchecked dynamic_cast, CID 300339 2014-08-10 15:06:12 -04:00
John Scipione 14948881dc Tracker: Style fixes to FindPanel 2014-08-10 15:06:12 -04:00
John Scipione d5881312d3 Tracker: reorder includes in FindPanel.cpp 2014-08-10 15:06:11 -04:00
John Scipione 4f48aeed3e Tracker: Check dynamic_cast, CID 600337 2014-08-10 15:04:53 -04:00
John Scipione 322b28e01b Tracker: init member var, CID 610121 2014-08-10 15:04:53 -04:00
John Scipione 015559bfa8 Tracker: init member vars, CID 610120 2014-08-10 15:04:52 -04:00
John Scipione ec3d0a698d Tracker: check dynamic_cast, CID 600336 2014-08-10 15:04:52 -04:00
John Scipione ec23596a73 Tracker: init member vars, CID 991720 2014-08-10 15:04:51 -04:00
John Scipione a45f995d3c Tracker: init member vars, CID 609834 2014-08-10 15:04:51 -04:00
John Scipione d6c4e7a6be Tracker: init default member values, CID 609845 2014-08-10 15:04:50 -04:00
John Scipione 23d59b8742 Tracker: RegExp, set initial member values
CID 609956
2014-08-10 15:04:50 -04:00
John Scipione 8bc62a0a12 Tracker: RegExp style fixes, pointer style 2014-08-10 15:04:49 -04:00
John Scipione acd00fc5d4 Tracker: init fTime to 0, CID 610125 2014-08-10 15:04:49 -04:00
John Scipione c8c3cf03e7 Tracker: init default member values, CID 609642 2014-08-10 15:04:48 -04:00
John Scipione f68bec60cf Tracker: init times to 0, CID 610124 2014-08-10 15:04:48 -04:00
John Scipione 1bea02aca1 Tracker: init fTime to 0, CID 610125 2014-08-10 15:04:48 -04:00
John Scipione 49d5d59cab Tracker: AttributeStream: implement default constructor
Set members to dummy values

CID 610118
2014-08-10 15:04:47 -04:00
John Scipione d069f646f1 Tracker: AttributeStream style fixes
Rename cloneThis and attr to other
2014-08-10 15:04:47 -04:00
John Scipione 1aa5e7976e Tracker: check return value, CID 610641
... if failure, set to blank BMessage().
2014-08-10 15:04:46 -04:00
John Scipione d5451cc8fc Tracker: fix negative buffer size, CID 610926 2014-08-10 15:04:46 -04:00