Change-Id: I3ccb6be54ba3e42136fa7093f35e16aaecc5a540
Reviewed-on: https://review.haiku-os.org/c/haiku/+/1589
Reviewed-by: Chế Vũ Gia Hy <cvghy116@gmail.com>
Reviewed-by: Adrien Destugues <pulkomandy@gmail.com>
We have quite a few GSoC projects around this, it would make sense to
have some documentation for people attempting them.
Add some generic overview of filesystems and how to test them.
Follow up to #15135, which created a regression, apps would crash if
using the port pool before creating a BMediaRoster instance. Now the
port pool is entirely managed by the MediaRosterUndertaker, which is
less confusing.
Fixes the media_addon_server crash on shutdown for me as well, but I
don't remember why (I had studied the code and came to the conclusion
that this should fix it, but I don't remember the reasoning).
Fixes#15263, and regressions for apps using the port pool before they
instanciate the BMediaRoster.
Change-Id: I887dbc590d8ee9de391b6eae0206944bfe99325f
Reviewed-on: https://review.haiku-os.org/c/haiku/+/1897
Reviewed-by: Axel Dörfler <axeld@pinc-software.de>
Change-Id: I88afad6d071e8b577c23da9c60392c60b3726514
Reviewed-on: https://review.haiku-os.org/c/haiku/+/1895
Reviewed-by: Alex von Gluck IV <kallisti5@unixzen.com>
Reviewed-by: Adrien Destugues <pulkomandy@gmail.com>
* With them Debugger doesn't allow setting breakpoints inside functions.
* Workaround for #15159. Further explanation by anevilyak is also there.
Change-Id: I661b7dcb28a4c02f671b85cb5c26fa0bd5a53078
Reviewed-on: https://review.haiku-os.org/c/haiku/+/1892
Reviewed-by: Rene Gollent <rene@gollent.com>
When unarchiving, we can rely on BView to properly restore the colors,
and we should not alter them. So move the code doing that outside of
_InitObject, and into all non-unarchiving constructors instead.
Change-Id: I98050c69bb3b8edf6e77ad0498e2dade5eaadb1d
Reviewed-on: https://review.haiku-os.org/c/haiku/+/1887
Reviewed-by: waddlesplash <waddlesplash@gmail.com>
If you dropped a square image onto the image well, it was
squashed horizontally.
Change-Id: Ie5637fc242a1c5b7313234a87822bc43556cbe4d
Reviewed-on: https://review.haiku-os.org/c/haiku/+/1886
Reviewed-by: Adrien Destugues <pulkomandy@gmail.com>
A HaikuDepotServer may have previously agreed to
user usage conditions. If this is the case then
they are now able to view those conditions. There
were some problems with date formatting in this
change and so the date formatting logic has moved
into the HaikuDepot source code temporarily until
issues with the BDateTime class can be resolved;
most likely as a separate piece of work.
Relates to 15209
Change-Id: Ic3e5413d9139f410d7f7e8b566d4c56352dd2778
Reviewed-on: https://review.haiku-os.org/c/haiku/+/1870
Reviewed-by: Stephan Aßmus <superstippi@gmx.de>
fQuantumStart and fLastInterruptTime were not set to 0 here, so they
would default to the "malloc-cleared" data and then always overflow
the first time the interrupt time was tracked. I can't find any
reason that was supposed to be the behavior, so just set them to 0.
Also reorder the field initializations to be the same as the class
definition, which should allow some store merging optimizations.
Spotted by KUBSAN.
fType is allocated by strdup() in SetType(), buf freed by delete.
Pointed out by LGTM.
Change-Id: Id9e900863bf6921fd29f2c8abbd21da182f9055c
Reviewed-on: https://review.haiku-os.org/c/haiku/+/1884
Reviewed-by: Axel Dörfler <axeld@pinc-software.de>
sMutexBuf is allocated by new[] in SSL::SSL(), but freed by delete.
Pointed by LGTM.
Change-Id: Ic16501883be4e3b7ca5fe24e1585b6e14ae3ff36
Reviewed-on: https://review.haiku-os.org/c/haiku/+/1883
Reviewed-by: Axel Dörfler <axeld@pinc-software.de>
fAlternateScreen is allocated by malloc() in
BasicTerminalBuffer::_AllocateLines(), but freed by delete.
Pointed out by LGTM.
Change-Id: I526ecd7e570caf7d5ed90c715bbbfaf40e7e4be6
Reviewed-on: https://review.haiku-os.org/c/haiku/+/1882
Reviewed-by: Axel Dörfler <axeld@pinc-software.de>
cpu_menu_items is allocated by new[] in Init(), but freed by delete.
Pointed out by LGTM.
Change-Id: I4cc669c519cc4ea3e170cb9f421d6b4ff77df8a2
Reviewed-on: https://review.haiku-os.org/c/haiku/+/1881
Reviewed-by: Axel Dörfler <axeld@pinc-software.de>
fRenderBuffer is allocated by new[] in MessageReceived(),
buf freed by delete.
Pointed out by LGTM.
Change-Id: I06efc1c8075a421e7f2983e8a0d817a1bf43b026
Reviewed-on: https://review.haiku-os.org/c/haiku/+/1880
Reviewed-by: Axel Dörfler <axeld@pinc-software.de>
fKeypad is allocated by new[] in _ParseCalcDesc(), but freed by delete.
Pointed out by LGTM.
Change-Id: Iac81d3cc6bfcf003ddf9146415a4400c34a1b7f2
Reviewed-on: https://review.haiku-os.org/c/haiku/+/1879
Reviewed-by: Axel Dörfler <axeld@pinc-software.de>
fMixBufferChannelTypes is allocated by new[] in _ApplyOutputFormat(),
but freed by delete.
Pointed out by LGTM.
Change-Id: I07b85801e0103094c5751306ea2c50ca9354ddb9
Reviewed-on: https://review.haiku-os.org/c/haiku/+/1877
Reviewed-by: Axel Dörfler <axeld@pinc-software.de>
fHeadMemblock is allocated by malloc() in MemblockAllocate(),
but freed by delete.
Pointed out by LGTM.
Change-Id: I5019c2c3e4d240051e6f8a1ac70a9738f6f97131
Reviewed-on: https://review.haiku-os.org/c/haiku/+/1878
Reviewed-by: Axel Dörfler <axeld@pinc-software.de>
This class is not implemented in our code. It is not documented in the BeBook.
Change-Id: Id3a48dbd2039005f69998567dcc26548612f3e9f
Reviewed-on: https://review.haiku-os.org/c/haiku/+/1876
Reviewed-by: waddlesplash <waddlesplash@gmail.com>
* We generally use sentence casing, even for alerts and notification
titles
* Using "User usage conditions" uses a bit too many 'users' for my
taste. How about dropping the "User" and distinguish possible future
additions with e.g. "Developer usage conditions"?
Change-Id: Iff2473ec193515b960d3da45bbd590c95413f99f
Reviewed-on: https://review.haiku-os.org/c/haiku/+/1869
Reviewed-by: Andrew Lindesay <apl@lindesay.co.nz>
brjhaiku