fHeadMemblock is allocated by malloc() in MemblockAllocate(),
but freed by delete.
Pointed out by LGTM.
Change-Id: I5019c2c3e4d240051e6f8a1ac70a9738f6f97131
Reviewed-on: https://review.haiku-os.org/c/haiku/+/1878
Reviewed-by: Axel Dörfler <axeld@pinc-software.de>
This class is not implemented in our code. It is not documented in the BeBook.
Change-Id: Id3a48dbd2039005f69998567dcc26548612f3e9f
Reviewed-on: https://review.haiku-os.org/c/haiku/+/1876
Reviewed-by: waddlesplash <waddlesplash@gmail.com>
* We generally use sentence casing, even for alerts and notification
titles
* Using "User usage conditions" uses a bit too many 'users' for my
taste. How about dropping the "User" and distinguish possible future
additions with e.g. "Developer usage conditions"?
Change-Id: Iff2473ec193515b960d3da45bbd590c95413f99f
Reviewed-on: https://review.haiku-os.org/c/haiku/+/1869
Reviewed-by: Andrew Lindesay <apl@lindesay.co.nz>
If at least one image is older than B_HAIKU_VERSION_1_PRE_BETA_2, new areas are
marked as cloneable.
Should fix#15244.
Change-Id: I82d7cad969102679084d0ad73430790278e3d15c
Reviewed-on: https://review.haiku-os.org/c/haiku/+/1849
Reviewed-by: Adrien Destugues <pulkomandy@gmail.com>
1) People normally don't change their email account and Mail settings
often after the initial setup and short tweaking period. Using
keyboard shortcuts on those menu items is wasteful. Let's remove
them.
2) OTOH, I need to in/decrease the quoting level rather often (Mail
could probably be more intelligent here, too...).
Also, the current shortcuts for this ALT+' and ALT+SHIFT+' are awkward
and in some keymaps (German, for example) unreachable.
With the change in 1), ALT +/- becomes available, which is easily
reched with many keymaps AFAIK, and the numpad.
3) Rename the menu items "Quote" and "Remove quote" to
"Increase quote level" and "Decrease quote level", which is much
more correct. Also ties n nicely with the +/- shortcuts.
4) Rename the BMessage constants for consistency.
Change-Id: I2da21ed3aa465c30d09b2520288b64dea70feeec
Reviewed-on: https://review.haiku-os.org/c/haiku/+/1868
Reviewed-by: Adrien Destugues <pulkomandy@gmail.com>
When closing an unread email via "Close | Leave as 'New'", it's
still set to MAIL:status "Read".
IComparing the BString read from the MAIL:status attribute returns
"0" for a match, which the if-statement turns to false...
Change-Id: I4c3846fd39a6056e4bed8388e41dbf4929798799
Reviewed-on: https://review.haiku-os.org/c/haiku/+/1865
Reviewed-by: waddlesplash <waddlesplash@gmail.com>
Since _DispatchViewDrawingMessage sends single B_ERROR replies
in a number of generic cases, doing so here is probably fine;
it's much better than crashing, anyway.
This is the generalized case of PulkoMandy's earlier patch,
which only applied to one drawing operation. This now affects
all AGG calls.
Change-Id: I751439e43cc300b964ac4cf41c48c1df30baf0a3
Reviewed-on: https://review.haiku-os.org/c/haiku/+/1863
Reviewed-by: Stephan Aßmus <superstippi@gmx.de>
The real reason none were found is likely in the syslog.
Even if the last 15 messages do not have the real error, they
may be enough to point towards what the problem is, or at least
uniquely identify the issue.
Fixes#15348.
The iovecs themselves were checked before they were copied,
but the iov_base inside each was not, making it possible
for evil (or just broken) user applications to put kernel
addresses in here.
Part of #14961.
No functional change intended; but if I missed a case,
it will now be caught by the "return false" instead of
the "return true", which is a better default.
Non-KDEBUG kernels and kernel add-ons use atomic operations to acquire
and release the locks inline, so non-KDEBUG kernels/addons are only
compatible with other non-KDEBUG kernels/addons.
Following this change, though, KDEBUG kernels/addons should be able
to run under non-KDEBUG kernels/addons, too, since they always call
into the actual kernel functions and do not inline anything of
consequence.
Call the superclass implementation of MessageReceived() to process messages not
handled by GlutWindow itself.
This restores mouse and keyboard functionality in OpenGL apps, including
Celestia, affected by commit 75e5739772.
Change-Id: Ic3af56ab2f78e8b2b8be576d2edc30bb7357f359
Reviewed-on: https://review.haiku-os.org/c/haiku/+/1862
Reviewed-by: waddlesplash <waddlesplash@gmail.com>
on success, returns B_OK instead of B_ERROR.
Change-Id: I3e415d812ddbc6dbc4d27f346bbe7ea59374b39f
Reviewed-on: https://review.haiku-os.org/c/haiku/+/1861
Reviewed-by: Stephan Aßmus <superstippi@gmx.de>
This adds the firmware for Intel Dual Band Wireless-AC 3168NGW,
which the driver itself supports, making it possible to use this
device on Haiku.
Change-Id: Id8df2f3128cefb23dd1a5c2919c38945dce7cb94
Reviewed-on: https://review.haiku-os.org/c/haiku/+/1844
Reviewed-by: waddlesplash <waddlesplash@gmail.com>
based on a test script from FreeBSD.
this uses fsx and fstorture to exercise the fs, mkfs.ext3 to initialize,
e2fsck to check the integrity. single-threaded test is OK, multi-threaded is not.
the following blocksizes and features are tested: 1K, 2K and 4K; huge_file,
dir_nlink, extent, 64bit, metadata_csum.
Change-Id: I948672194bfae0132341183efa4f4af962e2de02
Reviewed-on: https://review.haiku-os.org/c/haiku/+/1843
Reviewed-by: Rene Gollent <rene@gollent.com>
When the user chooses to create a new user they
are able to view the current usage conditions for
users. They are also required to agree to the
conditions and they are required to confirm that
they meet the minimum age requirement.
Relates to 15209
Change-Id: I83cdaabe1b3da31a4cd21139b72341f4b93cab85
Reviewed-on: https://review.haiku-os.org/c/haiku/+/1842
Reviewed-by: Jérôme Duval <jerome.duval@gmail.com>
As the inline comment notes, just because we could not scan one
partition does not mean we won't be able to scan the following ones.
This fixes scanning for disks on certain systems following axeld's
change in 7c2135591b.
Part of #15330.
Change to match the web user interface behaviour;
the user ratings for all architectures are shown
and the list of user ratings is restricted to the
actual repository in use. This is important
where two repositories have the same package with
different versions. Also the architecture
is displayed with the version in the package info
page.
Change-Id: I8c024d9ddec6b97f52233b7462c47d2a1c83af09
Reviewed-on: https://review.haiku-os.org/c/haiku/+/1817
Reviewed-by: Andrew Lindesay <apl@lindesay.co.nz>
