Also remove the BMessageFilter EscapeFilter and use B_CLOSE_ON_ESCAPE
in the window constructor instead.
I moved fExpressionTextControl->MakeFocus(true); down to when the
window is Lock()ed. Otherwise the text control refuses to be focused...
In the current state, opening a link in a new tab will cause URL input to
become empty. This fixes the issue by changing the way locking works and
implementing a lock timeout. The text passed to SetText() will be instead
stored as previous text, so if the user presses ESC after editing the URL,
URL input will update to the latest sent text (i. e. current URL). Also
fixed two lines the style checker was complaining about.
Fixes#13548.
Signed-off-by: Adrien Destugues <pulkomandy@pulkomandy.tk>
Thus, BeOS compatibility is preserved (and there is no risk of
breaking GCC5<->GCC2 interoperation on hybrid builds.)
This commit only makes the actual change, the build fixes are
in the next commit.
Both the user-mode syscalls.h and the kernel-mode one define it
as an int32, not a time_t, and as it's a timezone offset not
an actual time, there's no reason it needs to be one.
These were added in C99 to avoid interferring with C++, but then C++11
caught up with inttypes/h/stdint.h and removed the need for the macros.
They have disappeared from C11 as a result, and also from current glibc
implementation (https://sourceware.org/bugzilla/show_bug.cgi?id=15366)
So it seems reasonably safe to do the same, and it will save people
having to enable access to these macros explicitly when writing C++.
Cookies with expiration on a sunday would be misformatted, which could
lead to websites not recognizing them.
Signed-off-by: Adrien Destugues <pulkomandy@pulkomandy.tk>
Fixes 13543
The SRT file format unfortunately does not specify a text encoding (in
fact, there isn't even really a specification for it). Just loading the
bytes and assuming UTF-8 does not work so well, so we now try to detect
the encoding from the first line of text found.
Fixes#9668
(sometimes watching a movie is all an adventure!)
ffmpeg decodes some videos in this format: separate planes for G, R and
B values of the pixels. It does not manage to perform the conversion on
its own (we would need to use swscale for that), so provide our own
converter (the code is trivial anyways).
This reverts commit 17286dc70a.
As discussed on the mailing list. As it turns out, this was less
than half of an actual implementation of this macro, and there's
technically no way to implement it without introducing (theoretical)
race conditions, in the current design anyway.
This allows to fit a lot more text in the same horizontal space, so we
can fit the label in various locales, without spreading the checkboxes
further apart.
Fixes#6987
The non-locale aware version is kept in src/build/libshared for use on
the host system and in packagefs (kernel add-on). In both cases, ICU is
not available.
Fixes#8192
- Strength is now set once, instead of at each comparison, to improve
performance and fix potential locking issues
- Add a way to enable "numeric" collation (aka "natural order")
* Enables us to add an optional EFI filesystem
to the anyboot image.
* All existing anyboot behaviour is preserved.
* We still need to figure out how to build bios
and EFI loaders at the same time on x86.
* The tiny "fake ISO" still needs el-torito
alt-boot for the EFI loader to work when burned
to a CD. This makes the EFI loader work when
written to a hard disk / flash drive.
The login process didn't call setuid() or setgid() so all users were
logged in as the super user.
Signed-off-by: Augustin Cavalier <waddlesplash@gmail.com>
Fixes#13533.
Various symbolic links (/bin, for example) in the root directory have
no read, write or execute permissions. This prevents non-privileved users
from logging in.
Signed-off-by: Augustin Cavalier <waddlesplash@gmail.com>
Fixes#13530.
Handle the UDAT_DAY_OF_WEEK_FIELD case and assign the corresponding
BDateElement object i.e B_DATE_ELEMENT_WEEKDAY to the fields array
at the appropriate offset.
Signed-off-by: Adrien Destugues <pulkomandy@pulkomandy.tk>
Fixes#13529
The same wording was used for two unrelated things: using the VESA
driver, and forcing a specific resolution. Relabel the menu items to
make it clear that they are not related.
fixes#8887
Signed-off-by: Adrien Destugues <pulkomandy@pulkomandy.tk>
ParseFcMap had several logic errors.
- fixed variable being initialized in the wrong part of the loops
- fixed problem of ANDing bit with 0x8 instead of 0x1
- changed some variable names; 'foundStartBlock' implies a boolean but
it is a block number, so it is now just 'startBlock'
- added const BITS_PER_BLOCK for magic number 32
- added short-circuit for empty full or partial blocks
- initialized variables to -1 when 0 is a valid value
- added code to handle when the end of a block is reached and a range
was started but never finished.
Signed-off-by: Adrien Destugues <pulkomandy@pulkomandy.tk>
Fixes#13526
ConnectionConfigWindow:
- When notified that settings have been changed by the current config view,
validate them, and if complete, enable the connect button.
- Implement message handler for connect button.
NetworkConnectionConfigView:
- Port input field is now prepopulated with the default remote debug port
number.
- Changes to either field now trigger listener notifications.
NetworkTargetHostInterface:
- Fix missing initializer. This would lead to a crash in the destructor.
NetworkTargetHostInterfaceInfo:
- Implement IsConfigured() to validate passed in settings.
- When adding the TargetHostInterfaceInfos to the roster, Init() was not
called on the individual instances, leading to them potentially being
incomplete.
If you disallow and then re-allow characters, so that the number of disallowed
chars returns to zero, BTextView::Archive will fail with "Invalid Argument".
Fixes#13520.
Signed-off-by: Augustin Cavalier <waddlesplash@gmail.com>
This fixes the bugs pertaining to drawing and erasing the blue border
when a view gains and loses the focus, respectively. It also fixes the
bug that the file list (PoseView) always has a blue border when the
panel window is activated, even if the pose view doesn't have the focus.
Fixes#13496.
Signed-off-by: Augustin Cavalier <waddlesplash@gmail.com>
* Issue: BTimeUnitFormat doesn't incorporate style formatting while
formatting a time unit. Format() does take style as an argument but the
style is not used anywhere. So currently the abbreviated style doesn't
work and by default the time unit is formatted to the full style.
* Fix: Move the style flag from BTimeUnitFormat::Format() to the
BTimeUnitFormat constructors and call the relevant icu::TimeUnitFormat
constructor. Map the Haiku defined style unit to the corresponding ICU
unit. Move the style flag from BDurationFormat::Format() to the
BDurationFormat constructors to map the changes in BTimeUnitFormat.
Signed-off-by: Adrien Destugues <pulkomandy@pulkomandy.tk>
Fixes#13508
