39627 Commits

Author SHA1 Message Date
Pawel Dziepak
631ceff294 nfs4: Fix CID #991493: Release memory when returing an error code 2013-06-13 11:38:44 +02:00
Pawel Dziepak
d94b1808ec nfs4: Use nothrow new when creating LockInfo 2013-06-13 11:37:01 +02:00
Pawel Dziepak
5691cd5607 nfs4: Use nothrow new when creating CallbackRequest 2013-06-13 11:36:05 +02:00
Pawel Dziepak
4f5608efd6 nfs4: Fix CID #1032256: Use 4kB block size if server reports invalid value 2013-06-13 11:31:53 +02:00
Pawel Dziepak
51fb559348 nfs4: Fix CID #1032257: ERR_DENIED is expected only when a cookie is given 2013-06-13 11:28:26 +02:00
Pawel Dziepak
04fa44c37e nfs4: Fix CID #1032280: Prevent integer overflow
* Do not increase delay after tenth attempt
 * Cast 1 to bigtime_t before shifting it left
2013-06-13 11:26:30 +02:00
Pawel Dziepak
69c8011e6e nfs4: Remove unused member variable NFS4Server::fClientIdInit 2013-06-13 02:04:35 +02:00
Pawel Dziepak
1192182c89 nfs4: Fix CID #991617: Set cookie file system at its creation 2013-06-13 02:04:34 +02:00
Pawel Dziepak
b92a3dcc61 nfs4: Clear PeerAddress before attempting to get local address
If PeerAddress is cleared before invoking GetLocalAddress() we make sure
it won't contain any garbage data in a very unlike case when getsockname()
fails.
2013-06-13 02:04:33 +02:00
John Scipione
7a66a8375d Check if disk has compilation artist
... before looking for track specific artist information. Fixes #9813

Signed-off-by: John Scipione <jscipione@gmail.com>
2013-06-12 19:02:00 -04:00
John Scipione
1f0b41ba7f BColorControl: Position text controls better
Position the text control vertically in the middle of the ramp in
the case that the text controls are pushed down so that the red, green,
and blue text controls are next to the red, green, and blue ramps.
2013-06-10 19:15:11 -04:00
John Scipione
d5432ed609 BColorControl: Refactor _LayoutView()
In a few cases we were doing the work of _LayoutView() twice because
we called _LayoutView() and then called ResizeToPreferred() which called
_LayoutView() again.

Now only call ResizeToPreferred() which calls _LayoutView().
2013-06-10 19:15:10 -04:00
John Scipione
da6c116d63 BColorControl: Introduce kRampCount magic constant. 2013-06-10 19:15:09 -04:00
John Scipione
8b3b14fdfa BColorControl: Introduce a _PaletteFrame() method
... eliminating duplicate code.
2013-06-10 19:15:09 -04:00
John Scipione
abbd44acfb BColorControl: Rename bevelRect to just rect
... with an explanatory comment. Correct similar comment.
Tiny style fix.
2013-06-10 19:15:08 -04:00
John Scipione
62fec205dd BColorControl: Size text rect based on font size
* Also change kMinCellSize from a uint32 to a float so that it can be used
  with std::min() and std::max() instead of min_c() and max_c().
* Set the text controls sizes and margins based on the font size. Also rework
  _TextRectOffset() so that it will get the right spacing from by dividing the
  palette frame by 3.
* Replace bare numbers and refactor with calculation or magic constant.
* Create a private method _TextRectOffset() which calculates and
  returns the vertical text rect offset to use based on the font size.
* Replace 2.0 with new kBevelSpacing constant where appropriate.
* fPaletteFrame calculation in _LayoutView() was refactored but should
  not have changed.
2013-06-10 19:15:07 -04:00
John Scipione
1186916f06 BColorControl: Create _SetCellSize() method
...eliminating duplicated code.
2013-06-10 19:15:07 -04:00
John Scipione
0289f92063 BColorControl: Style fixes
* Update copyright in header, add my name, alphabetize.
* Rename _ColorRamp() to _DrawColorRamp().
* Rename update parameter to updateRect
2013-06-10 19:15:06 -04:00
John Scipione
2a95812e46 Mail: Tweak the height of the menu fields
Since hrev45725 we no longer resize fixed sized menu fields to their preferred
height in the constructor so as to be backwards compatible with the behavior on
BeOS R5. As a consequence though, the menu fields in Mail are now a bit too
tall so this commit tweaks the menu fields to be just a bit shorter matching
the height of the text controls.
2013-06-10 18:31:58 -04:00
Rene Gollent
0df5a3b0cb Fix x86-64 build. 2013-06-09 21:24:11 -04:00
Jérôme Duval
8239f0320d scsi: improved code style and use of B_PRI macros 2013-06-09 20:15:12 +02:00
Rene Gollent
7e6a958b0b Fix regression introduced in 6b308faf.
That commit switched to a single string column for representing
breakpoint locations, but neglected to update the case of a breakpoint
in a non-debug function to actually format the address as a string
appropriately, leading to those simply showing no data since then.
2013-06-07 22:32:32 -04:00
Rene Gollent
07842a5be0 Fall back to disassembly in case typecast fails.
Since some time now, we construct minimal dwarf image debug infos
for release images if they contain frame unwind information, in order
to allow using that to unwind the stack in as many cases as possible.
As such, it's  entirely possible that such an image may be asked for
statement information regarding a function that isn't in fact compiled
with debugging. As such, we need to simply fall back to disassembly
rather than failing entirely. Fixes setting breakpoints in such
functions (i.e. anything in a release version of libstdc++).
2013-06-07 22:16:38 -04:00
John Scipione
51e2dbe7f2 Backgrounds: AddGlue() before color control
... so that it is attached to bottom of the box.
2013-06-07 15:53:13 -04:00
John Scipione
d0ddd796b2 Backgrounds: Update spacing around preview.
So that there isn't extra space at the bottom, only between the monitor
and the X and Y text controls, and the insets.
2013-06-07 15:36:57 -04:00
Jérôme Duval
d323ad6708 shortcut_catcher: fixed out of bounds access and a sign warning.
* normal_map is an array with a length of 128
2013-06-07 18:00:15 +02:00
John Scipione
1c95f72222 Don't set MaxContentWidth on the menu bar of a BMenuField
Fixes #9816

It is no longer necessary, or even desirable for us to set the max
content width of the menu bar of a BMenuField now that BMenuItem
truncation and BMenuField sizing are working.

The user may, however, wish to set the max content width of the menu
bar of a BMenuField themselves like so:

menuField->MenuBar()->SetMaxContentWidth(width);

and the Interface Kit will automatically deduct the left and right
margins from the width including the space used by the drop down arrow.
2013-06-07 03:25:36 -04:00
Rene Gollent
37e0f72711 Slight tweak to filtered node expansion logic.
When a filter is active, only expand parent nodes if either a) there is
only one matching parent, or 2) the match actually hit a function
contained in it. This allows the case where the intent of the filter is
to find a particular set of files or subdirectories to be handled more
efficiently.
2013-06-06 18:24:37 -04:00
Rene Gollent
8b98295a68 Redo filtering to use new RegExp classes.
ImageFunctionsView's filtering field now allows shell-style glob matches
rather than just simple direct string matches. Implements remaining
part of #7955.
2013-06-05 22:02:45 -04:00
Rene Gollent
faa0580b62 Optimizations to filter match drawing.
Store the filter match index on the SourcePathComponentNode so we can
retrieve it directly when drawing instead of having to recompute the
position of the match every time.
2013-06-05 22:02:44 -04:00
Rene Gollent
7d4a7ce33e Add ability to specify case insensitive matching. 2013-06-05 22:02:43 -04:00
Rene Gollent
47fedeb598 Import RegExp classes from Ham.
Minor adjustments made by myself to fit into Haiku better.
2013-06-05 22:02:42 -04:00
Rene Gollent
58535f5a9a Initial implementation of #9755.
- ImageFunctionsView now contains a text input allowing one to specify a
filter for its contained functions.
- When in filtered mode, the previous flattened view is used rather than
the hierarchical tree.
- The matching portion of the string is highlighted. However, currently
only simple string matches are supported.
2013-06-05 22:02:42 -04:00
Rene Gollent
cc27aad6b0 BCLV: Force scrollbar fixup if cleared. 2013-06-05 22:02:41 -04:00
Pete Goodeve
528ca6aefa adjust fluidsynth fine tuning range to match standard 2013-06-05 13:14:11 +02:00
Axel Dörfler
3475107981 network stack: added missing put_device_interface().
* Part of #7040, thanks diver!
2013-06-03 21:22:59 +02:00
Alexander von Gluck IV
43f7771e2c NetServer: Disable IPv6 link local address (for now)
* After lots of testing and playing, our v6 stack
  just isn't ready for this level of prime time as
  we lack IPv6 address scope flags.
* Fixes regression in #9594
2013-06-02 21:43:17 -05:00
John Scipione
2fec3040b2 Tracker Settings: Put color control a group and add indents
* Also don't set the initial position since the layout kit takes
  care of that for us now.
* Remove the no longer used spacing constants.
2013-06-02 22:20:47 -04:00
John Scipione
7fd5989d24 Tracker Settings: Style fixes
* Add spaces around {}'s
* Add 2 blank lines between class declarations in header
2013-06-02 22:03:35 -04:00
John Scipione
62bcb75c72 Tracker Settings: Re-factor includes
* Remove includes from header and use bare class definitions instead
* Add the includes from the header to the cpp file
* Remove Alert.h include from cpp file, not used.
* Remove TextControl.h include from header, not used.
* Add Point.h include to cpp file, we do use that.
* Reorder includes according to style guidelines
2013-06-02 22:01:50 -04:00
John Scipione
64c6122863 Tracker Settings: Use BLayoutBuilder template and refactor
... instead of using the less flexable BGroupLayoutBuilder.

* Reduce Group levels used by eliminating the uneeded top
  level group.
* Use font relative spacing units in a few places instead of
  hard coding 20 pixels.
* By using the layout builder template I can use the single
  parameter version of SetInsets().
2013-06-02 21:39:24 -04:00
John Scipione
38a0042248 Backgrounds: Line up BBox top borders refactor
Found an AddStrut() method that eliminates the need for the ugly
CreateVerticalStut() call. This approximately matches what I did
in Screen Preferences to line up the BBox's there.

I've reverted my previous commit and redid the code to make
the history as nice as possible but my main concern is to make the
code as nice as possible.
2013-06-02 17:56:49 -04:00
John Scipione
67a0c8e7ac Revert "Backgrounds: Line up BBox top borders"
This reverts commit 4fe4dcf947abde59b084345697c723fb82053bc1.

Want to do a different way.
2013-06-02 17:33:04 -04:00
John Scipione
4fe4dcf947 Backgrounds: Line up BBox top borders 2013-06-02 17:16:23 -04:00
John Scipione
6aea66ee0d Backgrounds: Refactor view layout code
* Eliminate an uneeded group level, top level is B_VERTICAL
* Remove B_USE_DEFAULT_SPACING calls, use default param instead
2013-06-02 17:12:42 -04:00
John Scipione
c33dfc270f Background: Increase the cell size of the color control
... to 8.0 matching the value used in the Appearance preflet.
This cell sizes makes the ramps fit nicely with the Red Green
and Blue text boxes at the default 12pt font size.
2013-05-31 20:53:29 -04:00
John Scipione
1839b2e699 Backgrounds: Eliminate uneeded view variable 2013-05-31 19:20:28 -04:00
John Scipione
821d2bfcb0 Backgrounds: Don't resize image menu field to preferred 2013-05-31 19:00:03 -04:00
John Scipione
94e6903259 Backgrounds: View layout updates
* Replace the stringViews with CreateLabelLayoutItem()s and menus
   with CreateMenuBarLayoutItem().
* Remove extra group levels
* Use font aware spacing units in layout constructor.
* Align the fIconLabelOutline check box with the menu fields
  instead of the menu field labels.
2013-05-31 18:33:56 -04:00
John Scipione
56cf4a96bc Backgrounds: message fall through 2013-05-31 15:28:56 -04:00