Commit Graph

62838 Commits

Author SHA1 Message Date
Jérôme Duval
d7a4a01f98 usb-header.awk: Fix use of printf
Change-Id: I0f07a321ab5b896c166270b5da6f667cb47ddf26
Reviewed-on: https://review.haiku-os.org/c/haiku/+/4279
Tested-by: Commit checker robot <no-reply+buildbot@haiku-os.org>
Reviewed-by: Jérôme Duval <jerome.duval@gmail.com>
2021-07-30 04:35:08 +00:00
Murai Takashi
2876efaafe screen_savers/nebula: Add more localization
Change-Id: Ic896d058b42440659f83af794f63d9392c4e7a11
Reviewed-on: https://review.haiku-os.org/c/haiku/+/4276
Tested-by: Commit checker robot <no-reply+buildbot@haiku-os.org>
Reviewed-by: Jérôme Duval <jerome.duval@gmail.com>
2021-07-29 12:47:34 +00:00
Coldfirex
64897ae792 FTPD: va_list 'ap' was opened but not closed by va_end()
as pointed out by cppcheck

Notified upstream FreeBSD of issue.  They realized this was dead code and ripped out.  Syncing those specific changes only.

https://github.com/freebsd/freebsd-src/pull/517
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=257317
https://cgit.freebsd.org/src/commit/?id=674400eb20b65369a88b1cb778d729bc297832c9

Change-Id: I4951fa3ce42798895a8222d927067640267d0bbc
Reviewed-on: https://review.haiku-os.org/c/haiku/+/4214
Reviewed-by: Jérôme Duval <jerome.duval@gmail.com>
Tested-by: Commit checker robot <no-reply+buildbot@haiku-os.org>
2021-07-29 12:46:45 +00:00
Murai Takashi
88a19e0e18 charactermap: Add more localization
Change-Id: I94680126e4f9063d283ed4e7a6f1f0087032376b
Reviewed-on: https://review.haiku-os.org/c/haiku/+/4249
Reviewed-by: Adrien Destugues <pulkomandy@gmail.com>
Tested-by: Commit checker robot <no-reply+buildbot@haiku-os.org>
2021-07-29 08:40:21 +00:00
JackBurton79
60ead048b5 MediaPlayer: close() cd/dvd device after eject.
We were not closing cd/dvd device after eject.
Also changed fDevice member to a local variable, since we only use it in one place.

Change-Id: I169da97501f98e30deded1f5ff53d3bc00459eab
Reviewed-on: https://review.haiku-os.org/c/haiku/+/4247
Reviewed-by: Axel Dörfler <axeld@pinc-software.de>
2021-07-27 12:23:25 +00:00
Adrien Destugues
899fdd042a XSI semaphores: Do not insert invalid sem_keys in key map.
Semaphore keys were added to the key map a bit early, before all error
checking had been done. As a result, we could have keys in the map that
would not point to a valid semaphore.

Fixes the root issue in #16741. A previous patch in hrev54878 had
already fixed the panic when trying to access such a key, but it was
still possible to generate one.

Change-Id: I7449e295fdbe2a48b554cbc0508683d042f6ca48
Reviewed-on: https://review.haiku-os.org/c/haiku/+/4240
Tested-by: Commit checker robot <no-reply+buildbot@haiku-os.org>
Reviewed-by: Jérôme Duval <jerome.duval@gmail.com>
2021-07-27 06:22:31 +00:00
Jérôme Duval
518f9c4e68 BCountry: check ICU version for addLikelySubtags
should help arm, riscv builds.

Change-Id: I2d626dfd28c9c4abaac15c010dd41afac410d564
Reviewed-on: https://review.haiku-os.org/c/haiku/+/4246
Reviewed-by: Adrien Destugues <pulkomandy@gmail.com>
2021-07-26 09:30:59 +00:00
Adrien Destugues
71f3ec460f vm: fix off by one errors
Various functions would return an error if trying to use them on the
last page of userspace, as they tested the permissions for the first
byte out of the requested range. Also, the code was duplicated in
several places

- Rename validate_user_range to validate_memory_range. The "user" in the
name was to mean that the range is provided by the user calling the
syscall, but it is a bit confusing, as the function accepts any range
that is either in kernel or in user memory.
- Add a new function validate_user_memory_range that only accepts
userspace memory, and use this one where appropriate.

Change-Id: I135f8d584340f0ba4ae7e4b8cb6f8600fbf3ef2d
Reviewed-on: https://review.haiku-os.org/c/haiku/+/4212
Tested-by: Commit checker robot <no-reply+buildbot@haiku-os.org>
Reviewed-by: Jérôme Duval <jerome.duval@gmail.com>
2021-07-26 06:42:19 +00:00
Adrien Destugues
a94ee3f35a BUrlRequest: fix issues found while documenting
- Remove Pause/Resume functions. They are not possible to implement (the
  server would time out)
- Fix SetContext(NULL) to do the right thing.

Change-Id: I25ba09bb01ea0fe8a85d774611b33be7dc192028
Reviewed-on: https://review.haiku-os.org/c/haiku/+/4245
Tested-by: Commit checker robot <no-reply+buildbot@haiku-os.org>
Reviewed-by: Niels Sascha Reedijk <niels.reedijk@gmail.com>
2021-07-26 06:28:08 +00:00
Adrien Destugues
e9946b675c DeskCalc: fix mixup of key codes and labels
We must keep an untranslated version of the text for use with the
expression parser. Only the key label in the user interface should be
translated.

Fixes #15709.
2021-07-25 18:54:20 +02:00
Adrien Destugues
8df6e5c2a6 BWindow: fix copypasta in ResizeToPreferred
If you had problems with a window picking an incorrect height when using
the layout system, this could very well be why.
2021-07-25 17:47:36 +02:00
Adrien Destugues
b5a859ad62 People: make default size larger
We have increased the number of default attributes, so the initial size
wasn't enough.

On small resolution displays, adjust the size to not end up with part
of the window outside the screen.

Fixes #15371

Change-Id: Ie59cb3a3f6609eff7d933d0bf0e11f66637d6d10
Reviewed-on: https://review.haiku-os.org/c/haiku/+/2222
Reviewed-by: Adrien Destugues <pulkomandy@gmail.com>
Tested-by: Commit checker robot <no-reply+buildbot@haiku-os.org>
2021-07-25 14:40:57 +00:00
Adrien Destugues
40a12ac67e StyledEdit: add menu to underline text
Eases testing of B_UNDERSCORE_FACE

Change-Id: If3e1f247a984b81e9262136ca30139851cfa19a2
Reviewed-on: https://review.haiku-os.org/c/haiku/+/4244
Tested-by: Commit checker robot <no-reply+buildbot@haiku-os.org>
Reviewed-by: Adrien Destugues <pulkomandy@gmail.com>
2021-07-25 14:40:27 +00:00
Adrien Destugues
a43cf8d4a3 LayoutUtils: fix typo
This is in the code to print a text dump of the layout constraints, so
it does not fix any layout problems, but it makes debugging things a bit
easier.
2021-07-25 15:55:46 +02:00
Leorize
42819a8b49 docs/user/net: add BUrlRequest documentation
Change-Id: I88bff3c452ed9e2025c7d258167ced14919c4e9c
Reviewed-on: https://review.haiku-os.org/c/haiku/+/2984
Reviewed-by: Adrien Destugues <pulkomandy@gmail.com>
2021-07-25 11:52:21 +00:00
Leorize
9b692462b3 docs/user/net: add BUrlResult documentation
Change-Id: I94d7c258da60b2fa7add446dfc37aba0a14f6241
Reviewed-on: https://review.haiku-os.org/c/haiku/+/2983
Reviewed-by: Adrien Destugues <pulkomandy@gmail.com>
2021-07-25 11:52:21 +00:00
Leorize
937388cdd8 docs/user/net: add BUrlProtocolDispatchingListener documentation
Change-Id: I8515f6d5feab3399f3b0357b78e7e791cdf6df25
Reviewed-on: https://review.haiku-os.org/c/haiku/+/2982
Reviewed-by: Adrien Destugues <pulkomandy@gmail.com>
2021-07-25 11:52:21 +00:00
Sambuddha Basu
758dae382b AboutSystem: underline links on mouse over
Fixes #8555.

Change-Id: Ib5ba32625062b6b3c180e8082e634fba9e8a70ec
Reviewed-on: https://review.haiku-os.org/c/haiku/+/2364
Reviewed-by: Adrien Destugues <pulkomandy@gmail.com>
Tested-by: Commit checker robot <no-reply+buildbot@haiku-os.org>
2021-07-25 08:40:31 +00:00
Kacper Kasper
ef83008e79 app_server: add B_UNDERSCORE_FACE support
There was some confusion (and a TODO indicating it) in ServerFont.cpp,
because the notion of "font face" from the Be API is partially
implemented using different font manager styles (bold, italic, etc),
and partially by keeping flags in a separate variable for drawing
extra things or modifying the drawing (underscore, strikeout, ...).

The implementation did not actually preserve the extra flags, and so the
underscore face attribute was lost.

Implement the actual underlining of the text in AGGTextRenderer. This
implementation is a naive one so far. In particular there are the
following limitations:
1. Line is drawn over the text - no nice gaps for descents. Ideally, the
   line should not touch the letter descents, and leave some space
   around them. I don't know how to retrieve the contour - it appears to
   me this might require bigger refactoring of this code. I have left in
   my experiments commented out in the code.
2. If the text run ends with whitespace, the whitespace is not underlined
   as it should. In particular if another text run is drawn next to it
   and it's expected that the underline is continuous between the two.

Change-Id: I8d78b8e1eceddff0a7d98e5a49659e7b03fd89a0
Reviewed-on: https://review.haiku-os.org/c/haiku/+/3041
Reviewed-by: Kacper Kasper <kacperkasper@gmail.com>
Reviewed-by: Adrien Destugues <pulkomandy@gmail.com>
Tested-by: Commit checker robot <no-reply+buildbot@haiku-os.org>
2021-07-25 08:39:57 +00:00
François Revol
627fb72d50 app_server: only turn screens on once at start
Previous code from hrev55212 was triggered on every workspaces change.

Fixes #17078.

Change-Id: I13108cddbd57662650e06c05bd43931c12b3dfae
Reviewed-on: https://review.haiku-os.org/c/haiku/+/4208
Tested-by: Commit checker robot <no-reply+buildbot@haiku-os.org>
Reviewed-by: Adrien Destugues <pulkomandy@gmail.com>
2021-07-24 19:35:49 +00:00
Adrien Destugues
893d5930fe ShowImage: fix scrollbar size
Change-Id: I5c50bd9a842ce79d78b6e9c2227dc37e3c52c6e6
Reviewed-on: https://review.haiku-os.org/c/haiku/+/3755
Reviewed-by: Adrien Destugues <pulkomandy@gmail.com>
Reviewed-by: waddlesplash <waddlesplash@gmail.com>
Tested-by: Commit checker robot <no-reply+buildbot@haiku-os.org>
2021-07-24 08:43:46 +00:00
Jessica Hamilton
2c6b14c0b8 Installer: ensure the package administrative path exists
Fixes #16984

Change-Id: Ia662147395130be4498eefbe11f5351533c88ff2
Reviewed-on: https://review.haiku-os.org/c/haiku/+/4242
Reviewed-by: Adrien Destugues <pulkomandy@gmail.com>
Tested-by: Commit checker robot <no-reply+buildbot@haiku-os.org>
2021-07-24 08:42:41 +00:00
Panagiotis Vasilopoulos
bf14c4b44c libcxxrt: Remove unused library and headers
Change-Id: Id5dd5de98cbdbb274a85c6383ad3b4d6ce593ad5
Reviewed-on: https://review.haiku-os.org/c/haiku/+/4241
Tested-by: Commit checker robot <no-reply+buildbot@haiku-os.org>
Reviewed-by: Adrien Destugues <pulkomandy@gmail.com>
2021-07-23 22:02:15 +00:00
Panagiotis Vasilopoulos
ba22ebb344 midi_server: Update copyright notice
This change aims to clean up the code a little. With explicit permission from Matthijs Hollemans.

Change-Id: Idd6c46b8059ec4674653a0d844502b4c76990726
Reviewed-on: https://review.haiku-os.org/c/haiku/+/4146
Reviewed-by: Adrien Destugues <pulkomandy@gmail.com>
2021-07-23 18:36:26 +00:00
Panagiotis Vasilopoulos
5962c36588 midi_server: Add about window
Change-Id: Idea33a8fed164b63195bc75a00910c731841fef7
Reviewed-on: https://review.haiku-os.org/c/haiku/+/4143
Tested-by: Commit checker robot <no-reply+buildbot@haiku-os.org>
Reviewed-by: Adrien Destugues <pulkomandy@gmail.com>
2021-07-23 18:36:26 +00:00
Zotyamester
31acddc00e MediaPlayer: add eject button
Fixes #11492

Change-Id: I06631ddcef354f4cf8a10e8ccbb6eba03c1ca7dd
2021-07-23 17:32:27 +02:00
Panagiotis Vasilopoulos
1aa97652e0 libunwind: Remove unused headers
Follow-up of https://review.haiku-os.org/c/haiku/+/4128

Change-Id: I6b93484ebeef1dd672a88e96dd7cbe93a619fce9
Reviewed-on: https://review.haiku-os.org/c/haiku/+/4239
Tested-by: Commit checker robot <no-reply+buildbot@haiku-os.org>
Reviewed-by: Adrien Destugues <pulkomandy@gmail.com>
2021-07-23 11:26:29 +00:00
Coldfirex
3f596320bf telnetd: va_list 'args' was opened but closed in wrong location
as pointed out via cppcheck. Fix from upstream.

Change-Id: Idfb59ca86bb4ed3767d8327c145ad348cb645e24
Reviewed-on: https://review.haiku-os.org/c/haiku/+/4216
Reviewed-by: Jérôme Duval <jerome.duval@gmail.com>
2021-07-23 04:43:00 +00:00
Alexander von Gluck IV
6b0e805d8c haikuports: Bump haikuwebkit for font fix in images
Change-Id: I4d109045336d5bcdeac90c42d8fd1c4201f20933
Reviewed-on: https://review.haiku-os.org/c/haiku/+/4238
Reviewed-by: Alex von Gluck IV <kallisti5@unixzen.com>
2021-07-22 11:48:09 +00:00
Niels Sascha Reedijk
abba71575e Synchronize translations from the r1beta3 branch
Change-Id: If513fdb4ce3acfdb6f97c7a9bb3de1592b509469
2021-07-21 12:55:45 +01:00
Niels Sascha Reedijk
c18f9eb4ea User documentation: synchronize userguide from the userguide translator
Change-Id: I9b30ae27658a40b85c67a4c30aaea2b4bf9507f9
2021-07-21 12:54:38 +01:00
Niels Sascha Reedijk
510780798f User documentation: synchronize welcome docs from the userguide translator
Change-Id: I2a2b01d87c35f22f688d51740812a28acf51e11d
2021-07-21 12:54:19 +01:00
Niels Sascha Reedijk
d3071b6dd3 Update translator credits for r1beta3
Change-Id: I49e0c1148aa1fb8445888e362e605015dc2efde8
2021-07-21 12:54:09 +01:00
Coldfirex
cf4ce7e38b Debugger: va_list 'args' opened but not closed by va_end()
pointed out by cppcheck

Change-Id: Idf81666674c881ca9e00bf3985ed0dcf928c19d5
Reviewed-on: https://review.haiku-os.org/c/haiku/+/4220
Reviewed-by: Jérôme Duval <jerome.duval@gmail.com>
Tested-by: Commit checker robot <no-reply+buildbot@haiku-os.org>
2021-07-21 08:27:20 +00:00
Andrew Lindesay
21df7324c9 HaikuDepot: Switch to v2 API
This switches to a new API format "v2" being introduced
on HDS.  The version of the application is also bumped
at the same time in order to make a later cut-off point
possible for compatibility.

Change-Id: I577fd143ac9d001171bca7213c82e3280af1c4de
Reviewed-on: https://review.haiku-os.org/c/haiku/+/4217
Tested-by: Commit checker robot <no-reply+buildbot@haiku-os.org>
Reviewed-by: Adrien Destugues <pulkomandy@gmail.com>
2021-07-21 07:52:13 +00:00
Adrien Destugues
e5fb17f0ca BCountry: add a GetPreferredLanguage method.
The APIs for this were introduced in ICU 63, so we'll need an update.
ICU 63 does not build with gcc2, so this method is disabled there.

Change-Id: Iabe49509ed6d4e578560d497d3ca336a97db4625
Reviewed-on: https://review.haiku-os.org/c/haiku/+/1874
Tested-by: Commit checker robot <no-reply+buildbot@haiku-os.org>
Reviewed-by: Jérôme Duval <jerome.duval@gmail.com>
2021-07-21 07:20:39 +00:00
Alexander von Gluck IV
2703c740d8 haikuports: Bump haikuwebkit in image to 1.8.2-1
Change-Id: I5404446ac9e1280300e8252a609d72ec43b297bd
Reviewed-on: https://review.haiku-os.org/c/haiku/+/4213
Reviewed-by: Alex von Gluck IV <kallisti5@unixzen.com>
2021-07-16 20:14:56 +00:00
David Sebek
8b1d35bdbb Improve SCSI and SATA trim support
Fixes:
* scsi: Fix a bug that caused the device capacity to be set
  to an undefined value for some large SCSI devices when
  READ CAPACITY (16) was used
* ahci: Fix VPD page reporting so that it does not return
  undefined values
* ahci: Set the write bit to true when sending a DATA SET
  MANAGEMENT (trim) command to a device. The command would
  otherwise fail and time out on some devices.

Improvements:
* scsi: Extend the READ CAPACITY (16) support to also
  include logical block provisioning information
* scsi: Prefer READ CAPACITY (16) over READ CAPACITY (10)
  on devices that are expected to support this command
* scsi, ahci: Enable trim on SCSI and SATA devices that
  are expected to support trim and which correctly report
  trim support
* ahci: Redo the implementation of the SCSI UNMAP command
* scsi: Redo UNMAP-related code
* scsi: Add support for UNMAP via WRITE SAME (10) and
  WRITE SAME (16) commands
* When copying trim ranges between different data types,
  make sure that the values don't change (detect overflows)
* Report the number of trimmed blocks even if the trim
  operation fails

Change-Id: Ie5fc993bbbc19546b4308138ba10184bf7b9986a
Reviewed-on: https://review.haiku-os.org/c/haiku/+/4157
Tested-by: Commit checker robot <no-reply+buildbot@haiku-os.org>
Reviewed-by: Adrien Destugues <pulkomandy@gmail.com>
2021-07-16 18:35:57 +00:00
David Sebek
bd02d81c24 Fix trim-related issues
Fixes:
* Use uint64 instead of off_t when handling offset and size
  of the trimmed range in the fs_trim_data structure
* BlockAllocator::Trim: Correct the size of a buffer
* ram_disk, mmc: Do not trim past device capacity

Improvements:
* BlockAllocator::Trim: Because the received offset and size
  are ignored by BFS (the functionality is not implemented yet),
  return B_UNSUPPORTED if the range does not cover the whole
  partition
* ram_disk, mmc: More accurate calculation of the number
  of trimmed bytes
* devfs: Add a uint64 version of translate_partition_access()

Change-Id: I24f4c08674f123ad33a5fef6e28996a4ada6ff0d
Reviewed-on: https://review.haiku-os.org/c/haiku/+/4155
Tested-by: Commit checker robot <no-reply+buildbot@haiku-os.org>
Reviewed-by: Adrien Destugues <pulkomandy@gmail.com>
2021-07-16 18:35:34 +00:00
Murai Takashi
354b6bcfbd screen_savers/Nebula: Add localization
Change-Id: I26849df1f506d578793fd0ad49eab1566da295ab
Reviewed-on: https://review.haiku-os.org/c/haiku/+/4197
Reviewed-by: Adrien Destugues <pulkomandy@gmail.com>
Tested-by: Commit checker robot <no-reply+buildbot@haiku-os.org>
2021-07-16 18:34:26 +00:00
Murai Takashi
51dfd07f06 screen_savers/Shelf: Add localization
Change-Id: I166c539285e104ab3d8cc86be0061171fd55413d
Reviewed-on: https://review.haiku-os.org/c/haiku/+/4198
Tested-by: Commit checker robot <no-reply+buildbot@haiku-os.org>
Reviewed-by: Adrien Destugues <pulkomandy@gmail.com>
2021-07-16 18:34:08 +00:00
Adrien Destugues
fa1e07fa7a Package kit: fix error handling in case of HTTP errors
HTTP errors can have some content sent with them (a message to display
to the user, usually). The package kit would not ignore this and append
the content to the end of the downloaded file. This could result in a
file larger than the expected size, and in that case, it would keep
growing infinitely by adding more error messages to it.

Also add some more specific error messages for some HTTP codes, in
particular, "invalid range" which is likely to happen if something goes
wrong with range requests. Now this case will be detected and the
download will stop.

Change-Id: I18927f361235e9f72a5701c1bd7977abda9e21ad
Reviewed-on: https://review.haiku-os.org/c/haiku/+/4210
Tested-by: Commit checker robot <no-reply+buildbot@haiku-os.org>
Reviewed-by: Adrien Destugues <pulkomandy@gmail.com>
2021-07-16 18:33:35 +00:00
X512
2641b03c91 app_server: fix integer overflow in ServerBitmap
Integer overflow caused bitmap buffer creation of wrong size and out of
bounds access when large bitmap was created. Now allocation failure is
reported for large bitmaps.

This prevents app_server from crashing while playing YouTube in WebPositive.

Fixes #16489.

Change-Id: I297aa6e3b79b32a486d297f1239a1fd4397a8a36
Reviewed-on: https://review.haiku-os.org/c/haiku/+/4209
Reviewed-by: Sergei Reznikov <diver@gelios.net>
Reviewed-by: Adrien Destugues <pulkomandy@gmail.com>
Tested-by: Commit checker robot <no-reply+buildbot@haiku-os.org>
2021-07-14 20:25:00 +00:00
Andrew Lindesay
0ebb9177d8 HaikuDepot: reflect package install changes
This update will mean that HaikuDepot is able to detect
install / uninstall actions on packages at the system
level and reflect this in the user interface.

Fixes #15879, #15994 and #15046.
Relates to #11674.

Also cleans up disused code in the WorkStatusView.

Change-Id: Ide2d5d93c2f71915bc7cfe7d3628e5f343e43f35
Reviewed-on: https://review.haiku-os.org/c/haiku/+/4145
Reviewed-by: Adrien Destugues <pulkomandy@gmail.com>
Tested-by: Commit checker robot <no-reply+buildbot@haiku-os.org>
2021-07-14 18:23:10 +00:00
David Sebek
3e19f197fa Extend the functionality of bin/fstrim
Improvements:
* Introduce new command-line parameters for the offset and length
  of the trimmed region
* Introduce a new command-line parameter that must be specified
  in order to trim a block/character device instead of a file system
* By default, warn users that trim can potentially destroy data
* Display the number of bytes trimmed even if the ioctl returns
  an error

Change-Id: I9eec535abe74f7ef09c927292a120016f4156684
Reviewed-on: https://review.haiku-os.org/c/haiku/+/4154
Tested-by: Commit checker robot <no-reply+buildbot@haiku-os.org>
Reviewed-by: Adrien Destugues <pulkomandy@gmail.com>
2021-07-14 10:55:41 +00:00
David Sebek
f04ae5ab1f ahci: Check for NULL in sg_memcpy
Check that the source and destination addresses in sg_memcpy
are not NULL. The absence of this check does not seem to
cause any issues, but I think it is safer to include it.

Change-Id: I2b04f94d5b04735fe9510adfb2400a7598b70bc4
Reviewed-on: https://review.haiku-os.org/c/haiku/+/4152
Reviewed-by: Axel Dörfler <axeld@pinc-software.de>
Reviewed-by: Adrien Destugues <pulkomandy@gmail.com>
Tested-by: Commit checker robot <no-reply+buildbot@haiku-os.org>
2021-07-14 10:45:13 +00:00
Coldfirex
04d50e7581 WebPositive: More comment cleanup, no functional change
Change-Id: I5ca4edc9f38478edb138f5e4b1d8501dc7f8c5eb
Reviewed-on: https://review.haiku-os.org/c/haiku/+/4203
Tested-by: Commit checker robot <no-reply+buildbot@haiku-os.org>
Reviewed-by: Adrien Destugues <pulkomandy@gmail.com>
2021-07-14 10:41:11 +00:00
Máximo Castañeda
ae56997857 BCountry: return country name
ICU's Locale::getDisplayName fills in the locale's name in the form
"language (country, variation)". We are interested in the country here.

Fixes #17081

Change-Id: Icb810dbe2c486d95251d4d06a48dfe3a000fa968
Reviewed-on: https://review.haiku-os.org/c/haiku/+/4206
Reviewed-by: humdinger <humdingerb@gmail.com>
2021-07-13 15:03:47 +00:00
John Scipione
50107f9f2b Tracker: fix last minute mini icon mode bugs
Pose::CalcRect() assumed top is at icon top in mini-icon mode. This
is not true for larger font sizes where the top of the text is above
the top of the icon. Calculate top and bottom based on font and icon
size matching the calculation in TextWidget::CalcRectCommon(). This
fixes a highlight redraw bug in mini icon mode at larger font sizes.

Push Edit name right 2px to match label position (in mini-icon mode.)

Round to integer to help with 1px off bug. Edit name box is still off
by 1px from the label for some font families and sizes.

Change-Id: Ibba897d6f3c7a879631adedada5cd59d2071191a
Reviewed-on: https://review.haiku-os.org/c/haiku/+/4204
Reviewed-by: John Scipione <jscipione@gmail.com>
Reviewed-by: Alex von Gluck IV <kallisti5@unixzen.com>
Tested-by: Commit checker robot <no-reply+buildbot@haiku-os.org>
2021-07-12 00:33:38 +00:00
Coldfirex
4c38e9157f WebPositive: Comment cleanup, no functional change
Change-Id: Ifa65cd271377923ec8c43955d71a6453139b6826
Reviewed-on: https://review.haiku-os.org/c/haiku/+/4202
Tested-by: Commit checker robot <no-reply+buildbot@haiku-os.org>
Reviewed-by: Adrien Destugues <pulkomandy@gmail.com>
2021-07-11 14:25:46 +00:00