ef83008e79
There was some confusion (and a TODO indicating it) in ServerFont.cpp, because the notion of "font face" from the Be API is partially implemented using different font manager styles (bold, italic, etc), and partially by keeping flags in a separate variable for drawing extra things or modifying the drawing (underscore, strikeout, ...). The implementation did not actually preserve the extra flags, and so the underscore face attribute was lost. Implement the actual underlining of the text in AGGTextRenderer. This implementation is a naive one so far. In particular there are the following limitations: 1. Line is drawn over the text - no nice gaps for descents. Ideally, the line should not touch the letter descents, and leave some space around them. I don't know how to retrieve the contour - it appears to me this might require bigger refactoring of this code. I have left in my experiments commented out in the code. 2. If the text run ends with whitespace, the whitespace is not underlined as it should. In particular if another text run is drawn next to it and it's expected that the underline is continuous between the two. Change-Id: I8d78b8e1eceddff0a7d98e5a49659e7b03fd89a0 Reviewed-on: https://review.haiku-os.org/c/haiku/+/3041 Reviewed-by: Kacper Kasper <kacperkasper@gmail.com> Reviewed-by: Adrien Destugues <pulkomandy@gmail.com> Tested-by: Commit checker robot <no-reply+buildbot@haiku-os.org> |
||
|---|---|---|
| 3rdparty | ||
| build | ||
| data | ||
| docs | ||
| headers | ||
| src | ||
| .editorconfig | ||
| .gitignore | ||
| .gitreview | ||
| configure | ||
| Jamfile | ||
| Jamrules | ||
| lgtm.yml | ||
| License.md | ||
| ReadMe.Compiling.md | ||
| ReadMe.md | ||
Haiku
Homepage | Mailing Lists | IRC Channels | Issue Tracker | API docs
Haiku is an open-source operating system that specifically targets personal computing. Inspired by the BeOS, Haiku is fast, simple to use, easy to learn and yet very powerful.
Goals
- Sensible defaults with minimal configuration required.
- Clean, clear, concise code.
- Unified desktop environment.
Trying Haiku
Haiku provides pre-built nightly images and release images. Haiku is compatible with a large variety of hardware, but in case you don't want to "take the plunge" and install Haiku on bare metal, you can install it on a virtual machine (VM) instead. If you've never used a VM before, you can follow one of the "Emulating Haiku" guides.
Compiling Haiku
See ReadMe.Compiling.
Contributing
Haiku is a meritocratic open source project with a large variety of tasks. Even if you can't write code, you can still help! Haiku needs designers, (technical) writers, translators, testers... Get involved and help out!
Contributing code
If you're submitting a patch to us, please make sure you're following the patch submitting guidelines.
If you're having trouble finding something in the source tree, you can use one of our web-based source code browsers:
- https://xref.landonf.org/ (OpenGrok, provided by Landon Fuller)
- https://git.haiku-os.org/ (git, provided by Haiku, Inc.)
Contributing documentation
The main piece of documentation that still needs work are the API docs (found
in the tree at docs/user). Just find an undocumented class, write
documentation for it, and submit a patch.
Contributing translations
See wiki:i18n.
Contributing software ports
See HaikuPorts.
Contributing to our infrastructure
See Infrastructure.