Aren/haiku
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

BRegion: Do not "cheaply convert" to the internal format.

Browse Source 
_ConvertToInternal does the same thing, and should get inlined
under normal circumstances, so just use it.

No functional change (intended).

Change-Id: Ic4fc9daeb33ab33967d795065a077f282e844f6d
Reviewed-on: https://review.haiku-os.org/c/haiku/+/2297
Reviewed-by: Adrien Destugues <pulkomandy@gmail.com>
Reviewed-by: John Scipione <jscipione@gmail.com>
This commit is contained in:
Augustin Cavalier 2020-02-29 21:16:25 -05:00 committed by Adrien Destugues
parent 171057c06a
commit ab319eb798
1 changed files with 2 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
src/kits/interface/Region.cpp
View File

@ -122,10 +122,7 @@ BRegion::Set(clipping_rect clipping)
if (valid_rect(clipping) && fData != NULL) {
fCount = 1;
// cheap convert to internal rect format
clipping.right++;
clipping.bottom++;
fData[0] = fBounds = clipping;
fData[0] = fBounds = _ConvertToInternal(clipping);
} else
MakeEmpty();
}
@ -211,9 +208,7 @@ BRegion::Intersects(BRect rect) const
bool
BRegion::Intersects(clipping_rect clipping) const
{
// cheap convert to internal rect format
clipping.right++;
clipping.bottom++;
clipping = _ConvertToInternal(clipping);
int result = Support::XRectInRegion(this, clipping);