Commit Graph

1088 Commits

Author SHA1 Message Date
kardel e13d171a8e resource leak (fd/mem): fclose() streams on error (Coverity NetBSD scan CID 2055) 2006-03-18 09:26:08 +00:00
kardel 589ea6e802 resource leak (fd/mem): close stream when errors occur (Coverity NetBSD Scan CID 2054) 2006-03-18 08:57:25 +00:00
kardel 862343544d resolve CID 808 for the general case (code didn't trigger it - constant strings were supplied ) 2006-03-18 08:09:03 +00:00
christos f5b7b11e49 Coverity CID 346: Double free. 2006-03-18 04:41:57 +00:00
christos a7e5a4a743 Coverity CID 347: remove dead code. 2006-03-18 04:39:50 +00:00
christos dee21a2f06 Coverity CID 586: Remove dead code. 2006-03-18 04:34:41 +00:00
elad 6dceae8a70 Ditch the ugly hardcoded value and do proper bounds checking.
Addresses CID 1417, found by Coverity.

Hi Darren! is this code maintained?
2006-03-18 04:12:52 +00:00
christos 06b02ffc92 Coverity CID 1284: Handle -1 return from open(2) 2006-03-18 03:49:37 +00:00
christos f5b784887f Coverity CID 1462: Static buffer overrun; off by 2. 2006-03-18 03:45:34 +00:00
christos 16fbed8bd1 Coverity CID 1616: Memory leak. 2006-03-18 03:43:13 +00:00
christos fd8155f293 Coverity CID 1617: Memory leak 2006-03-18 03:39:57 +00:00
christos 67c67fc5bf Coverity CID 2059: Memory leak. 2006-03-18 03:35:41 +00:00
elad 77e1c3c1fc Fix off-by-one, found by Coverity. CID 1466. 2006-03-18 02:35:47 +00:00
elad 3af85b1067 Fix off-by-one found by Coverity, CID 1516. 2006-03-18 02:15:03 +00:00
kardel 9bccbf4462 Coverity fixes:
CID
687	missing block
988	null pointer deref on shutdown (on open failure - introduced by
	change of contract in ntp_refclock.c)
989	null pointer for private data (could not happen - safeguard anyway)
1513	off by one
2410	misplaced null pointer test
2006-03-18 00:30:30 +00:00
peter 11f7fb17d4 Fix file descriptor leaks.
Coverity CID 1681.
2006-03-17 15:50:44 +00:00
chris d79b92051d Only dereference b after it has been NULL checked.
Coverity CID 2398.
2006-03-17 02:52:56 +00:00
agc a4c7ca1aeb Get rid of c99isms in the form of variable number of args to CPP macros.
This should slim down the resulting binaries a fair bit as well.
2006-03-12 18:47:27 +00:00
agc 7acf73bedf Thanks to Thomas for the prod - update usage message to include all
supported options.
2006-03-11 12:09:36 +00:00
wiz fb778aad1c Compact single letter options in SYNOPSIS. Sort option descriptions. 2006-03-11 11:58:53 +00:00
wiz 674cf041a7 Sort options as in man page. 2006-03-11 11:58:22 +00:00
wiz 93ba37c7ea Add -V to SYNOPSIS; serial comma; sort option descriptions. 2006-03-11 09:21:03 +00:00
he 56dbe819ca If compiling for NetBSD/vax, define boolean_t here before including
<sys/file.h> with _KERNEL defined.  Also add a 3-line XXX comment
explaining some of why this is done.
Should fix the build problem documented in PR#32907.
Will be documented in doc/HACKS shortly.
Fix discussed with thorpej.
2006-03-07 18:18:06 +00:00
wiz e2a71c2aab 'advertisment' -> 'advertisement', from leonardo chiquitto filho
via jmc@openbsd.
2006-03-07 18:15:28 +00:00
agc d4397af4d8 One more off the TODO list, although I hadn't realised it was going to be
as painful as it was.

Teach GNU autoconf to recognise socklen_t, and use it in the code.
2006-03-06 20:52:32 +00:00
agc 32306cea7e I have a nasty feeling it's time to sell all my guitars:
Add some very crude hacks which allow the iscsi-target to work with IPv6:

Mar  5 23:43:45 sys3 iscsi-target: > Discovery login from iqn.1994-04.org.NetBSD.iscsi-initiator:agc on 7f00:1::1002:cbc
Mar  5 23:43:45 sys3 iscsi-target: < Discovery logout from iqn.1994-04.org.NetBSD.iscsi-initiator:agc on 7f00:1::1002:cbc
Mar  5 23:43:45 sys3 iscsi-target: > Normal login from iqn.1994-04.org.NetBSD.iscsi-initiator:agc on 7f00:1::1002:cbc
Mar  5 23:43:48 sys3 iscsi-target: < Normal logout from iqn.1994-04.org.NetBSD.iscsi-initiator:agc on 7f00:1::1002:cbc

These have still to be cleaned up, but this will happen over the next
few days.

Update the TODO list to reflect the current state.
2006-03-05 23:50:46 +00:00
agc ff69df84c5 Add IPv6 awareness. 2006-03-04 22:06:26 +00:00
agc 7717b41470 Include version number, passed down from GNU autoconf.
Add a -V argument to iscsi-target (and iscsi-harness), which will print
the utility name, version number, and destination for all bug reports,
and then exit the utility.

Modify the documentation accordingly.

Re-run autoconf and autoheader to pick up the necessary autoconf glue.
2006-03-04 21:56:11 +00:00
agc a70556aee7 Sync example file with reality - this has no effect on NetBSD, since
configuration files are held in src/etc/iscsi, not src/dist/iscsi.
2006-03-04 21:53:16 +00:00
agc 132771c158 Remove a file that's unnecessary. 2006-03-04 21:52:00 +00:00
wiz 64506871c4 Drop trailing whitespace. 2006-03-02 22:23:51 +00:00
christos f696f0c430 Handle slip statistics too. 2006-03-02 17:32:28 +00:00
drochner 8c32a44b4d minor constification, good for WARNS=3 now 2006-02-27 16:00:20 +00:00
drochner ed755469dd NetBSD adaption:
-minor cleanup of installed headers
-const pcap_strerror() for consistency
2006-02-27 15:57:17 +00:00
drochner f5b56adedc minor constification, good for WARNS=3 now 2006-02-27 15:55:30 +00:00
drochner 431104fb34 avoid shadowing globals, for WARNS=2 2006-02-27 15:53:24 +00:00
drochner a7dfc7f00f pull in from NetBSD's libpcap: use cloning bpf device on NetBSD 2006-02-27 15:51:38 +00:00
drochner 6dab7ae580 pull in from NetBSD's libpcap: import header for __NetBSD_Version__ 2006-02-27 15:50:09 +00:00
drochner 3c909ce59d import original libpcap-0.9.4 from tcpdump.org,
with unrelated subdirs omitted
2006-02-27 15:45:37 +00:00
dyoung 0f0c24e0c7 Print the "bad-fcs" radiotap flag. 2006-02-26 03:04:28 +00:00
dyoung 125170229e Reduce diffs between NetBSD's authoritative radiotap header file
and TCPDump's.
2006-02-26 03:04:03 +00:00
wiz b82f53ae21 Fix typo in comment. 2006-02-25 01:58:39 +00:00
wiz 9096fdfaac Remove superfluous comma. 2006-02-24 21:01:19 +00:00
agc b95774e6d4 Implement SCSI commands:
0x1b Load/Unload Sequential
0x4d Log Sense
0x5e (unknown for just now)
0x35 Synchronise cache

as no ops for the present time - reported on current-users by Chavdar
Ivanov as being generated by the Solaris 10 initiator.
2006-02-24 20:47:30 +00:00
he 127058acaa Include <sys/param.h> explicitly relatively early, so that we pick
up the definition of MAX earlier, and avoid a redefinition which
GCC 2 isn't very fond of.  Fixes build problem for vax.
2006-02-22 08:56:46 +00:00
agc 9b7f93748a Add an initial version of the iscsiconfig utility - initially only
discovery functionality is supported.
2006-02-20 09:00:05 +00:00
agc f06c81ed28 Further cleanup.
Add an initiator_discover() function, and start to break up the monolithic
discovery function that's currently used.
2006-02-20 08:59:07 +00:00
agc c9ecbabb62 Clean up, get rid of unused code.
Add my copyright for the extent, device and target conf file parsing and
manipulation code.
2006-02-20 08:57:32 +00:00
agc b8ca8cc0de Clean up a bit - only print the huge stuff if we're debugging. 2006-02-20 08:56:06 +00:00
agc c40774dc2e We don't ever run the tests in the kernel, so get rid of a whole lot of
"#ifdef __KERNEL__"
2006-02-20 08:55:06 +00:00
agc 56abe96063 By popular request, modify the IQN to:
"iqn.1994-04.org.netbsd.iscsi-target"
2006-02-16 23:16:05 +00:00
agc b37fe4757b Update the targets(5) manual page to reflect the new syntax. 2006-02-16 19:29:28 +00:00
agc ec095879d4 Introduce a backwards compatible change to the targets configuration
file.

The new file specifies whether targets should be presented as readonly
or read-write.

If a target is marked as read-only, don't allow any writes to be made
to it.

Also, add syntax recognition of "any" and "all" in the netmask recognition
code.
2006-02-16 19:19:38 +00:00
agc 14ba470694 when looking for the target name supplied by the initiator during full-phase
login, break out of the loop immediately a match is found.

only syslog information if it's available
2006-02-15 10:29:18 +00:00
agc c963d486fc Present multiple targets properly 2006-02-14 20:08:37 +00:00
pooka f8ed783b2b some new signatures provided by Sergey Svishchev in private email 2006-02-13 22:57:55 +00:00
agc e1b73336e6 Discovery masking has been implemented 2006-02-12 15:53:34 +00:00
agc 9a2c5d1a2e Sync the manual page with reality after adding the netmask functionality 2006-02-12 15:48:17 +00:00
agc ba1e98d16d Check that the initiator address is allowed to discover targets.
Log a LOG_INFO error if an initiator attempts to discover targets it
shouldn't be.
2006-02-12 15:36:54 +00:00
agc 890f7ccd9f minor cleanup - no functional change. 2006-02-12 15:35:00 +00:00
agc a31b31cf51 keep a reference to the device target information in the globals structure 2006-02-12 15:34:29 +00:00
agc e48ae9ed1d use a proper prototype for allow_netmask 2006-02-12 15:33:26 +00:00
agc cfc7ed417d Add functionality for matching netmasks with addresses 2006-02-12 14:49:40 +00:00
agc a0d5cb1f08 make this conform to latest sources 2006-02-12 14:48:49 +00:00
agc a63dd2456e we moved the port number back to the command line from the targets file some
time ago, reflect that in the manual page.
2006-02-09 23:36:48 +00:00
agc 0a7d1d9211 Break out the files relating to storage extents, devices and targets into
a separate source file.
2006-02-09 23:08:31 +00:00
agc 3d80f87df2 Add a section explaining about the use of CHAP authentication in the test
harness.
2006-02-09 16:40:49 +00:00
agc f8e2bf3e6d Get rid of parts not needed for the iSCSI target and test harness. 2006-02-09 16:39:56 +00:00
he 0dc5f4be3b Print __uint64_t variables with PRIu64, not with lld.
Fixes build on alpha and probably other LP64 platforms.
2006-02-09 15:11:40 +00:00
agc 9d3ba7cac4 Use the ISCSI_NTOHL macro in place of a straight ntohl(), so that this
can be abstracted away per platform.
2006-02-09 08:55:00 +00:00
mrg 5f90d3d8b1 - use <inttypes.h> and PRIu64 in many places.
- don't try to use the return value of NTOHL().

fixes sparc64 build problems.
2006-02-09 08:46:43 +00:00
agc 6a86b29b9d Fix some wordos in the FAQ. 2006-02-08 21:42:45 +00:00
agc 7cfbac6bcd Remove a file committed in error. 2006-02-08 20:43:13 +00:00
agc 33645f4ad2 Import the distribution files for the iSCSI target, developed from the
original Intel code (BSD-licensed) in othersrc, by myself.

This provides an iSCSI target implementation in userland, as well as a
test harness which also runs in userland.

The iSCSI target has been tested with version 1.06 of the Microsoft
initiator, as well as with its own test harness.
2006-02-08 18:56:14 +00:00
christos a58881f52e resolve conflicts 2006-02-05 16:28:55 +00:00
christos 25010febb3 Import am-utils; changes in ChangeLog.
Summary:
  - bound string operations
  - better detection of filesystem names
  - pawd call now gets the resolved directory in the rpc

All our local changes have been submitted and incorporated.
2006-02-05 16:12:04 +00:00
xtraeme 0511c26dfa openpam_dynamic(): add missing '/' between OPENPAM_MODULES_DIR and
the pam's name module, otherwise it will try to load the module as:

"/usr/lib/security<pam_module>"

Before christos' update we were using PAM_SOPREFIX = "/usr/lib/security/"
with the last '/', now we aren't. So be SAFE and add it to avoid
future problems.
2006-02-05 05:39:49 +00:00
christos aad78462b6 resolve conflicts 2006-02-05 02:37:45 +00:00
christos 70d3347b2d Import figwort: for changes read the HISTORY file. 2006-02-05 02:32:33 +00:00
christos 665ee4ef5d rename debug to pppd_debug 2006-02-02 20:18:44 +00:00
elad 91ce49cce6 xref named.conf(5) after a complaint from tiocsti. okay veego@.
xml docbook change will be fed upstream as requested by hubertf@
and veego@.
2006-01-16 19:20:15 +00:00
elad 69bfdb7c54 fix remote crash; from tiocsti. 2006-01-15 16:12:53 +00:00
christos 6ffa88f118 bring in changes from 2.4.4b1; we will import 2.4.4 once it is released. 2005-12-31 08:58:50 +00:00
martti 10f294ab64 Make the list of files more readable (so it's easier to add and remove files). 2005-12-27 15:23:28 +00:00
martti ac29c41761 Removed ip_rules.c and ip_rules.h 2005-12-27 15:19:38 +00:00
christos deeaa98b3a make this compile when we don't use threads. 2005-12-22 15:14:12 +00:00
christos 719d30b842 resolve conflicts. 2005-12-22 00:26:23 +00:00
christos e471bad6c5 import the real 9.3.2 not 9.2.3. 2005-12-21 23:16:49 +00:00
christos 7ccb4c5f89 import the real 9.3.2 not 9.2.3. 2005-12-21 23:06:48 +00:00
christos 292526bfd4 Resolve conflicts. 2005-12-21 22:34:31 +00:00
christos 348525eba6 from ftp.isc.org 2005-12-21 19:50:15 +00:00
grant 999434556e add magic for rzip archives. 2005-12-07 03:20:45 +00:00
rpaulo dd25e265f4 PR 32241: Igor Sobrado: ipnat(5) FILES section is missing. 2005-12-04 23:37:27 +00:00
christos 5ca310136d deal with const in the new openssl 2005-11-26 01:10:42 +00:00
christos 090e33a95c reverting to the previous version of file 4.16, not 4.15. 2005-10-21 16:01:16 +00:00
christos 19d0f25ed5 PR/31580: Miles Nordin 'ntptime' no longer reports ERROR and UNSYNC when ntpd
isn't synchronized (ntpd bug #506)
2005-10-20 15:41:01 +00:00
christos 5e183c30fc use strlen properly. 2005-10-17 19:07:43 +00:00
christos c3f8b2f036 add more void casts. 2005-10-17 18:51:40 +00:00
christos 6af7fa0a20 revert previous 2005-10-17 18:49:54 +00:00
christos 0180aa059f Fix lint issues. 2005-10-17 18:34:47 +00:00