ce943c094b
Fix previous correctly. The "quiet" variable was not local.
...
Instead, the problem was declarations which followed a non-declaration
statement, which gcc 2.95 doesn't like, so reshuffle the order.
2006-03-25 21:56:29 +00:00
a7819c4f5c
Coverity CID 2783: Fix dereference of a freed pointer.
2006-03-25 16:06:04 +00:00
c43f7d959b
PR 13604: detect and print correct information for 4.4BSD/NetBSD NFS
...
filehandles.
The heuristic may or may not be wrong, but no one replied in the
tcpdump-workers mailing list.
Extraction of the fsid information contributed by Chuck Silvers.
Discussed with Chuck Silvers.
2006-03-25 11:43:53 +00:00
9fb6f0e876
Don't default the type of a local variable. Fixes build for vax.
2006-03-23 19:25:09 +00:00
e1d9f9cea5
First stab at implementing INQUIRY for Vital Product Data, aka Page 83
...
information in the Solaris initiator, with information taken from
SPC3, T10/1416-D Revision 23, from www.t10.org.
This is untested, work-in-progress.
2006-03-23 00:01:48 +00:00
8d95e8aad0
Coverity CID 991: Remove useless test.
2006-03-22 04:34:49 +00:00
af542fc05c
Coverity CID 563: Kill SUNOS3 case; it is dead code.
2006-03-22 04:30:28 +00:00
ded5be2fff
Coverity CID 2746: Remove useless test.
2006-03-22 04:11:15 +00:00
1174f5b4bb
Coverity CID 2060: Fix memory leak.
2006-03-22 02:29:42 +00:00
86caa230d8
Actually do something with the SYNC_CACHE command - use fsync_range(2) if
...
it's available, falling back to fsync(2) if it's not. Add the necessary
glue to the autoconf scripts.
2006-03-21 22:56:55 +00:00
cbf5d4f8f5
Abstract out some common code, and place it in the utilities source.
...
Get rid of some #ifdef __KERNEL__ abstractions - they're not needed.
2006-03-21 21:03:14 +00:00
b2f6added5
Coverity CID 577: remove dead code; minburst can never be 0 at this point.
2006-03-21 20:49:54 +00:00
e46022bb52
Coverity CID 1514: Don't access static array beyond the end of it.
...
In this case PFTM_MAX == 20 and sizeof(pf_timeouts) / sizeof(pf_timeouts[0])
== 21, using a loop with the size of the array and checking for reaching the
end of the loop via j == PFTM_MAX does not work. Change the loop to use
PFTM_MAX as the upper bound and add an assertion in the code to make sure
that pf_timeouts is large enough. Finally remove last NULL element of the
array so that the array has 20 elements again.
2006-03-21 20:47:27 +00:00
1a21d9be9f
Coverity CID 2057: Don't forget to free tcpopts when you are done.
2006-03-21 20:31:56 +00:00
eca1f0e01b
Coverity CID 2491: Fix uninitialized reference.
2006-03-21 20:27:59 +00:00
a674b513c2
Coverity CID 2738: When a symbol with a NULL name is passed, convert it to
...
the empty symbol.
2006-03-21 16:59:09 +00:00
a1cdcab3c8
buffer overrun: backport fix from NTP project (Coverity NetBSD Scan 8: CID 1509)
2006-03-21 11:12:13 +00:00
15dc7197ee
null deref: fix another case of incomplete list handling (Coverity NetBSD Scan 8: CID 986)
2006-03-21 10:28:25 +00:00
a055fd96f7
Incorporate changes from F. Senault, modified by myself to use
...
autoconf glue, to make the NetBSD iSCSI target build and run on
FreeBSD.
2006-03-20 20:45:07 +00:00
2010c5954a
Clean up, mostly to autoconf glue, to check whether syslog(3) exists or not.
2006-03-20 20:25:42 +00:00
6dccf87632
Avoid overflowing static array which c == HAT.
2006-03-19 17:41:55 +00:00
dbefff2ee4
error handling: check success of open(2) - bail out early (Coverity CID 1282 NetBSD Scan 5)
2006-03-19 07:20:30 +00:00
24781071d1
null deref: complete linked list handling beginng condition (Coverity CID 986)
2006-03-19 07:02:47 +00:00
57e31ffb5c
Coverity CID 1867: Fix memory leak.
2006-03-18 22:39:40 +00:00
a1f97364cb
Coverity CID 862: Avoid NULL deref.
2006-03-18 22:37:16 +00:00
73a77c6016
Coverity CID 1476: Add assertion before index operation.
2006-03-18 22:35:42 +00:00
7f112146cb
Coverity CID 866: Fix possible NULL deref.
2006-03-18 21:15:50 +00:00
58deb05d13
Coverity CID 865: Fix possible NULL deref
2006-03-18 21:14:09 +00:00
760ba920f3
Coverity CID 867: Fix possible NULL deref.
2006-03-18 21:11:43 +00:00
b2229dcdbc
Coverity CID 955: Fix possible NULL deref.
2006-03-18 21:10:12 +00:00
33c12e6be9
Coverity CID 956: Possible NULL pointer deref.
2006-03-18 21:07:47 +00:00
0a7d87f083
Coverity CID 957: Prevent NULL pointer deref.
2006-03-18 21:05:10 +00:00
d9e5b13b10
Coverity CID 2033: Fix memory leak.
2006-03-18 20:48:42 +00:00
6b81e42601
Coverity CID 2358: Although mp2 cannot be NULL here, checking it below for
...
NULL is confusing. Check in both places.
2006-03-18 20:46:23 +00:00
973debfe6f
Coverity CID 2359: Possible NULL deref.
2006-03-18 20:43:48 +00:00
f3d47984b8
Coverity CID 2389: Remove extraneous check
2006-03-18 20:40:53 +00:00
7908a85339
Coverity CID 2390: Wrong test; p cannot be NULL.
2006-03-18 20:38:01 +00:00
06bdf1a1e0
Coverity CID 2485: Possible uninitialized variable use.
2006-03-18 20:33:34 +00:00
55d48ecf23
Remove the unnecessary 'if (found)' to stop Coverty bleating (CID 864)..
2006-03-18 18:05:13 +00:00
063cb750db
mem leak: unreachable code prevented freeing of allocated memory
...
(Coverity CID 612 NetBSD Scan 5)
2006-03-18 15:22:34 +00:00
012eaf5162
null deref: avoid 0 deref (Coverity CID 987 NetBSD Scan 5)
2006-03-18 14:33:20 +00:00
36ab9cfe6b
buffer bounds: one beyond buffer (Coverity CID 1490 NetBSD Scan 5)
2006-03-18 14:25:17 +00:00
a07906a5a8
buffer bounds: buffer full condition wrong for bounds check (Coverity CID 1508 NetBSD Scan 5)
2006-03-18 14:18:59 +00:00
630d3f115c
buffer bounds: correct > - >= error for bounds check (Coverity CID 1511 NetBSD Scan 5)
2006-03-18 14:08:29 +00:00
99c0e2540c
buffer bounds: clamp index for epobuf to buffer bounds (Coverity CID 1512 NetBSD Scan 5)
2006-03-18 14:02:13 +00:00
80b13f6f4e
mem leakage: free old malloced buffer on errors (Coverity CID 2056 NetBSD Scan 5)
2006-03-18 13:44:15 +00:00
ee0722e2b9
avoid close(-1): don't attempt to cleanup INVALID_SOCKET ( ==-1 ) fd's - would lead to close(-1) and FD_CLR((u_int)-1(!), ...) (Coverity CID 1281 NetBSD Scan 5)
2006-03-18 13:13:25 +00:00
9429ea9653
null deref: backport current ntp code to fix (Coverity CID 759)
2006-03-18 12:40:48 +00:00
dbd04f2b27
free buf in error path; CID 2061
2006-03-18 12:15:05 +00:00
58ad32062f
Coverity NetBSD scan CID 2055: fallout fix return/fclose -> fclose/return
2006-03-18 09:28:50 +00:00
he