Commit Graph

98 Commits

Author SHA1 Message Date
lukem fbafdc25f8 use memcmp/memset/memmove instead of bcmp/bzero/bcopy 1997-10-18 08:52:17 +00:00
lukem f5bf267d90 enable WARNS=1 by default, but disable in unclean 3rd party code 1997-10-18 06:42:25 +00:00
lukem 4d10189f4c fix race condition when building libcommon with make -j 1997-10-16 05:10:14 +00:00
mycroft 3ec2ebdb68 GC some garbage variables. 1997-10-11 20:25:53 +00:00
veego e288b27b29 Don't install this libraries, we only this during the build. 1997-10-11 19:42:34 +00:00
lukem 0acf0ef008 only compile common_source/* once (25% faster), remove unused printcap.c 1997-10-10 09:26:35 +00:00
mrg 38811f7fea document -d, -s. remove bogus #port. fix getopt(). 1997-10-09 07:58:39 +00:00
mrg 1bb06f8aab fix alpha compile warnings. 1997-10-05 16:45:43 +00:00
mrg d66fe73851 in rcleanup() don't unlink() the dfname if it contains a /. noted
by matt power <mhpower@mit.edu>.
1997-10-05 15:21:46 +00:00
mrg fe7ed7ce37 - WARNS?=1
- be safe with unlinking files (from freebsd)
- remove register
- clean up $NetBSD$'s.
- use inet_ntoa() in one place (from openbsd)
- nul terminate after a bunch of strncpy()'s
- #ifdef __STDC__ rather than #if (from freebsd)
- be safe with a bunch of string operations (from freebsd)
- use warn()/err() over home grown versions (some from freebsd)
- rename warn() to nodaemon() to remove conflict with above
- check errno from failed kill(2) against ESRCH (from freebsd)
- use getopt() rather than home grown versions (from freebsd)
- clean up a bunch of man pages (some from freebsd)
- check for hostname spoof (from freebsd)
- use POSIX wait() interfaces
- use sysconf(_SC_OPEN_MAX) in preference to NOFILE (from freebsd)
- deal with fork() failure
- index/rindex -> strchr/strrchr (some from freebsd)
- add B57600 and B115200 speeds (from freebsd)
- some KNF
- be safe with files passed in over the network (some from freebsd)
- check return value of malloc(), calloc() and strdup()
1997-10-05 15:11:58 +00:00
mrg 90778e67aa add rcsid, use FILES, etc., in Makefile. 1997-10-05 12:48:35 +00:00
mrg bf7db08c40 freebsd's lp frontend for lpr 1997-10-05 12:40:42 +00:00
mrg cf3fe2a0b6 oops; did not mean to import these. 1997-10-05 12:35:50 +00:00
mrg e6a91a0997 merge 4.4 lite2 1997-10-05 11:52:17 +00:00
mrg e5d28dbbe3 lite-2 1997-10-05 11:20:29 +00:00
mikel 1b1fe0b84e use <sys/cdefs.h> __COPYRIGHT and __RCSID macros
garbage-collect old set_ttyflags() and ctime() declarations
1997-07-17 05:51:18 +00:00
mikel fff865d146 use <sys/cdefs.h> __COPYRIGHT and __RCSID macros
include <arpa/inet.h> for inet_ntoa() prototype, nuke local declaration
1997-07-17 05:49:13 +00:00
mikel 95abafa1a6 use <sys/cdefs.h> __RCSID macro, add prototype for local c_key function 1997-07-17 05:46:51 +00:00
mikel c27996f625 use <sys/cdefs.h> __RCSID macro 1997-07-17 05:44:32 +00:00
mikel 48f58872a4 xref pac(8) not nonexistent pac(1), sort xrefs 1997-07-16 05:54:25 +00:00
mikel 712b20e8f2 include <unistd.h> for get{,e}uid() prototypes 1997-07-11 06:43:51 +00:00
veego ff9b739e1a Add #include <stdio.h> for struct FILE. 1997-07-10 10:44:48 +00:00
mikel 1e7f2b7da9 fix printf formats and implicit comparisons (gcc -Wall) 1997-07-10 06:28:58 +00:00
mikel 3bf6872439 index array with int, not char 1997-07-10 06:26:44 +00:00
mikel 31e6ca8cc3 add prototypes for ksearch(), msearch(), and __ivaliduser() 1997-07-10 06:24:55 +00:00
mikel 4a711f6dd1 add parens (gcc -Wall) 1997-07-10 06:21:51 +00:00
mikel ad1d686121 make explicit comparisons to NULL (gcc -Wall) 1997-07-10 06:19:53 +00:00
mikel 764d9a9d44 fix typos 1997-07-10 06:18:52 +00:00
mikel b38a221a9e oops 1997-07-10 06:09:27 +00:00
mikel 0b0a21a5e8 clarify assignments used as conditionals (gcc -Wall) 1997-07-10 05:38:54 +00:00
mikel 7d65d1af46 clarify conditional in for-loop (gcc -Wall) 1997-07-10 05:34:48 +00:00
jtc a6d081153f Changed pathnames to correspond to current reality. 1997-07-09 02:34:42 +00:00
jtc afdf5dcf23 Changed /var/spool/* to /var/spool/output/*, to be consistant with reality. 1997-07-09 02:04:26 +00:00
gwr 10e180cc49 Back out the .PATH.c changes. The .depend problem (and others)
will be fixed using the new .NOPATH make feature instead.
1997-05-08 21:11:01 +00:00
gwr 012e528f2e Use .PATH.c: ... 1997-05-06 20:44:56 +00:00
thorpej b6c41d0d18 getc() returns an int, not a char. 1997-04-19 06:33:13 +00:00
lukem cd08442b0d use O_EXCL with O_CREAT when making the tempfile 1997-03-22 03:20:38 +00:00
mycroft 16cc2efbbd Change _PATH_MASTERLOCK to /var/run/lpd.pid. 1997-03-14 01:17:34 +00:00
cgd 72b0837ae3 fix one more goofup in the buffer safety changes: snprintf() should be
called with enough space for the trailing NUL, because it (unlike strn*())
always NUL-terminates.
1997-03-10 06:13:16 +00:00
cgd 7262daa78a fix two bugs pointed out by Paul Sijben <Paul.Sijben@huygens.org>:
(1) incorrect check on length of data being written (fix provided by
    Paul Sijben <Paul.Sijben@huygens.org>), and
(2) inadequate buffer (too small) for data being sent to remote meant
    that properly-formed messages couldn't be created, so job removal
    didn't work properly.
1997-03-08 22:50:52 +00:00
mouse ee6a5b2cd6 alternate -> alternative, per PR 2643 1997-03-08 14:24:19 +00:00
mrg 077acf5088 remove unsafe calls to strcpy(), strcat(), and sprintf(). some KNF. 1996-12-09 09:57:40 +00:00
explorer 37449d45b0 Fix the get-a-shell hole, even if we are not currently open to that attack.
(1.2 release is, however, and this should be pulled up and released ASAP)

The previous version (1.11) checked into current limits the duration of
setuid-root periods much more than the 1.2 released version does, so the
attacker DID get a shell, but it was not a root shell.
1996-10-25 22:07:53 +00:00
perry d8e1329af8 close out pr 2771, which added a -s ("secure") flag to lpd -- makes
lpd run in a mode where the it listens only to the local unix domain
socket and not to the network. Changes are similar but not identical
to the supplied patches.
1996-09-21 15:57:21 +00:00
explorer 66917416dd Fix printing over non-root-exported NFS at least.
The problem here is setuid(euid) is used far too much.  Since I removed
many of these calls, and added no new ones, I do not think this weakens
security.  In fact, it quite likely improves it quite a bit, since
access() is called as the real userid, and the file is opened for printing
as the real userid rather than the (setuid-root) effective one.
1996-08-10 20:09:19 +00:00
jtc d7eb41bd8e Changed to not use a compiled in table of baud rates. Evidently
there are some PC/Mac oriented devices that use non-standard speeds,
furthermore that's just not the way we do things anymore.

"Bad" baud rates are no longer caught with their own error message,
but the condition will still be diagnosed when the tcsetattr() fails.
1996-06-30 23:55:49 +00:00
pk fee478451f `/dev/printer' => `/var/run/printer' (PR#2552).
Also, change `.Os 4.2' => `.Os 4.4' (this man page is from 4.4 lite), and
for now, refer to the "BSD 4.3 Line printer manual", because that is what
we now have in lpr/SMM.doc (SMM.doc needs updating too).
1996-06-16 22:36:59 +00:00
jtc 678bd1b2eb Use XS, not XC, flags when setting tty flags.
From Brook Milligan <brook@trillium.nmsu.edu>.
1996-04-30 00:07:00 +00:00
mrg d28f8743af Stylistic changes. 1996-04-24 14:54:06 +00:00
jtc cac62b2d65 Be pedantic, main() returns int in C. 1996-03-21 17:56:15 +00:00