Aren
/
NetBSD
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

fix two bugs pointed out by Paul Sijben <Paul.Sijben@huygens.org>: 

(1) incorrect check on length of data being written (fix provided by
    Paul Sijben <Paul.Sijben@huygens.org>), and
(2) inadequate buffer (too small) for data being sent to remote meant
    that properly-formed messages couldn't be created, so job removal
    didn't work properly.
This commit is contained in:
cgd 1997-03-08 22:50:52 +00:00
parent 31b388d823
commit 7262daa78a
1 changed files with 4 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
usr.sbin/lpr/common_source/rmjob.c
View File

@ -1,4 +1,4 @@
/* $NetBSD: rmjob.c,v 1.8 1996/12/09 09:57:42 mrg Exp $ */
/* $NetBSD: rmjob.c,v 1.9 1997/03/08 22:50:52 cgd Exp $ */
/*
* Copyright (c) 1983, 1993
@ -334,7 +334,8 @@ rmremote()
for (i = 0; i < requests; i++) {
len += snprintf(line, sizeof(line), " %d", requ[i]);
}
len += 1;
/* newline nul */
len += 2;
if (len > sizeof(line))
s = malloc(len);
else
@ -360,7 +361,7 @@ rmremote()
printf("%s: ", host);
printf("connection to %s is down\n", RM);
} else {
if (write(rem, s, len) != i)
if (write(rem, s, len) != len)
fatal("Lost connection");
if (len > sizeof(line))
(void)free(s);