Commit Graph

78 Commits

Author SHA1 Message Date
mikel 712b20e8f2 include <unistd.h> for get{,e}uid() prototypes 1997-07-11 06:43:51 +00:00
veego ff9b739e1a Add #include <stdio.h> for struct FILE. 1997-07-10 10:44:48 +00:00
mikel 1e7f2b7da9 fix printf formats and implicit comparisons (gcc -Wall) 1997-07-10 06:28:58 +00:00
mikel 3bf6872439 index array with int, not char 1997-07-10 06:26:44 +00:00
mikel 31e6ca8cc3 add prototypes for ksearch(), msearch(), and __ivaliduser() 1997-07-10 06:24:55 +00:00
mikel 4a711f6dd1 add parens (gcc -Wall) 1997-07-10 06:21:51 +00:00
mikel ad1d686121 make explicit comparisons to NULL (gcc -Wall) 1997-07-10 06:19:53 +00:00
mikel 764d9a9d44 fix typos 1997-07-10 06:18:52 +00:00
mikel b38a221a9e oops 1997-07-10 06:09:27 +00:00
mikel 0b0a21a5e8 clarify assignments used as conditionals (gcc -Wall) 1997-07-10 05:38:54 +00:00
mikel 7d65d1af46 clarify conditional in for-loop (gcc -Wall) 1997-07-10 05:34:48 +00:00
jtc a6d081153f Changed pathnames to correspond to current reality. 1997-07-09 02:34:42 +00:00
jtc afdf5dcf23 Changed /var/spool/* to /var/spool/output/*, to be consistant with reality. 1997-07-09 02:04:26 +00:00
gwr 10e180cc49 Back out the .PATH.c changes. The .depend problem (and others)
will be fixed using the new .NOPATH make feature instead.
1997-05-08 21:11:01 +00:00
gwr 012e528f2e Use .PATH.c: ... 1997-05-06 20:44:56 +00:00
thorpej b6c41d0d18 getc() returns an int, not a char. 1997-04-19 06:33:13 +00:00
lukem cd08442b0d use O_EXCL with O_CREAT when making the tempfile 1997-03-22 03:20:38 +00:00
mycroft 16cc2efbbd Change _PATH_MASTERLOCK to /var/run/lpd.pid. 1997-03-14 01:17:34 +00:00
cgd 72b0837ae3 fix one more goofup in the buffer safety changes: snprintf() should be
called with enough space for the trailing NUL, because it (unlike strn*())
always NUL-terminates.
1997-03-10 06:13:16 +00:00
cgd 7262daa78a fix two bugs pointed out by Paul Sijben <Paul.Sijben@huygens.org>:
(1) incorrect check on length of data being written (fix provided by
    Paul Sijben <Paul.Sijben@huygens.org>), and
(2) inadequate buffer (too small) for data being sent to remote meant
    that properly-formed messages couldn't be created, so job removal
    didn't work properly.
1997-03-08 22:50:52 +00:00
mouse ee6a5b2cd6 alternate -> alternative, per PR 2643 1997-03-08 14:24:19 +00:00
mrg 077acf5088 remove unsafe calls to strcpy(), strcat(), and sprintf(). some KNF. 1996-12-09 09:57:40 +00:00
explorer 37449d45b0 Fix the get-a-shell hole, even if we are not currently open to that attack.
(1.2 release is, however, and this should be pulled up and released ASAP)

The previous version (1.11) checked into current limits the duration of
setuid-root periods much more than the 1.2 released version does, so the
attacker DID get a shell, but it was not a root shell.
1996-10-25 22:07:53 +00:00
perry d8e1329af8 close out pr 2771, which added a -s ("secure") flag to lpd -- makes
lpd run in a mode where the it listens only to the local unix domain
socket and not to the network. Changes are similar but not identical
to the supplied patches.
1996-09-21 15:57:21 +00:00
explorer 66917416dd Fix printing over non-root-exported NFS at least.
The problem here is setuid(euid) is used far too much.  Since I removed
many of these calls, and added no new ones, I do not think this weakens
security.  In fact, it quite likely improves it quite a bit, since
access() is called as the real userid, and the file is opened for printing
as the real userid rather than the (setuid-root) effective one.
1996-08-10 20:09:19 +00:00
jtc d7eb41bd8e Changed to not use a compiled in table of baud rates. Evidently
there are some PC/Mac oriented devices that use non-standard speeds,
furthermore that's just not the way we do things anymore.

"Bad" baud rates are no longer caught with their own error message,
but the condition will still be diagnosed when the tcsetattr() fails.
1996-06-30 23:55:49 +00:00
pk fee478451f `/dev/printer' => `/var/run/printer' (PR#2552).
Also, change `.Os 4.2' => `.Os 4.4' (this man page is from 4.4 lite), and
for now, refer to the "BSD 4.3 Line printer manual", because that is what
we now have in lpr/SMM.doc (SMM.doc needs updating too).
1996-06-16 22:36:59 +00:00
jtc 678bd1b2eb Use XS, not XC, flags when setting tty flags.
From Brook Milligan <brook@trillium.nmsu.edu>.
1996-04-30 00:07:00 +00:00
mrg d28f8743af Stylistic changes. 1996-04-24 14:54:06 +00:00
jtc cac62b2d65 Be pedantic, main() returns int in C. 1996-03-21 17:56:15 +00:00
hpeyerl 8c4481f80c More descriptive message for printer status. Addresses PR #509. 1996-01-14 17:25:21 +00:00
pk 3cf040d518 Fix typo (Noriyuki Soda; PR#1926). 1996-01-13 23:18:15 +00:00
jtc 21908ddbd5 merge in changes from 1.1 release branch 1995-11-28 19:43:04 +00:00
pk a29aff2565 Id -> NetBSD 1995-11-15 22:55:41 +00:00
pk f54b84516b Add RCSIDs 1995-11-15 22:48:07 +00:00
pk b965d4ffe4 Add RCSIDs 1995-11-15 22:27:27 +00:00
pk f93236c806 Add RCSIDs. 1995-11-15 22:23:06 +00:00
pk 0e9c04fab0 Fix garbled lines (from Thomas Eberhardt; PR#1756).
Add RCSId.
1995-11-15 22:20:33 +00:00
mycroft 49d5e89682 Update from kernel source. 1995-10-05 08:58:21 +00:00
mycroft 1e1d370eec Fix typos. 1995-10-05 08:23:18 +00:00
mycroft 2347ccba1b Fix various parity and character size bugs from the termios transition. 1995-10-05 08:20:20 +00:00
mycroft fde6ad0815 Fix a couple of things broken in the termios transition. 1995-10-05 08:01:29 +00:00
mycroft dfd0b8b273 Fix type errors. 1995-10-05 07:47:32 +00:00
mycroft 0231229adc Fix typo in previous. 1995-10-05 07:42:30 +00:00
mycroft 780c7fbe39 Change to use SET(), CLR(), and ISSET() macros. 1995-10-05 07:39:39 +00:00
hpeyerl 8e41ca8016 -- convert sgtty to termios. From: Scott Bartram <scottb@iis.net>
-- Use seteuid() to only give lpr, lprm, lpq and lpc root when they
   need it from matthew green <mrg@mame.mu.oz.au>
1995-10-03 15:02:17 +00:00
jtc a0e044841b Use consistant style of quotes; PR #1194 1995-07-07 22:26:11 +00:00
mycroft abd8200176 Reset group list before execing child, as pointed out by Mike Pritchard. 1995-04-14 19:23:43 +00:00
cgd d8806814a6 specify man pages the new way. 1994-12-22 11:32:57 +00:00
pk d88e845b42 Correct character array declaration (bug-report bin608). 1994-12-11 16:07:22 +00:00