It was broken since rev 1.21 24 years ago, and got more broken code later on:
remove leftover device_xname(sc->sc_dev) param from aprint_debug_dev in one block.
fix wrong method name devoce_xname to device_xname in second block.
rename et to eh for consistency, and define it (definition was removed in the past).
while here, improve the code with riastradh help to make it safer.
pullup to at least netbsd-10 is needed.
netbsd-core.c is for the old-style core format, which has
never been used for riscv.
Note that:
- binutils/bfd does not use this file for riscv.
- Up-to-date core file format is supported by elf.c.
It does not longer output redundant `` (ipip-proto-4)'':
cba9b77a98
Now, these tests become passing again.
Thanks mlelstv@ for finding out upstream commit.
OK ozaki-r@
Nor is it a bug that they're applied to the file rather than stored in
some magic secret database where they survive reinstalls, which the
prior wording seems to suggest was the eventual intention.
It is worth noting that they change the target file, so still say that.
Debug lists are probably still wrong, though -- looks like there's no
rule to change h_inotify_*.out.debug to h_inotify_*.debug. Out of
energy to look into this further, though; please fix me!
It must be better to have this workaround here, rather than in external.
(Thanks uwe@ for suggestion!)
Confirmed that the same files generated as before.
However, unfortunately, it does not work even if MAXTSIZ is bumped.
It seems to be too large for 24-bit address space.
This is not a regression; gdb.old does not work also.
Otherwise, rename(2) gets replaced by gnulib version for mknative
(i.e., cross compile), which results build failure for clang.
Confirmed that all rename(2) tests successfully passed at least on
amd64. Even if they will fail, it is our responsibility to fix them,
not gdb, anyway.
XXX
Edit configure by hand, rather than regen it, in order to avoid
subtle huge diffs from upstream, which come from autoconf version
mismatch.
XXX XXX
For gcc, replacement for rename(2) lost by cstdio, which forcibly
undefs all stdio functions. This should be an unintended behavior.
One of cstdio comes from our local change for c++locale.h, but
even if it is dropped, cstdio is included from elsewhere.
The workaround is only needed if the time format contains '%s', in all
other cases there is no need to preserve, set and restore the TZ
environment variable. Suggested by sjg@.
Only check for 's' in the format string, not for '%s', to allow for
optional modifiers of the conversion specifier.
Previously, the error message 'Invalid line' showed only the expanded
line, which might or might not show the actual problem. To be more
helpful, add the unexpanded line to the error message in case they
differ.
Remove the special handling of invalid lines that result from merge
conflicts. RCS is not commonly used anymore, and mentioning CVS was too
specific. By echoing the whole line, the patterns '<<<<<<' and '>>>>>>'
are clear enough to hint at the problem.
andvar