d5b021c7ed
Fix up some lint.
2011-08-07 06:03:45 +00:00
2c0ecb1ab6
Fix up still more casts; use NULL instead of (char *)0.
2011-08-06 20:42:43 +00:00
8041af98f6
Remove *another* set of useless casts. sheesh
2011-08-06 20:32:25 +00:00
8e73b3ad76
Remove more silly casts.
2011-08-06 20:29:37 +00:00
5aa2a843dc
drop private (and wrong) definition of NULL
2011-08-06 20:24:35 +00:00
434d266e91
Use the right type for the malloc wrapper function, and don't cast the
...
return value.
(XXX: Except for a pile of allocation macros that produce typed pointer
results; there the typechecking of the result assignment is more valuable
than the warning if the alloc function isn't declared properly. These
macros should go away.)
2011-08-06 20:18:26 +00:00
25ec296591
Remove silly casts.
2011-08-06 20:00:33 +00:00
842dc544ae
<sys/wait.h> is standard, so just use it instead of fiddling about with
...
ifdefs for long-dead systems. While here, remove union wait.
2011-08-06 19:53:24 +00:00
d30849d1cd
abolish references to index/rindex
2011-08-06 19:47:54 +00:00
813e3e415d
Remove the PYRAMID_BUG code. I don't think Pyramids are coming back, nor
...
do we care if their compiler vomits trying to decrement a bitfield.
2011-08-06 19:32:58 +00:00
cbc660deee
Don't refer to index() in comments; use strchr().
2011-08-06 19:23:38 +00:00
fcfbc606bf
Include system headers before private headers. Avoids various possible
...
symbol conflicts.
2011-07-20 07:04:30 +00:00
1a1e24f1e6
include sys/time.h earlier (rather than implicitly via fcntl.h) so that
...
the "u" variable doesn't shadow stuff, found later in time.h inlines.
kind of a hack, but i don't want to modify time.h either.
XXX: seems kind of annoying
2011-07-02 02:10:33 +00:00
d060781d89
rename a variable from "time" to "stime" (it's a string)
2011-07-02 02:09:08 +00:00
c111245a78
apply some -Wno-error and/or -fno-strict-aliasing.
...
all of this should be looked at closer, but some of them are not
very trivial.
2011-06-22 02:49:41 +00:00
ab7b7d013a
Use consistent sign in compare, the function is only called with
...
constants as third argument anyway.
2011-05-30 03:11:15 +00:00
57c13365a3
Correctly print variables as strings, not as format string.
2011-05-23 22:53:25 +00:00
98eb889579
Userland now builds and uses terminfo instead of termcap.
...
OK: core@, jdc@
2010-02-03 15:34:37 +00:00
32b30fe688
Simplify alloc() to avoid ifdef(LINT) workaround.
2010-01-17 22:55:20 +00:00
9b92b18917
sprinkle static
2009-08-12 07:28:40 +00:00
165c915b22
Fix two serious string-handling bugs (one exploitable, one probably
...
exploitable) and also add proper checking/paranoia in several other
places.
2009-06-29 23:05:33 +00:00
b8c355d789
a bit more const
2009-06-07 21:04:54 +00:00
a7a3b831c7
sprinkle some more const
2009-06-07 20:31:10 +00:00
8d5216e80d
remove unnecessary casts
2009-06-07 20:25:38 +00:00
907fca1b3e
sprintf -> snprintf, plus some use of strlcpy/strlcat where appropriate
...
XXX: there's still one sprintf left which will take some hacking to expunge.
2009-06-07 20:13:18 +00:00
1fa8a9a633
ANSIfy function declarations. All object file diffs inspected.
2009-06-07 18:30:39 +00:00
37a52c5f7b
Change getdate() to getdatestr() since the former maybe present on systems
...
supporting X/Open System Interfaces Extension (XSI) getdate() in <time.h>.
This prevents a function prototype conflict.
2009-05-06 02:59:12 +00:00
f341bbffe8
use %zu to print size_t
2009-01-18 13:30:33 +00:00
c6144e484f
fix -Wsign-compare issues
2009-01-18 00:24:29 +00:00
3c9a95916d
Wrap compiler-specific flags with HAVE_GCC and HAVE_PCC as necessary. Add a few flags for PCC.
2008-08-29 00:02:21 +00:00
ce099b4099
Remove clause 3 and 4 from TNF licenses
2008-04-28 20:22:51 +00:00
3c439f438f
Make hack build with WARNS=4.
2008-01-28 06:55:41 +00:00
8b0f9554ff
convert __attribute__s to applicable cdefs.h macros
2007-12-15 19:44:37 +00:00
f90603d08a
Update my previous commit to better match the original code, including
...
the check for 'bs'... my previous commit should have included the
following text:
fixes problem introduced in 1.13 where the setting of "BC" (backspace char)
was left to libterm rather than being done by hack itself. the problem
with this was that hack was directly setting BC to \b if there was no
"bc" in the termcap entry, but libterm does not do this. this resulted in
the xputs(BC) calls in nocmov() and backsp() incorrectly doing nothing, thus
messing up the display. added new var BC_BS to provide the old behavior
for nocmov() and backsp().
2007-01-17 02:35:28 +00:00
bfec35be7a
mrg's changes in 1.13 broke hack's display code.
2007-01-17 02:12:19 +00:00
6919c6578c
s/independant/independent/, from Zafer.
2006-11-24 22:04:21 +00:00
1665d5e960
fix spelling of accommodate; from Zapher.
2006-11-24 19:46:58 +00:00
a108a3f479
Coverity CID 3382: Fix memory leak.
2006-05-13 22:45:11 +00:00
4b679b2a7f
Coverity CID 3383: Fix memory leak.
2006-05-13 22:43:02 +00:00
8e969ac070
UC, PC and BC are provided my libtermcap, don't duplicate them.
2006-05-11 00:18:31 +00:00
1ce9f4326d
Coverity CID 3032: Prevent double free: Next to the call of page_more()
...
there is a comment saying /* does fclose */, but the next line calls
fclose(fp);. Go figure.
2006-04-24 20:08:54 +00:00
8710461ab4
Coverity CID 2791: Fix file pointer leak.
2006-04-02 00:08:12 +00:00
995d4b331f
Coverity CID 1327: check for error return
2006-03-30 01:32:27 +00:00
a3fb5aa745
Bah! Compare, don't assign!
2006-03-30 01:31:13 +00:00
dce307414d
Coverity CID 1328: check for error return
2006-03-30 01:28:46 +00:00
f413c2ba58
Coverity CID 1326: check for error return
2006-03-30 01:25:52 +00:00
db7b70f433
Fix Coverity issue 891 -- FORWARD_NULL.
...
Approved by christos@.
2006-03-29 01:21:07 +00:00
83f277c49a
Fix Coverity issues 2366 and 2365 -- REVERSE_INULL.
...
Approved by Christos@.
2006-03-29 01:19:51 +00:00
2ad8d2c6cd
Fix Coverity issue 2584 -- USE_AFTER_FREE and issue 889 -- FORWARD_NULL.
...
Approved by christos@.
2006-03-29 01:18:39 +00:00
feaaa5ed4c
Change DPADD from LIBTERM (which doesn't exist) and LIBCOMPAT (which it
...
doesn't use) to LIBTERMCAP (which it does use).
2006-02-25 11:56:51 +00:00
dholland