Commit Graph

235312 Commits

Author SHA1 Message Date
dholland
a409b95d7f Coverity CID 975184: don't ignore pmf_device_register failure.
(XXX: unfortunately all we can do for the moment is print a warning)
2015-05-09 21:31:05 +00:00
christos
f4ad1a1253 use EXIT_SUCCESS/EXIT_FAILURE consistently. 2015-05-09 21:22:18 +00:00
christos
430343a0c6 The L (Length) and M (More) flags needs to be cleared before deciding
whether the locally generated response requires fragmentation. This
fixes an issue where these flags from the server could have been invalid
for the following message. In some cases, this could have resulted in
triggering the wpabuf security check that would terminate the process
due to invalid buffer allocation.

XXX: pullup-7
2015-05-09 19:51:43 +00:00
christos
38d77090f3 The remaining number of bytes in the message could be smaller than the
Total-Length field size, so the length needs to be explicitly checked
prior to reading the field and decrementing the len variable. This could
have resulted in the remaining length becoming negative and interpreted
as a huge positive integer.

In addition, check that there is no already started fragment in progress
before allocating a new buffer for reassembling fragments. This avoid a
potential memory leak when processing invalid message.

XXX: pullup-7
2015-05-09 19:49:28 +00:00
christos
11ce78e57f The length of the received Commit and Confirm message payloads was not
checked before reading them. This could result in a buffer read
overflow when processing an invalid message.

Fix this by verifying that the payload is of expected length before
processing it. In addition, enforce correct state transition sequence to
make sure there is no unexpected behavior if receiving a Commit/Confirm
message before the previous exchanges have been completed.

Thanks to Kostya Kortchinsky of Google security team for discovering and
reporting this issue.

XXX: pullup-7
2015-05-09 19:46:01 +00:00
christos
c23d0f7f66 The length of the WMM Action frame was not properly validated and the
length of the information elements (int left) could end up being
negative. This would result in reading significantly past the stack
buffer while parsing the IEs in ieee802_11_parse_elems() and while doing
so, resulting in segmentation fault.

This can result in an invalid frame being used for a denial of service
attack (hostapd process killed) against an AP with a driver that uses
hostapd for management frame processing (e.g., all mac80211-based
drivers).

Thanks to Kostya Kortchinsky of Google security team for discovering and
reporting this issue.

XXX: pullup-7
2015-05-09 19:35:15 +00:00
christos
e4bfca3a3e strtoul() return value may end up overflowing the int h->chunk_size and
resulting in a negative value to be stored as the chunk_size. This could
result in the following memcpy operation using a very large length
argument which would result in a buffer overflow and segmentation fault.

This could have been used to cause a denial service by any device that
has been authorized for network access (either wireless or wired). This
would affect both the WPS UPnP functionality in a WPS AP (hostapd with
upnp_iface parameter set in the configuration) and WPS ER
(wpa_supplicant with WPS_ER_START control interface command used).

Validate the parsed chunk length value to avoid this. In addition to
rejecting negative values, we can also reject chunk size that would be
larger than the maximum configured body length.

Thanks to Kostya Kortchinsky of Google security team for discovering and
reporting this issue.

XXX: pullup-7
2015-05-09 19:33:47 +00:00
dholland
116f085a39 Update HISTORY from OpenBSD: strerror from 4.3 Reno, perror from v4.
(this page was claiming both were from 4.4, which is clearly rubbish)
2015-05-09 19:01:53 +00:00
jmcneill
430e427719 Jetson TK1: USB1 VBUS power is controlled by GPIO N4 2015-05-09 18:57:30 +00:00
jmcneill
245d537bdd Tegra USB PHY support 2015-05-09 18:56:51 +00:00
christos
925d349b50 tricks with sizeof() make coverity complain. 2015-05-09 18:49:36 +00:00
dholland
a9ad5ddc08 Also check the other emitted getrlimit call for failure. 2015-05-09 18:48:14 +00:00
christos
37fd390ec4 if no address was found, don't check if it is tentative (hi Roy) 2015-05-09 18:47:26 +00:00
christos
28383371f1 assign sin only when it is needed 2015-05-09 18:46:25 +00:00
dholland
d4f9fa9c7c perror -> warn 2015-05-09 18:32:04 +00:00
dholland
c0ca3685e5 check setrlimit too 2015-05-09 18:22:37 +00:00
dholland
1f655ad914 ICYMI 2015-05-09 18:18:32 +00:00
rtr
8b82ed454c when calling nfs_boot_sendrecv pass NULL for pointers instead of 0 2015-05-09 18:12:19 +00:00
snj
b70fe1db78 This product includes software developed by Yasushi Yamasaki. 2015-05-09 17:49:33 +00:00
matt
fd2293f463 Fix TEXTREL message to print out the section name 2015-05-09 17:43:23 +00:00
mlelstv
b9d91f58a9 When searching for a best font also allow fonts too wide for the
desired display columns but penalize these against all narrower ones.
2015-05-09 16:40:37 +00:00
christos
fd05aad26e add overlapping pointer checks 2015-05-09 15:42:21 +00:00
christos
adfc40c594 add a macro to check overlapping pointers 2015-05-09 15:41:47 +00:00
christos
bcec7bd07a CID 1294266: Cast to void. 2015-05-09 15:36:15 +00:00
christos
e617b5c6d2 CID 1292512: Help coverity with offset NULL calculations 2015-05-09 15:34:13 +00:00
christos
0286f1d2e9 CID 1292510: Check allocation 2015-05-09 15:31:36 +00:00
christos
f29f1289ff CID 1268629: Don't deref NULL (can't happen unless count is incorrect;
code safety).
2015-05-09 15:28:25 +00:00
christos
e8c33bf290 CID 1256503: Handle memory leak 2015-05-09 15:24:56 +00:00
rtr
d53103fc75 change sosend() to accept sockaddr * instead of mbuf * for nam.
bump to 7.99.16
2015-05-09 15:22:47 +00:00
christos
6f91147d24 CID 1256502: missing lint fallthrough comment 2015-05-09 15:14:45 +00:00
christos
bb21fbff87 CID 1225082: Check getrlimit() return 2015-05-09 15:12:12 +00:00
matt
9ef253dfc0 Add compat_netbsd32.kmod if arch64 2015-05-09 14:22:34 +00:00
matt
d03fef21ba Update set lists for compat_netbsd32.kmod 2015-05-09 14:21:07 +00:00
matt
b3d190b5c2 Build compat_netbsd32.kmod for arm and mips64 2015-05-09 14:19:13 +00:00
ragge
36f91343b4 PR port-vax/49884
Fixes bug introduced in earlier cleanup.
2015-05-09 13:43:45 +00:00
christos
5afcdacc80 CID 1225079: check getrlimit return 2015-05-09 13:32:30 +00:00
christos
9c27fd2a44 CID 1225078: check getrlimit return 2015-05-09 13:28:55 +00:00
christos
f49d3ada41 CID 1225088: check return of getrlimit 2015-05-09 13:26:06 +00:00
christos
4b6d6c838f CID 1225077: check getrlimit return 2015-05-09 13:22:37 +00:00
christos
94e199271d CID 710492: dev_priv was dereferenced in via_release_futex, no point in
checking again.
2015-05-09 13:19:22 +00:00
christos
9a0dcc7c97 CID 976986: NULL deref. 2015-05-09 13:16:42 +00:00
christos
7a74e96fe5 CID 1009289: Check getrlimit 2015-05-09 13:10:50 +00:00
christos
900f611a8e remove unreachable code. 2015-05-09 13:08:26 +00:00
christos
f95fdeb71c CID 1297229: use strlcpy 2015-05-09 13:07:20 +00:00
christos
a711b8a7ae CID 1297228: Use strlcpy 2015-05-09 13:05:51 +00:00
martin
b2609efb8f When exiting from the "ftpsource" menu, explicitly set yesno to -1 (again),
to avoid a retry loop because a submenu action has changed this global.
Fixes PR 49440.
2015-05-09 12:55:06 +00:00
jmcneill
036acc4d2c for Jetson TK1, GPIO N5 controls vbus vdd for USB2 2015-05-09 12:08:30 +00:00
jmcneill
7ba619cb80 if vbus gpio pin is provided, use it to enable vdd 2015-05-09 12:07:52 +00:00
jmcneill
9271af34be tegra_gpio_acquire: if a pin is required and not in GPIO mode, switch configuration instead of bailing out 2015-05-09 12:07:11 +00:00
martin
f33ca424b5 Add a new utility function "update_wedges()", which triggers a scan
for wedges on the given disk. Call this after writing a disklabel.
This makes all auto-discovered wedges go away after we changed the
partitioning (and are not using GPT) and fixes PR 49665.
2015-05-09 12:06:31 +00:00