Commit Graph

280014 Commits

Author SHA1 Message Date
riastradh
82242297a7 npf: Don't stop early after sleeping and before processing instances.
We already check winfo->exit below, after processing instances and
before sleeping again.

Candidate fix for:

panic: kernel diagnostic assertion "LIST_EMPTY(&winfo->instances)" failed: file "/home/riastradh/netbsd/current/src/sys/rump/net/lib/libnpf/../../../..//net/npf/npf_worker.c", line 300 NPF instances must be discharged before the npfk_sysfini() call
2020-08-27 18:49:36 +00:00
skrll
7f9d4e51bf Avoid undefined behaviour as detected by KUBSAN 2020-08-27 16:35:13 +00:00
riastradh
64605abad9 Remove bogus Atffile and Kyuafile entries for if_wg tests. 2020-08-27 15:32:37 +00:00
riastradh
0d3faa6162 Sort and deduplicate set lists. 2020-08-27 15:31:59 +00:00
riastradh
af24ffc1cc Omit spurious leading dash in debug/ad.mips set list entries.
(if this actually means something feel free to revert and document
what it means somewhere obvious!)
2020-08-27 15:30:04 +00:00
riastradh
4ab307ac4c Fix obsolete entry for /usr/lib/libcdk.so.
This was broken in rev. 1.1230.
2020-08-27 15:28:53 +00:00
fcambus
aa9ad6b429 Fix a bunch of typos in various kernel man pages. 2020-08-27 14:14:00 +00:00
riastradh
adaf68a3d1 Sort includes, nix trailing whitespace, fix comment. 2020-08-27 14:11:57 +00:00
riastradh
261d3f19e6 Move address hashing from init_main.c to kern_sysctl.c.
This way rump gets it automatically.  Make sure blake2s is in
librumpkern.so, not just in librumpkern_crypto.so, for this to work.
2020-08-27 14:01:36 +00:00
christos
52d4f80613 - when running as root, create the socket under a different uid/gid to verify
that it works properly with different users opening the socket.
- verify that linux works the same for both getpeereid() and fstat()
2020-08-27 14:00:01 +00:00
riastradh
4a294d459c wg: Assert MCLBYTES is enough for requested length in wg_get_mbuf. 2020-08-27 13:44:41 +00:00
kardel
f33b2e8145 Move mii_phy_statusmsg(sc) back to its original position. Fixes
deafness bug on macppc reported and tested by martin@
Thanks !
2020-08-27 10:10:23 +00:00
hannken
381048869c Enable NCLOOKUP for ZFS. 2020-08-27 09:57:33 +00:00
rillig
8dde8e9642 make(1): migrate Lst_Last to Lst_LastS 2020-08-27 07:03:48 +00:00
rillig
b855b10134 make(1): migrate Lst_Succ to Lst_SuccS 2020-08-27 07:00:29 +00:00
rillig
6c196ebe9c make(1): migrate Lst_ForEach to Lst_ForEachS
Most lists are always valid.  Only the "targets" variable may be null in
some cases, probably.
2020-08-27 06:53:57 +00:00
rillig
f199d14109 make(1): migrate Lst_ForEachFrom to Lst_ForEachFromS 2020-08-27 06:31:46 +00:00
rillig
760b7512c6 make(1): migrate remaining code from Lst_Open to Lst_OpenS 2020-08-27 06:28:44 +00:00
rillig
bc1fe826c1 make(1): remove unused declarations from job.h 2020-08-27 06:18:22 +00:00
rillig
ffe49907b6 make(1): convert Arch_ParseArchive from ReturnStatus to Boolean
There are only few functions left that use the ReturnStatus.  These will
be converted as well, to get rid of the additional typedef.
2020-08-27 06:13:53 +00:00
msaitoh
ede3da9a3b Limit MA10-ST0's quirk only for on-chip devices. 2020-08-27 04:54:43 +00:00
msaitoh
e385790b16 Fix compile error. 2020-08-27 04:49:52 +00:00
msaitoh
fe9f82c041 Minor change.
- Print "X550EM X" instead of "X550EM" for Xeon D devices.
 - Fix typo in comment. Same as FreeBSD.
2020-08-27 03:57:52 +00:00
riastradh
687043c1f4 wg: Make sure all paths into wg_handle_msg_data guarantee enough m_len.
Earlier commit moved the m_pullup into wg_validate_msg_header, but
wg_overudp_cb doesn't go through that.
2020-08-27 03:05:34 +00:00
riastradh
658b7d4eac wg: Drop invalid message types on the floor faster.
Don't even let them reach the thread -- drop them in softint.
2020-08-27 02:55:04 +00:00
riastradh
85726c216d wg: KASSERT m_len before mtod.
XXX We should really make mtod do this automagically, and use
something else for mtod(m, void *).
2020-08-27 02:54:31 +00:00
riastradh
463c73dd75 wg: Use m_pullup to make message header contiguous before processing. 2020-08-27 02:53:47 +00:00
riastradh
03c60d1bc0 wg: Check mbuf chain length before m_copydata. 2020-08-27 02:52:33 +00:00
riastradh
5ec0ae9a4b Use wgconfig as intended to show diagnostics, not a usage message. 2020-08-27 02:51:49 +00:00
riastradh
e88ecca629 Fix order of cleanup actions in rumpuser_wg_create error branch. 2020-08-27 02:51:15 +00:00
riastradh
efb788bb64 Paranoia: use strlcpy rather than strcpy here and detect truncation.
Not an issue for the one caller in tree, but let's not leave rakes to
step on.
2020-08-27 02:50:44 +00:00
simonb
8ac9ace5b3 Whitespace nit. 2020-08-27 01:52:04 +00:00
msaitoh
e883894388 ADD SFP+ MOD_ABS inversion quirk.
On X550 EM, GPIO(SDP) and SFP+'s MOD_ABS is directly connected. It has
no inverter. GIGABYTE MA10-ST0 has a inverter, so add new quirk for it.
2020-08-27 00:07:56 +00:00
christos
f55490be1e Provide a helpful error message if we don't have privs to read kernel
addresses.
2020-08-26 23:08:29 +00:00
rillig
0ef96ddde1 make(1): merge duplicate code for creating a new suffix 2020-08-26 23:08:26 +00:00
rillig
ca993cd932 make(1): remove header sprite.h
Make is independent of the Sprite operating system.
2020-08-26 23:00:47 +00:00
christos
a09dcfa2d4 undo previous, now sockstat works without privs 2020-08-26 22:57:55 +00:00
christos
1d0978b88c Instead of returning 0 when sysctl kern.expose_address=0, return a random
hashed value of the data. This allows sockstat to work without exposing
kernel addresses or being setgid kmem.
2020-08-26 22:56:55 +00:00
rillig
4862a68b32 make(1): add stricter variants for remaining Lst functions
In most cases the Lst functions are only called when the arguments are
indeed valid.  It's not guaranteed though, therefore each function call
needs to be analyzed and converted individually.

While here, remove a few statements that were only useful when the Lst
functions handled circular lists.
2020-08-26 22:55:46 +00:00
christos
9abb5a7a5d add socket info for user and group for unix sockets in fstat. 2020-08-26 22:54:30 +00:00
christos
ac4837d560 Check that fstat returns the correct socket owner 2020-08-26 22:52:58 +00:00
maxv
699b2c0a0a Add a check to prevent shift by -1. Not really important in this case,
but to appease KUBSAN.

Reported-by: syzbot+4026e8201b6b484b8cb4@syzkaller.appspotmail.com
2020-08-26 16:36:32 +00:00
maxv
6a0055846e nvmm-x86-svm: improve the handling of MSR_EFER
Intercept reads of it as well, just to mask EFER_SVME, which the guest
doesn't need to see.
2020-08-26 16:33:03 +00:00
maxv
c4a1adbbd0 nvmm-x86: improve the handling of RFLAGS.RF
- When injecting certain exceptions, set RF. For us to have an up-to-date
   view of RFLAGS, we commit the state before the event.
 - When advancing RIP, clear RF.
2020-08-26 16:32:02 +00:00
maxv
fb998e8d60 nvmm-x86-vmx: improve the handling of CR4
- Filter out certain features we don't want the guest to enable. This is
   for general correctness, and future-proofness.
 - Flush the guest TLB when certain flags change.
2020-08-26 16:30:50 +00:00
maxv
0cdd6e420c nvmm: slightly clarify 2020-08-26 16:29:49 +00:00
maxv
77639979d1 nvmm-x86-svm: don't forget to intercept INVD
INVD executed in the guest can be dangerous for the host, due to CPU
caches being flushed without write-back.
2020-08-26 16:29:19 +00:00
maxv
72acabaeb7 nvmm: misc improvements
- use mach->ncpus to get the number of vcpus, now that we have it
 - don't forget to decrement mach->ncpus when a machine gets killed
 - add more __predict_false()
2020-08-26 16:28:17 +00:00
riastradh
25154f5f0c Clarify wg(4)'s relation to WireGuard, pending further discussion.
Still planning to replace wgconfig(8) and wg-keygen(8) by one wg(8)
tool compatible with wireguard-tools; update wg(4) for the minor
changes from the 2018-06-30 spec to the 2020-06-01 spec; &c.  This just
clarifies the current state of affairs as it exists in the development
tree for now.

Mark the man page EXPERIMENTAL for extra clarity.
2020-08-26 16:03:40 +00:00
riastradh
14c8a2247f Nix trailing whitespace and mixed space/tab indentation. 2020-08-26 15:54:10 +00:00