Commit Graph

137 Commits

Author SHA1 Message Date
hubertf 924dbbdb7d Fix fix for Coverity CID 2751:
Move an error check to the right place, and instead of blindly insisting on
an argument for all of "no-emul-boot", "no-boot", "hard-disk-boot" and
"boot-load-segment", only require it for the last one, which is the only
one that requires/uses it.

OK'd by Christos
2006-06-01 21:06:37 +00:00
christos 323f38bde6 Coverity CID 2751: Avoid NULL deref. 2006-05-25 00:25:00 +00:00
mrg 16efbf8575 don't do the -Wno-pointer-sign dance for host programs. 2006-05-12 01:18:25 +00:00
mrg aadd7d4847 sprinkle some -fno-strict-aliasing and -Wno-pointer-sign with GCC4. 2006-05-11 23:16:28 +00:00
christos 2e3cc3a126 Coverity CID 174: Add extra NULL test to appease coverity. 2006-04-22 17:40:49 +00:00
christos d9b764e5f1 Coverity CID 548: Fix resource leak. 2006-04-22 17:38:20 +00:00
christos be722641b9 Coverity CID 550: Resource leak. 2006-04-22 17:33:55 +00:00
riz a27001b755 Coverity CID 2757: Don't leak memory in error conditions. 2006-03-23 01:27:08 +00:00
rtr b06fd00a81 free buf on error path
coverity 190 / run 5
2006-03-18 12:35:41 +00:00
rpaulo 0f0ba22069 bump date 2006-03-12 11:18:31 +00:00
jschauma 25b6d6ab50 fix typo: explcitly -> explicitly 2006-03-11 22:56:57 +00:00
wiz 4679714200 Sort SEE ALSO. 2006-02-04 18:48:01 +00:00
dyoung 9d2dd62a57 Stop duplicating the ISO9660 sources in sys/fs/cd9660/ for makefs(8). 2006-02-01 22:19:34 +00:00
martin 91378840b8 Add reference to installboot(8), as suggested by Patrick Welche. 2006-01-26 15:05:27 +00:00
perry ae6ae2c362 Remove leading __ from __(const|inline|signed|volatile) -- it is obsolete. 2005-12-24 20:56:41 +00:00
dyoung 5138e74947 Fix a bug in cd9660_sort_nodes, which tried to insert `next' before
`node' on a tail-queue, when `node' wasn't on the tail-queue.
Sometimes this led to a segfault.  Insert before `cn', since that
is the intention.  Closes PR 32194. Thanks, Jeff Rizzo, for reporting
this bug.
2005-11-30 00:26:11 +00:00
dyoung fec0b664fc Oops, condition another printf on verbose_level > 0. 2005-10-31 23:21:25 +00:00
dyoung 96801f79bb Condition several cd9660 printfs on verbose_level > 0. Silences
makefs -t cd9660.
2005-10-31 23:19:54 +00:00
dyoung 933a7c2901 Change cd9660's default verbosity level to 0, quieting it down
considerably.
2005-10-31 23:19:06 +00:00
wiz 3a6af42b59 Bump date for previous. 2005-10-31 11:34:55 +00:00
dyoung 2fa0e02b0b Remove the cd9660_inode hashtable for hard-links support, and re-use
the fsinode for the same purpose, per Luke Mewburn's suggestion on
source-changes@.
2005-10-31 08:29:19 +00:00
dyoung 1da546647c Add hard-link support: keep a hashtable that maps inodes for
regular files on the source filesystem to the offset of the first
data block on the target filesystem.  Don't allocate blocks for a
file a second time (i.e., if it is already present in the hashtable).
Avoid writing the blocks of a file twice (use the FS_WRITTEN flag
in fsinode->flags for this purpose).
2005-10-30 09:27:49 +00:00
dyoung f334b70aa1 Normalize {err,warn}{,x} uses. 2005-10-30 07:40:45 +00:00
dyoung 4a3fce43c0 Now that I understand what order boot-images and boot-entries are
intended to be kept on the boot-images and -entries lists, keep
them in that order: images grouped and entries grouped by system,
with later images nearer the front of the list.

*Really* apply boot options to the last boot-image specified.
2005-10-30 07:33:57 +00:00
dyoung 3c2cee9d4a Bug fix: record the actual number number of 512-byte "virtual"
sectors in the Sector Count field of the Initial/Default Entry in
the "El Torito" Boot Catalog, instead of blithely writing 1 (!!)
into the Sector Count field.  Ditto the Section Entries.

Remove last remnants of cd9660's unsupported boot-load-size option.

Really use cd9660's boot-load-segment argument.

Change the boot images list from a LIST to a TAILQ.

Re-implement CD9660_BLOCKS() with howmany().

Introduce ELTORITO_DPRINTF and some debug messages.

Zero memory malloc'd in the El Torito code.

Revise some debugging outputs.

Insert a new boot-image on the boot-images list after the last
boot-image for the same architecture.  It makes a (trivial) functional
difference.

Miscellaneous cosmetic changes.  Remove useless variable-assignment.
2005-10-30 06:45:46 +00:00
dyoung b894baa422 boot-load-size, the number of load sectors for the boot image, is
not yet, and will not be, supported.
2005-10-30 03:52:03 +00:00
dyoung 397d1928f2 Cosmetic: add temporary variables for lengthy, repeated clauses
like 'default_entry->entry_data.IE'.  KNF.
2005-10-30 03:50:54 +00:00
dyoung f112f0b6d9 Remove invisible whitespace at ends of lines that disrupted my
speedy cursor-movement habits in vi.
2005-10-30 03:10:28 +00:00
dyoung d4d99b79c1 The system type mac68k is also allowed.
XXX Is that correct?
2005-10-28 21:55:18 +00:00
dyoung c286f15e25 Correct strcmp(3) usage (expect equal -> 0). 2005-10-28 21:54:21 +00:00
dyoung 21326b0d23 Synchronize documentation with utility. 2005-10-28 21:52:36 +00:00
dyoung 33c7871577 Use LIST_ macros instead of accessing list structure members lh_first
and le_next directly.
2005-10-28 21:51:35 +00:00
dyoung 689c61f61d Overhaul makefs -t cd9660.
Functional: Do not add a missing period or a version number to
            directories, since that doesn't fit the standard (thanks
            Daniel Watt).

            Add RRIP PX records (POSIX meta-information) to '.'
            and '..' entries.  Quiets kernel complaint, when we
            mount a cd9660 filesystem, that there is a missing PX
            entry.

Cosmetic: Reduce height of staircases.  Remove an unused member
          from struct _cd9660node.  Extract a subroutine.  KNF.

          Use a TAILQ macros for lists of both SUSP/RRIP attributes
          and directory entries.

XXX
XXX The new RRIP PX entries are not quite right.
XXX
2005-10-25 02:22:04 +00:00
thorpej 327a57156c Use the real field name (d_fileno instead of d_ino). 2005-10-23 16:12:02 +00:00
chs 6c50e54c82 avoid the need for a bogus initializer. 2005-10-08 03:21:17 +00:00
dyoung 3b0eb50995 Cosmetic: change to a standard idiom, *(x++) --> *x++. Flag some
places needing bounds-checking with XXX.  Fix indendation.
2005-09-11 22:03:48 +00:00
dyoung 62e9fd6510 By default, do not omit the trailing period from ISO9660 filenames
unless given the option '-o omit-trailing-period'.  Also, fix a
logic error so that makefs obeys option '-o omit-trailing-period'
when it is given.
2005-09-11 22:01:44 +00:00
wiz 3595891ed9 Remove unnecessary keeps (Bk/Ek). Sort options. Various minor fixes.
Bump date.
2005-09-09 22:23:49 +00:00
kent ed574610ee fix compilatio problems on LP64 2005-08-20 15:00:27 +00:00
christos c4ee9f6d2e 64 bit inode changes 2005-08-19 02:07:18 +00:00
dyoung 54d7d8be9a Remove extraneous #PKG_DEVELOPER=1 line that snuck in with the last
commit.  (Thanks Masao Uebayashi.)
2005-08-19 01:26:59 +00:00
dyoung 2f96ceba5c Change from malloc/strcpy idiom to strdup.
Revamp err, errx, warn, warnx usage.

Misc. cosmetic tweaks.

Make -o bootimage=sysname;filename expect NetBSD architecture names
(x86 -> i386; mac -> {macppc, mac68k}; ppc -> powerpc) for sysname.
2005-08-19 01:24:21 +00:00
dyoung c3f075faf3 Cosmetic: alphabetize SRCS. Start a new line on each change of
leading letter.
2005-08-19 01:09:54 +00:00
he 5d94f47ecb Move local variable declaration to start of block (also start of function).
Fixes build problem for vax.
2005-08-15 06:41:06 +00:00
fvdl 92be7f4643 Fix some wrapping lines. 2005-08-13 17:50:59 +00:00
fvdl 65b1705e76 Add nbtool_config.h include, fixing the tool compile on some platforms. 2005-08-13 17:46:07 +00:00
fvdl 36825d8853 Comment out some currently unimplemented options, and add a few descriptions
for others (from Daniel Watt).
2005-08-13 02:03:48 +00:00
fvdl 3550dc9861 cd9660 support. Written by Daniel Watt, Walter Deignan, Ryan Gabrys,
Alan Perez-Rathke and Ram Vedam.

Prototyping, KNF, WARNS=3 by me.

Note that this is marked experimental for now. It works well enough to
make NetBSD/i386 bootable images, but does need more work.
2005-08-13 01:53:01 +00:00
fvdl 046051d487 Fix a sign warning for WARNS=3. 2005-08-13 01:49:35 +00:00
lukem 1527bc4c2a Fix a typo in the description of -f. Noted by Jukka Salmi in PR 30713.
Add some missing punctuation.
2005-07-11 00:25:08 +00:00