Aren
/
NetBSD
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Fix a bug in cd9660_sort_nodes, which tried to insert `next' before 

`node' on a tail-queue, when `node' wasn't on the tail-queue.
Sometimes this led to a segfault.  Insert before `cn', since that
is the intention.  Closes PR 32194. Thanks, Jeff Rizzo, for reporting
this bug.
This commit is contained in:
dyoung 2005-11-30 00:26:11 +00:00
parent b09859311d
commit 5138e74947
1 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
usr.sbin/makefs/cd9660.c
View File

@ -1,4 +1,4 @@
/* $NetBSD: cd9660.c,v 1.10 2005/10/31 23:19:06 dyoung Exp $ */
/* $NetBSD: cd9660.c,v 1.11 2005/11/30 00:26:11 dyoung Exp $ */
/*
* Copyright (c) 2005 Daniel Watt, Walter Deignan, Ryan Gabrys, Alan
@ -101,7 +101,7 @@
#include <sys/cdefs.h>
#if defined(__RCSID) && !defined(__lint)
__RCSID("$NetBSD: cd9660.c,v 1.10 2005/10/31 23:19:06 dyoung Exp $");
__RCSID("$NetBSD: cd9660.c,v 1.11 2005/11/30 00:26:11 dyoung Exp $");
#endif /* !__lint */
#include <string.h>
@ -1197,7 +1197,7 @@ cd9660_sort_nodes(cd9660node *node)
cn->isoDirRecord->name) >= 0)
continue;
TAILQ_REMOVE(&node->cn_children, next, cn_next_child);
TAILQ_INSERT_BEFORE(node, next, cn_next_child);
TAILQ_INSERT_BEFORE(cn, next, cn_next_child);
break;
}
} while (cn != NULL);