Commit Graph

144555 Commits

Author SHA1 Message Date
kardel
589ea6e802 resource leak (fd/mem): close stream when errors occur (Coverity NetBSD Scan CID 2054) 2006-03-18 08:57:25 +00:00
dsl
df7e187ccb Appease Coverty CID 7449. Avoid close(-1) in error path. 2006-03-18 08:36:50 +00:00
kardel
862343544d resolve CID 808 for the general case (code didn't trigger it - constant strings were supplied ) 2006-03-18 08:09:03 +00:00
tsutsui
969544860e Don't put .reginfo into .bss but prepare an independent section for it
so that new ld(1) no longer dies on link as PR/33011.

Still ld(1) coredump problem should be fixed, IMO.
2006-03-18 07:29:53 +00:00
simonb
6c79cda5ae Coverity CID 2466 - Fix a GCC uninitialised variable warning in a way
that (hopefully!) keeps coverity happy too.
2006-03-18 07:27:50 +00:00
christos
bb7bab2df4 Coverity CID 877: Prevent NULL deref. 2006-03-18 07:24:40 +00:00
christos
c8a3069e94 Coverity CID 1484: Static buffer overrun. 2006-03-18 07:23:07 +00:00
christos
3cf8c179a3 Coverity CID 1763: Plug memory leak. 2006-03-18 07:09:08 +00:00
christos
e889898c95 Coverity CID 1766: Plug memory leak. 2006-03-18 07:02:16 +00:00
christos
f3ffb9c969 Coverity CID 1760: Plug memory leak. 2006-03-18 06:54:46 +00:00
christos
4d7c6251da Coverity CID 1228: protect against calling close with negative value. 2006-03-18 06:29:21 +00:00
christos
dcfc467f4d Coverity CID 872: Possible NULL deref. 2006-03-18 06:24:26 +00:00
rumble
43d45c06c6 Note that for asprintf and vasprintf it is more portable to check for
a -1 return, rather than ret being set to NULL on error.

From Otto Moerbeek.
2006-03-18 05:46:04 +00:00
christos
ee17e957e3 Coverity CID 343: Rework code so that we don't write after the end of the
array. The end effect is the same though.
2006-03-18 05:43:47 +00:00
christos
2ed09657c9 Coverity CID 345: Add missing free's. 2006-03-18 05:40:28 +00:00
christos
eb903308f2 Coverity CID 1559: Fix memory leak. 2006-03-18 05:33:31 +00:00
christos
3e359756c9 Coverity CID 620: Remove dead code. 2006-03-18 05:25:56 +00:00
christos
f6828859fa Coverity CID 890: Possible NULL pointer deref. 2006-03-18 05:23:08 +00:00
christos
169a269417 Coverity CID 1329: Possible NULL deref. 2006-03-18 05:17:36 +00:00
rtr
0c0f6ae5dc don't access out of bounds element of static alloc array.
found by Coverity, CID 1519 / Run 5

XXX possible that intention was to start with i = 0.
2006-03-18 05:16:46 +00:00
ginsbach
f127f217fb Fix Coverity CID 1863, 1864; resource leak, bp not freed when !okname()
before function return and/or bp overwritten by malloc().
2006-03-18 04:44:49 +00:00
christos
f5b7b11e49 Coverity CID 346: Double free. 2006-03-18 04:41:57 +00:00
christos
a7e5a4a743 Coverity CID 347: remove dead code. 2006-03-18 04:39:50 +00:00
christos
dee21a2f06 Coverity CID 586: Remove dead code. 2006-03-18 04:34:41 +00:00
elad
6dceae8a70 Ditch the ugly hardcoded value and do proper bounds checking.
Addresses CID 1417, found by Coverity.

Hi Darren! is this code maintained?
2006-03-18 04:12:52 +00:00
christos
06b02ffc92 Coverity CID 1284: Handle -1 return from open(2) 2006-03-18 03:49:37 +00:00
christos
f5b784887f Coverity CID 1462: Static buffer overrun; off by 2. 2006-03-18 03:45:34 +00:00
christos
16fbed8bd1 Coverity CID 1616: Memory leak. 2006-03-18 03:43:13 +00:00
ginsbach
ccae083c7b Fix Coverity CID 1248, negative return from read() passed() to write()
as a large unsigned value.
2006-03-18 03:40:51 +00:00
christos
fd8155f293 Coverity CID 1617: Memory leak 2006-03-18 03:39:57 +00:00
christos
67c67fc5bf Coverity CID 2059: Memory leak. 2006-03-18 03:35:41 +00:00
elad
77e1c3c1fc Fix off-by-one, found by Coverity. CID 1466. 2006-03-18 02:35:47 +00:00
matt
ba8a81077b Fix some double frees / missing frees / use after freed all
relating to _rtld_load_object.  Fix Coverity CID 2601, 2600.
2006-03-18 02:34:30 +00:00
elad
3af85b1067 Fix off-by-one found by Coverity, CID 1516. 2006-03-18 02:15:03 +00:00
elad
d8af4d8962 Change MAX_BLOCKS for b_prop to MAX_PROPS, as it probably should've been.
Fixes overrun found by Coverity, CID 1550.
2006-03-18 02:06:38 +00:00
abs
a3edf3e145 If none of the boarding parties are set do not fall off the end of the
list. Addresses Coverity CID 1507. Also put pointers before shorts in
a struct rather than mixing them up
2006-03-18 01:43:52 +00:00
dogcow
de119fc4bd in VNDIOCGET, make sure there's a valid lwp. coverity CID 837. 2006-03-18 01:13:24 +00:00
peter
c8593a1a3c Wrap long lines. 2006-03-18 00:35:02 +00:00
peter
dfd65180e1 Don't try to dereference pw when it's NULL.
Fixes Coverity CID 900.
2006-03-18 00:32:34 +00:00
kardel
9bccbf4462 Coverity fixes:
CID
687	missing block
988	null pointer deref on shutdown (on open failure - introduced by
	change of contract in ntp_refclock.c)
989	null pointer for private data (could not happen - safeguard anyway)
1513	off by one
2410	misplaced null pointer test
2006-03-18 00:30:30 +00:00
peter
f35a71c317 Update version, maintainer and responsible for pf entry.
Prompted by Hubert Feyrer.
2006-03-18 00:26:32 +00:00
peter
6dcaf25d17 Free allocated space upon failure.
Fixes Coverity CID 1661.
2006-03-18 00:14:50 +00:00
peter
c75c0a8549 Change a return to "goto out" so that fclose will be called.
Fixes Coverity CID 1881.
2006-03-18 00:12:02 +00:00
peter
96b1a913a5 Call fts_close() at the end of rm_tree().
Fixes Coverity CID 1670.
2006-03-17 23:55:42 +00:00
tls
2ebe53e4ac Add one more buffer pool, for 512-byte buffers. On the one hand, most
systems will never, ever need this -- because they use 8k/1k or even,
these days, 16k/2k or 32k/4k filesystems.  On the other hand, when you
do need this, you *really* need it: on anoncvs.netbsd.org, for instance,
where /tmp is 4k/512 and the filesystem contains tens or even hundreds
of thousands of single-frag directories, this essentially doubles the
efficiency of the allocator.  Since the overhead of keeping one extra
pool around is minimal, just add it by default.
2006-03-17 23:43:37 +00:00
abs
e0d5463807 add more "ifdef notdef" around unused sections - addresses Coverity CID 564 2006-03-17 23:36:38 +00:00
abs
b4f3ebd201 Add a missing bp->b_score not null check - addresses Coverity CID 1003 2006-03-17 23:34:37 +00:00
rpaulo
7122043ef9 0 > len ==> len < 0 2006-03-17 23:29:20 +00:00
christos
5a57baa413 don't use MALLOC with a non-constant size; use malloc instead. 2006-03-17 23:29:07 +00:00
christos
ee3808b74f prevent using MALLOC when size is not const. 2006-03-17 23:27:12 +00:00