Commit Graph

122 Commits

Author SHA1 Message Date
dholland
165c915b22 Fix two serious string-handling bugs (one exploitable, one probably
exploitable) and also add proper checking/paranoia in several other
places.
2009-06-29 23:05:33 +00:00
dholland
b8c355d789 a bit more const 2009-06-07 21:04:54 +00:00
dholland
a7a3b831c7 sprinkle some more const 2009-06-07 20:31:10 +00:00
dholland
8d5216e80d remove unnecessary casts 2009-06-07 20:25:38 +00:00
dholland
907fca1b3e sprintf -> snprintf, plus some use of strlcpy/strlcat where appropriate
XXX: there's still one sprintf left which will take some hacking to expunge.
2009-06-07 20:13:18 +00:00
dholland
1fa8a9a633 ANSIfy function declarations. All object file diffs inspected. 2009-06-07 18:30:39 +00:00
ginsbach
37a52c5f7b Change getdate() to getdatestr() since the former maybe present on systems
supporting X/Open System Interfaces Extension (XSI) getdate() in <time.h>.
This prevents a function prototype conflict.
2009-05-06 02:59:12 +00:00
tnn
f341bbffe8 use %zu to print size_t 2009-01-18 13:30:33 +00:00
lukem
c6144e484f fix -Wsign-compare issues 2009-01-18 00:24:29 +00:00
gmcgarry
3c9a95916d Wrap compiler-specific flags with HAVE_GCC and HAVE_PCC as necessary. Add a few flags for PCC. 2008-08-29 00:02:21 +00:00
martin
ce099b4099 Remove clause 3 and 4 from TNF licenses 2008-04-28 20:22:51 +00:00
dholland
3c439f438f Make hack build with WARNS=4. 2008-01-28 06:55:41 +00:00
perry
8b0f9554ff convert __attribute__s to applicable cdefs.h macros 2007-12-15 19:44:37 +00:00
chuck
f90603d08a Update my previous commit to better match the original code, including
the check for 'bs'...   my previous commit should have included the
following text:
  fixes problem introduced in 1.13 where the setting of "BC" (backspace char)
  was left to libterm rather than being done by hack itself.  the problem
  with this was that hack was directly setting BC to \b if there was no
  "bc" in the termcap entry, but libterm does not do this.   this resulted in
  the xputs(BC) calls in nocmov() and backsp() incorrectly doing nothing, thus
  messing up the display.  added new var BC_BS to provide the old behavior
  for nocmov() and backsp().
2007-01-17 02:35:28 +00:00
chuck
bfec35be7a mrg's changes in 1.13 broke hack's display code. 2007-01-17 02:12:19 +00:00
wiz
6919c6578c s/independant/independent/, from Zafer. 2006-11-24 22:04:21 +00:00
christos
1665d5e960 fix spelling of accommodate; from Zapher. 2006-11-24 19:46:58 +00:00
christos
a108a3f479 Coverity CID 3382: Fix memory leak. 2006-05-13 22:45:11 +00:00
christos
4b679b2a7f Coverity CID 3383: Fix memory leak. 2006-05-13 22:43:02 +00:00
mrg
8e969ac070 UC, PC and BC are provided my libtermcap, don't duplicate them. 2006-05-11 00:18:31 +00:00
christos
1ce9f4326d Coverity CID 3032: Prevent double free: Next to the call of page_more()
there is a comment saying /* does fclose */, but the next line calls
fclose(fp);. Go figure.
2006-04-24 20:08:54 +00:00
christos
8710461ab4 Coverity CID 2791: Fix file pointer leak. 2006-04-02 00:08:12 +00:00
jnemeth
995d4b331f Coverity CID 1327: check for error return 2006-03-30 01:32:27 +00:00
jnemeth
a3fb5aa745 Bah! Compare, don't assign! 2006-03-30 01:31:13 +00:00
jnemeth
dce307414d Coverity CID 1328: check for error return 2006-03-30 01:28:46 +00:00
jnemeth
f413c2ba58 Coverity CID 1326: check for error return 2006-03-30 01:25:52 +00:00
jnemeth
db7b70f433 Fix Coverity issue 891 -- FORWARD_NULL.
Approved by christos@.
2006-03-29 01:21:07 +00:00
jnemeth
83f277c49a Fix Coverity issues 2366 and 2365 -- REVERSE_INULL.
Approved by Christos@.
2006-03-29 01:19:51 +00:00
jnemeth
2ad8d2c6cd Fix Coverity issue 2584 -- USE_AFTER_FREE and issue 889 -- FORWARD_NULL.
Approved by christos@.
2006-03-29 01:18:39 +00:00
simonb
feaaa5ed4c Change DPADD from LIBTERM (which doesn't exist) and LIBCOMPAT (which it
doesn't use) to LIBTERMCAP (which it does use).
2006-02-25 11:56:51 +00:00
wiz
d9f5a9df01 Use standard AUTHORS section header. From YOMURA Masanori in private mail
Sort sections if necessary. Use more/better markup.
2005-09-15 02:09:41 +00:00
dsl
49f7d8a9b1 Add (unsigned char) cast to ctype functions 2004-11-05 21:30:31 +00:00
wiz
2eabcd5e18 Grammar fix, from ray at raylai org via jmc@openbsd. 2004-06-01 10:10:06 +00:00
snj
3eaff3a9c8 s/feal/feel/ 2004-03-28 22:43:03 +00:00
snj
f1710feaa1 s/venomenous/venomous/ 2004-03-28 22:42:39 +00:00
jsm
cb5fd8342e Remove uses of __P. 2004-01-27 20:30:28 +00:00
jsm
c35cdefd90 Refer to 'O' rather than 'o' as command to set options. Bug reported
by Christian Garbs <debian@cgarbs.de> in Debian bug 191452.
2004-01-01 16:02:51 +00:00
lukem
e606e2dcb2 Improve how various "simple" host tools are built and invoked. 2003-11-16 14:14:18 +00:00
lukem
130ab7336b Rework how MAKEVERBOSE operates:
*	Don't bother prefixing commands with a line of  ${_MKCMD}\
	and instead rely upon "make -s".  This is less intrusive on
	all the Makefiles than the former.  Idea from David Laight.

    *	Rename the variables use to print messages.  The scheme now is:
	    _MKMSG_FOO		Run  _MKMSG 'foo'
	    _MKTARGET_FOO	Run  _MKMSG_FOO ${.TARGET}
	From discussion with Alistair Crooks.
2003-10-21 10:01:19 +00:00
lukem
ddff99b7f4 rework to use the newer _MKMSGCREATE (et al) macros 2003-10-19 04:45:01 +00:00
lukem
2b8c8463a6 Support MAKEVERBOSE. (Some host tools still generate verbose runtime messages) 2003-10-19 01:01:44 +00:00
agc
e5aeb4ea46 Move UCB-licensed code from 4-clause to 3-clause licence.
Patches provided by Joel Baker in PR 22269, verified by myself.
2003-08-07 09:36:50 +00:00
lukem
a93ea220fc Rework how dependency generation is performed:
* DPSRCS contains extra dependencies, but is _NOT_ added to CLEANFILES.
  This is a change of behaviour.  If a Makefile wants the clean semantics
  it must specifically append to CLEANFILES.
  Resolves PR toolchain/5204.

* To recap: .d (depend) files are generated for all files in SRCS and DPSRCS
  that have a suffix of: .c .m .s .S .C .cc .cpp .cxx

* If YHEADER is set, automatically add the .y->.h to DPSRCS & CLEANFILES

* Ensure that ${OBJS} ${POBJS} ${LOBJS} ${SOBJS} *.d  depend upon ${DPSRCS}

* Deprecate the (short lived) DEPENDSRCS


Update the various Makefiles to these new semantics; generally either
adding to CLEANFILES (because DPSRCS doesn't do that anymore), or replacing
specific .o dependencies with DPSRCS entries.

Tested with "make -j 8 distribution" and "make distribution".
2003-08-01 17:03:41 +00:00
lukem
403ce9dc0c simplify and use ${DEPENDSRCS} as a target as appropriate 2003-07-31 13:54:30 +00:00
wiz
03721033c3 Quote question mark. 2003-06-27 22:48:35 +00:00
jsm
1c7f94e505 Hack is now BSD-licensed. Thanks to Andries Brouwer, Jay Fenlason and
CWI <http://www.cwi.nl/~aeb/games/hack/hack.html>.  Via OpenBSD.
Addresses part of PR bin/5850.
2003-04-02 18:36:33 +00:00
wiz
990562bfef .Nm does not need a dummy argument ("") before punctuation or
for correct formatting of the SYNOPSIS any longer.
2003-02-25 10:34:36 +00:00
pooka
b49604cb5c fix confusion between east and west for y,u,b, and n.
from Soren Jacobsen in misc/19397
2002-12-15 22:02:52 +00:00
wiz
c91d8d6b9b Lots of minor fixes resulting from reading these man pages in detail. 2002-09-26 18:31:58 +00:00
wiz
0d22e30cd0 New sentences begin on new lines.
Patch from Richard Elz, slightly improved by yours truly.
2002-09-26 16:12:39 +00:00