Commit Graph

45 Commits

Author SHA1 Message Date
matt335672
d722ffe357 Update smartcard code to use new UTF-8 calls 2023-10-23 14:19:49 +01:00
matt335672
e138c1a601 Update comments in smartcard code
Most of the Microsoft RDP documentation describes PDUs on-the-wire.
However, [MS-RDPESC] doesn't do this. It uses DCE IDL to describe the
contents of the PDUs sent over the File System Virtual Channel.

Ideally we'd use an IDL compiler to generate the interfaces in
[MS-RDPESC]. We don't have one though, so all PDUs are read and written
with the low-level streaming routines. It's not clear in the existing
code how IDL is mapped down to this level.

This commit updates the smartcard code with comments which will enable
maintainers to better understand the IDL-to-streaming mappings.
2023-09-25 16:13:00 +01:00
Jay Sorg
054c78d568 chansrv: don't free item on stack 2023-03-24 16:33:16 -07:00
Zhipeng Xue
fbb3b9cef9 Fix potential null dereference 2023-03-05 13:38:43 +08:00
matt335672
5f030a95b7 Don't try to listen on the scard socket if it isn't there
If the scard local socket can't be created, there's no point
in trying to listen on it. This will just fill the chansrv log
file with errors.
2023-01-16 13:41:18 +00:00
matt335672
89c873e4aa Set permissions on pcsc socket dir to owner only
There is no reason for any user other than the current one to be able
to communicate with the remote smartcard.
2022-12-09 11:55:31 +00:00
a1346054
7fe18cc1c0
fix typos 2022-09-03 02:01:48 +00:00
matt335672
0a1a8f40e5 Moved a lot of string funcs to string_calls module 2020-12-22 11:57:24 +00:00
Alexandre Quesnel
0c61a15fc5 Migrating logging to LOG() and LOG_DEVEL() in sesman/* 2020-11-30 00:36:20 +00:00
matt335672
7ef01f7b0c Address memory allocation overflow security issues 2020-04-23 17:29:06 +01:00
Pavel Roskin
6ed4c969f4 Eliminate APP_CC and DEFAULT_CC 2017-03-14 00:21:48 -07:00
Pavel Roskin
b2d3dcf169 Include config_ac.h from all source files 2017-03-04 00:52:34 -08:00
Pavel Roskin
d1efb0d5ba Fix signed to unsigned comparisons reported by g++ 6.1.0 2016-07-08 04:29:51 +00:00
Pavel Roskin
5829323ad8 Use g_new or g_new0 when C++ compiler would complain about implicit cast 2016-07-08 04:29:49 +00:00
Pavel Roskin
e65bd6b7d7 Fix more format warnings 2016-04-21 21:21:17 -07:00
Laxmikant Rashinkar
3bb31876e7 coverity: fixed resolution leak issues 2014-07-19 11:56:00 -07:00
Jay Sorg
9f8d369747 chansrv: smartcard, fix for SCardControl, SCardTransmit 2013-12-30 13:41:38 -08:00
Jay Sorg
052153274b chansrv: mstsc SCardConnect fixes 2013-12-24 11:16:57 -08:00
Jay Sorg
38eba8aac1 chansrv: work on smartcard, mstsc and 64 bit client 2013-12-23 00:07:24 -08:00
Jay Sorg
1483c75911 chansrv: work on smartcard stability, handle multi threaded calls, app crashes, etc 2013-12-21 19:16:08 -08:00
Jay Sorg
b34cbe8a3e chansrv: got \?PnP?\Notification working, handle pcsc exit without cleanup 2013-12-19 14:05:35 -08:00
Jay Sorg
cd2eca5573 chansrv: some minor smartcard changes 2013-12-11 13:29:15 -08:00
Jay Sorg
3069922500 chansrv: work on smartcard 2013-12-11 03:22:00 -08:00
Jay Sorg
ef51e44119 chansrv: handle smartcard session reconnect and some logging changes 2013-12-07 17:57:35 -08:00
Jay Sorg
de9fa3d5fa chansrv: smartcard, more work on support for MSTSC 2013-12-05 02:22:41 -08:00
Jay Sorg
f265c14499 chansrv: smartcard, work on getting MSTSC working 2013-12-04 15:40:55 -08:00
Jay Sorg
3d4fbb883a chansrv: work on getting MSTSC smartcard working 2013-11-29 21:28:13 -08:00
Jay Sorg
2943650685 chansrv: reduce smart card debug logging 2013-10-19 16:11:14 -07:00
Jay Sorg
62bdacda9b chansrv: work on smartcard 2013-10-19 15:36:57 -07:00
Jay Sorg
b69c144c7d chansrv: work on smartcard 2013-10-18 20:56:28 -07:00
Jay Sorg
a695886f81 chansrv: work on smartcard 2013-10-16 19:32:53 -07:00
Laxmikant Rashinkar
5e005bf26c Merge branch 'master' of github.com:neutrinolabs/xrdp 2013-09-25 18:54:16 -07:00
Laxmikant Rashinkar
52fb1f9854 scard: added more messages 2013-09-25 18:54:05 -07:00
Jay Sorg
675e1b86c4 chansrv: work on smartcard 2013-09-24 11:17:50 -07:00
Jay Sorg
9263b22cb2 chansrv: work on smartcard 2013-09-19 01:03:20 -07:00
Jay Sorg
d926a5becd chansrv: work on smartcard 2013-09-16 00:16:21 -07:00
Laxmikant Rashinkar
0ef89c02ab scard: changed the way we store and pass context 2013-09-15 15:20:16 -07:00
Jay Sorg
edf483ecb6 chansrv: work on smartcard 2013-09-14 12:57:34 -07:00
Laxmikant Rashinkar
188ca68adb scard: added GetStatusChange() msg 2013-09-11 19:42:42 -07:00
Jay Sorg
2d112bac8f chansrv: work on smart card 2013-09-09 12:30:58 -07:00
Jay Sorg
a9f37229ac chansrv: work on smartcard 2013-09-08 14:22:53 -07:00
Jay Sorg
e602a28d5c common: transport aware when app is terminating 2013-08-17 13:32:53 -07:00
Laxmikant Rashinkar
6381941c78 FUSE: changed architecture to use opendir/readdir instead of just readdir 2013-08-11 18:06:39 -07:00
Jay Sorg
8b48e2274e chansrv: work on smartcard 2013-08-05 20:16:18 -07:00
Jay Sorg
e427113fa8 chansrv: work on smartcard redir 2013-08-05 01:10:57 -07:00