Commit Graph

4474 Commits

Author SHA1 Message Date
Jay Sorg
433c05eb36 fix valgrind warning on font 2023-09-25 20:57:07 -07:00
Jay Sorg
bfdcdb0082 posix shm, can not unmap shmem_ptr until encoder is done with it 2023-09-09 14:18:52 -07:00
matt335672
def567c2e0
Merge pull request #2792 from metalefty/login_mode_log
Record login state as string
2023-09-08 10:22:35 +01:00
Koichiro Iwao
16d45a8f4f Record login state as string
Closes: #2790
2023-09-08 16:58:35 +09:00
matt335672
98f45baff3
Merge pull request #2787 from firewave/unusedVariable
fixed Cppcheck `unusedVariable` warnings
2023-09-05 16:43:19 +01:00
firewave
27d34e784d fixed Cppcheck unusedVariable warnings 2023-09-04 23:47:56 +02:00
matt335672
deb8a317ba
Merge pull request #2780 from matt335672/update_pam_configs
Add GNOME/KDE keyring support for Debian/Arch
2023-09-04 10:16:42 +01:00
matt335672
d8446c263f
Merge pull request #2783 from metalefty/waitforx-build
waitforx: fix build
2023-09-04 10:14:07 +01:00
matt335672
aae4f33602
Merge pull request #2782 from firewave/z3
Cppcheck 2.8 removed the dependency on z3
2023-09-04 10:00:44 +01:00
Koichiro Iwao
a978b58f11 waitforx: fix build
--- waitforx ---
CCLD     waitforx
ld: error: unable to find library -lX11
ld: error: unable to find library -lXrandr
cc: error: linker command failed with exit code 1 (use -v to see invocation)
*** [waitforx] Error code 1
2023-09-04 17:33:27 +09:00
firewave
c37ce6fa47 Cppcheck 2.8 removed the dependency on z3 2023-09-04 10:01:09 +02:00
matt335672
8fb5bd9096 Add keyring support for Debian and Arch
Adds optional calls to GNOME and KDE keyrings for Debian and Arch.

Also upstreams a current Debian patch to call pam_env.so
2023-08-30 12:37:44 +01:00
metalefty
a111a0fdfe
Merge pull request from GHSA-f489-557v-47jq
Check auth_start_session() result
2023-08-24 10:14:48 +09:00
matt335672
25a1fab5b6 Check auth_start_session() result 2023-08-19 13:35:26 +01:00
Jay Sorg
4b1482b5df move to posix shm 2023-08-13 13:08:16 -07:00
matt335672
67c297d273
Merge pull request #2766 from matt335672/clipboard_updates
Clipboard updates
2023-08-09 14:39:36 +01:00
matt335672
84ae372a58 clipboard: Fix TODO action in clipboard_common.h
Use the official Windows clipboard format names where appropriate

Replace g_file_format_id with g_file_group_descriptor_format_id
as the latter name is more descriptive of what is described in
[MS-ECLIP]
2023-08-07 15:11:04 +01:00
matt335672
8eed7a395e clipboard: Only advertise text to X11 clients if it is available 2023-08-07 15:11:04 +01:00
matt335672
45ca9fe098 clipboard: Tell the X11 client if a selection is unavailable 2023-08-07 14:45:11 +01:00
matt335672
9bbb2ec68f
Merge pull request #2759 from matt335672/update_issue_template
Clarify RHEL support options
2023-08-02 12:12:54 +01:00
matt335672
1d6997001e
Merge pull request #2697 from iskunk/new-3
Add syscall filtering to xrdp systemd unit
2023-07-31 16:25:07 +01:00
matt335672
90c80ce855 Exclude RHEL from supported operating systems 2023-07-31 15:11:37 +01:00
matt335672
463cd8a543
Merge pull request #2719 from matt335672/log_xrdp_termination_signal
Log xrdp termination signals
2023-07-31 11:24:20 +01:00
matt335672
ae43cee4b3
Merge pull request #2737 from matt335672/bump_cppcheck_to_2_11
Bump cppcheck to v2.11
2023-06-23 15:41:23 +01:00
matt335672
1ac6206af6 Use all available CPUs to build cppcheck 2023-06-23 15:30:24 +01:00
matt335672
d77b0b3b9d Bump cppcheck to v2.11
This fixes the following errors:-

sesman/tools/authtest.c:64:14: error: syntax error [syntaxError]
    g_printf("xrdp auth module tester v" PACKAGE_VERSION "\n");
             ^
sesman/tools/sesrun.c:165:14: error: syntax error [syntaxError]
    g_printf("xrdp session starter v" PACKAGE_VERSION "\n");
             ^
vrplayer/decoder.h:35:12: error: There is an unknown macro here somewhere. Configuration is required. If slots is a macro then please configure it. [unknownMacro]
    public slots:
           ^
vrplayer/playaudio.h:45:12: error: There is an unknown macro here somewhere. Configuration is required. If slots is a macro then please configure it. [unknownMacro]
    public slots:
           ^
vrplayer/dlgabout.h:22:13: error: There is an unknown macro here somewhere. Configuration is required. If slots is a macro then please configure it. [unknownMacro]
    private slots:
            ^
vrplayer/playvideo.h:49:12: error: There is an unknown macro here somewhere. Configuration is required. If slots is a macro then please configure it. [unknownMacro]
    public slots:
           ^
Additionally, cppcheck now makes use of all available CPUs
2023-06-23 15:12:51 +01:00
metalefty
14b224f7ae
Merge pull request #2727 from metalefty/issue-template
Introduce Issue template
2023-06-13 19:15:33 +09:00
Koichiro IWAO
6e192995cb Tip is not allowed here anymore
https://docs.github.com/en/communities/using-templates-to-encourage-useful-issues-and-pull-requests/syntax-for-issue-forms
2023-06-13 09:50:25 +09:00
Koichiro IWAO
416615bfb5 Add field for desktop environment, backend, VM and anything else
in bug report template
2023-06-13 09:38:54 +09:00
matt335672
ce42e3e12d Replace g_strsignal() with g_sig2text()
This call provides a textual representation of a signal number, i.e.
SIGHUP is mapped to "SIGHUP"

Unit tests are also added.
2023-06-12 16:19:17 +01:00
Koichiro IWAO
afb34f23a4 Reword descriptions for the link to Q&A 2023-06-10 00:26:20 +09:00
Koichiro IWAO
07797866e3 Update bug report template 2023-06-10 00:07:01 +09:00
Koichiro IWAO
650dc032ce Add bug report template 2023-06-09 23:52:59 +09:00
Koichiro IWAO
5a02a3b3d9 Add issue template: links 2023-06-09 19:20:00 +09:00
Daniel Richard G
9bf78e4a80 Add syscall filtering to xrdp systemd unit 2023-06-09 03:33:52 -04:00
matt335672
cb9a697fa8 Log xrdp sub-processes which fail due to a signal 2023-06-08 16:32:24 +01:00
matt335672
0f32661056 Add g_strsignal() to string_calls module 2023-06-08 16:32:24 +01:00
matt335672
a2798fe9e9
Merge pull request #2715 from matt335672/c7_compile_error
Fix compile errors detected by the older gcc 4.8.5 compiler:-
2023-06-08 11:36:51 +01:00
matt335672
7cf9101407 Fix compile errors detected by the older gcc 4.8.5 compiler:-
sesexec.c: In function ‘main’:
sesexec.c:521:1: error: control reaches end of non-void function [-Werror=return-type]

sound.c: In function ‘process_pcm_message’:
sound.c:1123:21: error: ‘for’ loop initial declarations are only allowed in C99 mode
                     for (int i = 0; i < send_silence_times; i++)
                     ^
sound.c:1123:21: note: use option -std=c99 or -std=gnu99 to compile your code

These fixes are in line with our coding standard and have no functional change.
2023-06-07 20:21:54 +01:00
matt335672
3c98420517
Merge pull request #2713 from CynCeyd/devel
Included os_calls.h first in unit tests
2023-06-05 11:11:41 +01:00
CynCeyd
f4210a20ae Switched os_calls.h and test_common.h include order since HAVE_STDINT_H would get undefined by check.h. 2023-06-04 12:05:33 +02:00
jsorg71
dab1443e87
Merge pull request #2686 from matt335672/update_fifo_code
Re-work FIFO code
2023-06-01 22:29:59 -07:00
matt335672
07ac4c3eca
Merge pull request #2711 from matt335672/allow_long_strings_in_pam_env
Remove size limit for PAM environment variables
2023-06-01 15:33:44 +01:00
matt335672
c0f9c55de6 Remove size limit for PAM environment variables
The current logic in auth_set_env() for PAM environments only allows
environment variables to be around 256 characters in length.
2023-05-31 16:39:42 +01:00
metalefty
73b7bd5ebc
Merge pull request #2704 from neutrinolabs/security
Update SECURITY.md
2023-05-29 09:47:42 +09:00
metalefty
6853048a0c
Update SECURITY.md
Now vulnerability report form is open. Anyone who use GitHub can report vulnerabilities privately the form.
2023-05-28 23:45:56 +09:00
matt335672
05d1733950 Change chansrv to use common fifo code 2023-05-22 14:43:22 +01:00
matt335672
3d87d40d0a Modify xrdp encoder for new fifo interface 2023-05-22 14:43:22 +01:00
matt335672
d5684e0633 Add module tests for new fifo module 2023-05-22 14:43:22 +01:00
matt335672
ac65538a48 Re-implement fifo code
Following informal option testing, a more performant fifo
implementation has been chosen which makes fewer, larger
allocations, but which does not have bad edge-case performance

Clearing the contents of a fifo is a common operation which generally
involves freeing memory. Support has been added to the fifo interface
for doing this.
2023-05-22 14:43:22 +01:00