Commit Graph

2720 Commits

Author SHA1 Message Date
Koichiro IWAO
042c33a11c Switch the remaining 4 hex digit keymapfile to 8 hex 2016-10-24 15:19:23 +09:00
Koichiro IWAO
c654c86206 Switch to 8 hex digit keymapfile
as the value keyboardLayout is actually 32-bit unsigned integer.
See [MS-RDPBCGR] - v20160714 p.45.
2016-10-24 15:19:23 +09:00
metalefty
b79ad54bd3 Merge pull request #453 from itamarjp/devel
Add es_ES layout support #88
2016-10-24 09:34:02 +09:00
Pavel Roskin
b28a986071 Fix memory leak in xrdp-sesman on config reload 2016-10-21 20:15:50 +00:00
Pavel Roskin
dc60a80b86 Memory leak fix: keep X server path in the parameter list
g_cfg->xorg_params, g_cfg->vnc_params and g_cfg->rdp_params don't have
auto_free enabled, so removing an item from one of those lists won't free
its contents.

It's better not to change those lists, as they represent the actual
config file and could be reused. Instead, omit the 0th parameter (the
executable path) from copying to xserver_params.

Found by Valgrind.
2016-10-21 20:15:50 +00:00
Pavel Roskin
e17a56efb6 Call auth_end() exactly once in scp_v0_process()
As discovered by Valgrind, it wasn't called at all in case of a
successful session creation, which leaked memory.
2016-10-21 20:15:50 +00:00
Pavel Roskin
65ac8e758b Fix memory leak: free session data
Call scp_session_destroy() in the functions that call
scp_session_create() and nowhere else.

As found by Valgrind, the session data is not freed if the session is
created successfully.
2016-10-21 20:15:50 +00:00
Itamar Reis Peixoto
8bf28e45c4 Merge pull request #445 from proski/noextra
Avoid using non-standard Automake variables starting with "EXTRA"
2016-10-21 16:55:55 -02:00
Itamar Reis Peixoto
d4f350758b add km-040a.ini keyboard 2016-10-21 16:33:57 -02:00
Itamar Reis Peixoto
b70f372a87 add keymap-names.txt 2016-10-21 16:30:06 -02:00
Koichiro IWAO
6b589569ee buildx.sh: download tarballs using keepalive
Executing wget like

  wget http://example.com/file1 http://example.com/file2 ...

can do HTTP keepalive.

Quit calling wget with single file. Downloading multiple files in one
http connection is a little bit faster than executing wget more than
100 times. And parallelly execute two instances of wget to increase
download speed.
2016-10-21 17:14:48 +09:00
Koichiro IWAO
cf1a99b4e2 buildx.sh: simplify counting lines 2016-10-21 17:11:10 +09:00
Pavel Roskin
a370306f75 Get rid of EXTRA_LIBS, use variables with more specific names 2016-10-20 10:43:02 -07:00
Pavel Roskin
5c69f3cd57 Eliminate EXTRA_FLAGS, it's a poor name, use AM_LDFLAGS 2016-10-20 10:43:02 -07:00
Pavel Roskin
0422734fc7 Merge EXTRA_DEFINES and EXTRA_INCLUDES into AM_CPPFLAGS
AM_CPPFLAGS is a documented Automake variable for C preprocessor flags
that should not be overridden when compiling the package.

There is no need to have two additional variables that are ultimately
merged into AM_CPPFLAGS.

Their names are also confusing. EXTDA_DIST is a documented Automake
variable. Everything else that starts with "EXTRA" is not.
2016-10-20 10:43:02 -07:00
Koichiro IWAO
85e98d211a Update file-loc.txt 2016-10-20 16:05:43 +09:00
metalefty
0c4c52878a Merge pull request #444 from proski/trivial
Simple changes, mostly log messages and documentation
2016-10-20 15:52:25 +09:00
Pavel Roskin
6fef1e4eb5 Use const pointers in function arguments when possible 2016-10-17 08:54:07 -07:00
Pavel Roskin
bc868b96b1 Remove text2bool() from log.h, there is no such function 2016-10-17 08:54:07 -07:00
Pavel Roskin
09746fcebc Leave only one "autorun" in xrdp.ini, improve comment 2016-10-17 08:54:07 -07:00
Pavel Roskin
c3b99de739 Fix wrong comments in sesman config printing code 2016-10-17 08:54:07 -07:00
Pavel Roskin
bf08892622 Fix incorrect description of auth_userpass() return value 2016-10-17 08:54:07 -07:00
Pavel Roskin
a618d4f757 Don't use final newline in log calls, it's already appended 2016-10-17 08:54:07 -07:00
Pavel Roskin
424cef464b Log malloc errors with LOG_LEVEL_ERROR 2016-10-17 08:38:22 -07:00
Pavel Roskin
9ac592b218 Don't use term "missing" when using default files, it's too alarming
Also improve messages when non-absolute path is rejected.
2016-10-17 08:38:22 -07:00
Pavel Roskin
acdfc94511 Merge prog_std.txt into coding_style.md 2016-10-17 08:38:22 -07:00
metalefty
c9108242cd Merge pull request #434 from proski/buildx
Fixes for x11rdp build
2016-10-17 17:21:32 +09:00
Koichiro IWAO
ee3a38f93d xrdp: librfxcodc link fix
as same fix as done in 4a815d5 for libpainter
2016-10-13 14:07:53 +09:00
jsorg71
1a69dbe119 Merge pull request #435 from metalefty/update-submodules
Update xorgxrdp and librfxcodec
2016-10-12 00:58:19 -07:00
Pavel Roskin
bc5e166f13 Move libXdmcp above libxcb, libxcb can use it 2016-10-09 21:35:30 -07:00
Pavel Roskin
293d8b4b79 Add *.a to top .gitignore, add xorg/X11R7.6/.gitignore 2016-10-09 21:35:27 -07:00
Pavel Roskin
3cf67c684b buildx.sh: force forward patch, don't ask whether to revert 2016-10-09 21:35:23 -07:00
Koichiro IWAO
3bdce59160 librfxcodec=845ee8c 2016-10-09 00:07:55 +09:00
Koichiro IWAO
1f587945cf xorgxrdp=822e3b8 2016-10-09 00:06:26 +09:00
Pavel Roskin
6247a3afac buildx.sh: remove special case for python, it's not built anymore 2016-10-08 02:02:07 +00:00
Pavel Roskin
d602e71465 Change compilation order to resolve dependencies
With this change, buildx.sh succeeds on a system without pre-existing
X11 installation.
2016-10-08 02:02:07 +00:00
Pavel Roskin
b2bbaef640 buildx.sh: utilize all available CPUs when compiling 2016-10-08 02:02:07 +00:00
Pavel Roskin
8e7d12ff50 buildx.sh: "clean" is a constant string, not a semantic variable 2016-10-08 02:02:07 +00:00
Pavel Roskin
22c370a6a1 buildx.sh: use "mkdir -p" to create $PREFIX_DIR, don't retry
Improve messages about $PREFIX_DIR
2016-10-08 02:02:07 +00:00
metalefty
132cc10f75 Merge pull request #431 from metalefty/remove-python-from-x11rdp
X11rdp: remove python as it isn't really needed these days
2016-10-06 18:57:19 +09:00
Koichiro IWAO
1612730140 X11rdp: remove python as it isn't really needed these days
Closes #399.
2016-10-05 09:52:29 +09:00
Jay Sorg
b24f8d8fef remove a debug message 2016-10-03 20:34:12 -07:00
Jay Sorg
409878666f xrdp: handle 3 byte PDU 2016-10-03 20:05:14 -07:00
metalefty
f0c0976d1d Merge pull request #411 from proski/socket_close
Cleaning up bogus messages about closing "established" connections to NULL:NULL
2016-09-20 17:56:38 +09:00
metalefty
ba78399122 Merge pull request #417 from metalefty/apply-keyboard-options
Apply xkb options for x11rdp
2016-09-09 16:04:43 +09:00
Pavel Roskin
7d03d1a3e9 Fix outgoing connections on Mac OSX
connect() on an already established connection returns error with errno
set to EISCONN. Treat it as success.
2016-09-08 22:28:38 -07:00
Pavel Roskin
5465b8c85e Add socklen_t check with substitution, use socklen_t as needed 2016-09-08 20:26:19 -07:00
Pavel Roskin
49ae93130a Improve message about listening socket is a wrong state 2016-09-08 20:26:19 -07:00
Pavel Roskin
945833a94f Don't close socket in scp_process_start(), the caller closes it 2016-09-08 20:26:19 -07:00
Pavel Roskin
f7c27f05cf g_term_event is a wait object, not TCP socket, delete it correctly 2016-09-08 20:26:19 -07:00