mirrors/xrdp
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Improve portability

Browse Source 
- Use clearenv() if it exists
- Don't rely on <limits.h> being pulled in by <sys/param.h>
- Rename the DEFAULT_TYPE macro in sesrun.c.  This name appears to be
  used on Solaris. It's not a good choice.
This commit is contained in:
matt335672 2024-01-09 11:47:49 +00:00
parent a547a8b613
commit b80f07d2a7
3 changed files with 12 additions and 15 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

17
common/os_calls.c
View File

@ -95,16 +95,11 @@ struct sockaddr_hvs
#endif
#include "os_calls.h"
#include "limits.h"
#include "string_calls.h"
#include "log.h"
#include "xrdp_constants.h"
/* for clearenv() */
#if defined(_WIN32)
#else
extern char **environ;
#endif
#if defined(__linux__)
#include <linux/unistd.h>
#endif
@ -3446,14 +3441,16 @@ g_setpgid(int pid, int pgid)
void
g_clearenv(void)
{
#if defined(_WIN32)
#else
#if defined(BSD)
#if defined(HAVE_CLEARENV)
clearenv();
#elif defined(_WIN32)
#elif defined(BSD)
extern char **environ;
environ[0] = 0;
#else
extern char **environ;
environ = 0;
#endif
#endif
}
/*****************************************************************************/

2
configure.ac
View File

@ -211,7 +211,7 @@ AM_COND_IF([DEVEL_DEBUG],
AC_SEARCH_LIBS([setusercontext], [util])
# Define HAVE_XXXXX macros for some system functions
AC_CHECK_FUNCS([setusercontext getgrouplist])
AC_CHECK_FUNCS([setusercontext getgrouplist clearenv])
# The type used by getgrouplist() is the same type used by getgroups()
AC_TYPE_GETGROUPS

8
sesman/tools/sesrun.c
View File

@ -68,8 +68,8 @@
# define DEFAULT_BPP 32
#endif
#ifndef DEFAULT_TYPE
# define DEFAULT_TYPE "Xorg"
#ifndef DEFAULT_SESSION_TYPE
# define DEFAULT_SESSION_TYPE "Xorg"
#endif
/**
@ -176,7 +176,7 @@ usage(void)
g_printf(" -g <geometry> Default:%dx%d\n",
DEFAULT_WIDTH, DEFAULT_HEIGHT);
g_printf(" -b <bits-per-pixel> Default:%d\n", DEFAULT_BPP);
g_printf(" -t <type> Default:%s\n", DEFAULT_TYPE);
g_printf(" -t <type> Default:%s\n", DEFAULT_SESSION_TYPE);
g_printf(" -D <directory> Default: $HOME\n"
" -S <shell> Default: Defined window manager\n"
" -p <password> TESTING ONLY - DO NOT USE IN PRODUCTION\n"
@ -290,7 +290,7 @@ parse_program_args(int argc, char *argv[], struct session_params *sp,
sp->width = DEFAULT_WIDTH;
sp->height = DEFAULT_HEIGHT;
sp->bpp = DEFAULT_BPP;
(void)string_to_session_type(DEFAULT_TYPE, &sp->session_type);
(void)string_to_session_type(DEFAULT_SESSION_TYPE, &sp->session_type);
sp->directory = "";
sp->shell = "";