From 9cd634007f05eeb8fc13b40f87c38060c1f99dfd Mon Sep 17 00:00:00 2001 From: Jay Sorg Date: Mon, 9 Feb 2015 19:26:04 -0800 Subject: [PATCH] fix for case where shmget can return an shmid of zero --- xup/xup.c | 20 ++++++++++++++++++-- xup/xup.h | 1 + 2 files changed, 19 insertions(+), 2 deletions(-) diff --git a/xup/xup.c b/xup/xup.c index 830b0f12..8ddc079f 100644 --- a/xup/xup.c +++ b/xup/xup.c @@ -1135,7 +1135,7 @@ process_server_paint_rect_shmem(struct mod *mod, struct stream *s) if (flags == 0) /* screen */ { - if (mod->screen_shmem_id == 0) + if (mod->screen_shmem_id_mapped == 0) { mod->screen_shmem_id = shmem_id; mod->screen_shmem_pixels = g_shmat(mod->screen_shmem_id); @@ -1144,6 +1144,11 @@ process_server_paint_rect_shmem(struct mod *mod, struct stream *s) /* failed */ mod->screen_shmem_id = 0; mod->screen_shmem_pixels = 0; + mod->screen_shmem_id_mapped = 0; + } + else + { + mod->screen_shmem_id_mapped = 1; } } if (mod->screen_shmem_pixels != 0) @@ -1246,10 +1251,21 @@ process_server_paint_rect_shmem_ex(struct mod *amod, struct stream *s) bmpdata = 0; if (flags == 0) /* screen */ { - if (amod->screen_shmem_id == 0) + if (amod->screen_shmem_id_mapped == 0) { amod->screen_shmem_id = shmem_id; amod->screen_shmem_pixels = g_shmat(amod->screen_shmem_id); + if (amod->screen_shmem_pixels == (void*)-1) + { + /* failed */ + amod->screen_shmem_id = 0; + amod->screen_shmem_pixels = 0; + amod->screen_shmem_id_mapped = 0; + } + else + { + amod->screen_shmem_id_mapped = 1; + } } if (amod->screen_shmem_pixels != 0) { diff --git a/xup/xup.h b/xup/xup.h index e4bbdc15..3a569c7f 100644 --- a/xup/xup.h +++ b/xup/xup.h @@ -160,5 +160,6 @@ struct mod int shift_state; struct xrdp_client_info client_info; int screen_shmem_id; + int screen_shmem_id_mapped; /* boolean */ char *screen_shmem_pixels; };