From 7780fd4ccbc9c3f90c5b993dde46fb4d9cafa5ef Mon Sep 17 00:00:00 2001 From: matt335672 <30179339+matt335672@users.noreply.github.com> Date: Wed, 7 Dec 2022 10:03:24 +0000 Subject: [PATCH] CVE-2022-23484 Add check for RAIL window text size --- xrdp/xrdp_mm.c | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/xrdp/xrdp_mm.c b/xrdp/xrdp_mm.c index 42e99287..a50cad4a 100644 --- a/xrdp/xrdp_mm.c +++ b/xrdp/xrdp_mm.c @@ -925,6 +925,12 @@ xrdp_mm_process_rail_update_window_text(struct xrdp_mm *self, struct stream *s) g_memset(&rwso, 0, sizeof(rwso)); in_uint32_le(s, size); /* title size */ + if (size < 0 || !s_check_rem(s, size)) + { + LOG(LOG_LEVEL_ERROR, "%s : invalid window text size %d", + __func__, size); + return 1; + } rwso.title_info = g_new(char, size + 1); in_uint8a(s, rwso.title_info, size); rwso.title_info[size] = 0;