mirrors/xrdp
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

CVE-2022-23493

Browse Source 
Check chansrv channel ID on a channel close

Prevent OOB read if an invalid channel ID is sent.
This commit is contained in:
matt335672 2022-12-07 10:49:06 +00:00
parent 7780fd4ccb
commit 6363d85e85
1 changed files with 6 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
xrdp/xrdp_mm.c
View File

@ -1722,6 +1722,12 @@ xrdp_mm_trans_process_drdynvc_channel_close(struct xrdp_mm *self,
return 1; return 1;
} }
in_uint32_le(s, chansrv_chan_id); in_uint32_le(s, chansrv_chan_id);
if (chansrv_chan_id < 0 || chansrv_chan_id > 255)
{
LOG(LOG_LEVEL_ERROR, "Attempting to close invalid chansrv channel %d",
chansrv_chan_id);
return 1;
}
chan_id = self->cs2xr_cid_map[chansrv_chan_id]; chan_id = self->cs2xr_cid_map[chansrv_chan_id];
/* close dynamic channel */ /* close dynamic channel */
error = libxrdp_drdynvc_close(self->wm->session, chan_id); error = libxrdp_drdynvc_close(self->wm->session, chan_id);