xrdp/xrdpvr/Makefile.am

EXTRA_DEFINES =
EXTRA_INCLUDES =
EXTRA_LIBS =
EXTRA_FLAGS =

AM_CPPFLAGS = \
  $(EXTRA_DEFINES) \
  $(EXTRA_INCLUDES)

module_LTLIBRARIES = \
  libxrdpvr.la

libxrdpvr_la_SOURCES = \
  xrdpvr.c \
  xrdpvr.h

libxrdpvr_la_LDFLAGS = \
  $(EXTRA_FLAGS)

libxrdpvr_la_LIBADD = \
  $(EXTRA_LIBS)
forgot to add xrdpvr directory and files 2012-11-11 04:56:15 +04:00			`EXTRA_DEFINES =`
			`EXTRA_INCLUDES =`
			`EXTRA_LIBS =`
			`EXTRA_FLAGS =`

Merge AM_CFLAGS and INCLUDES info AM_CPPFLAGS AM_CPPFLAGS is for flags passed to the preprocessor, such as defines and includes. AM_CFLAGS is for flags affecting the compiler, such as debug and optimization settings. INCLUDES is an obsolete name. Users can pass INCLUDES and break compilation. AM_CPPFLAGS is more explicit that the flags come from Automake and should not be overridden. 2016-01-30 09:45:00 +03:00			`AM_CPPFLAGS = \`
			`$(EXTRA_DEFINES) \`
forgot to add xrdpvr directory and files 2012-11-11 04:56:15 +04:00			`$(EXTRA_INCLUDES)`

Stop redefining libdir, use moduledir for ${libdir}/xrdp libdir is for shared and static libraries. Some xrdp libraries are loaded dynamically from a non-standard directory, so they are used like modules. Having separate libdir and moduledir would eventually allow to separate dynamically loaded modules from shared libraries. 2016-02-10 21:24:09 +03:00			`module_LTLIBRARIES = \`
forgot to add xrdpvr directory and files 2012-11-11 04:56:15 +04:00			`libxrdpvr.la`

			`libxrdpvr_la_SOURCES = \`
Move headers from EXTRA_DIST to sources, sort alphabetically There should be no functional difference. 2016-02-22 08:49:04 +03:00			`xrdpvr.c \`
			`xrdpvr.h`
forgot to add xrdpvr directory and files 2012-11-11 04:56:15 +04:00
			`libxrdpvr_la_LDFLAGS = \`
			`$(EXTRA_FLAGS)`

			`libxrdpvr_la_LIBADD = \`
			`$(EXTRA_LIBS)`