mirrors/wolfssl
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Dilithium: fix check hint

Browse Source 
When all indeces are 0, then don't check hints against indeces.
This commit is contained in:
Sean Parkinson 2024-07-29 10:48:08 +10:00
parent 039853cbd5
commit fc19c36bf8
2 changed files with 8 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
tests/api.c
View File

@ -32389,6 +32389,12 @@ static int test_wc_dilithium_verify(void)
0);
ExpectIntEQ(res, 0);
sig[100] ^= 0x80;
/* Set all indeces to 0. */
XMEMSET(sig + sigLen - 4, 0, 4);
ExpectIntEQ(wc_dilithium_verify_msg(sig, sigLen, msg, 32, &res, key),
SIG_VERIFY_E);
ExpectIntEQ(res, 0);
}
#endif

4
wolfcrypt/src/dilithium.c
View File

@ -3183,11 +3183,11 @@ static int dilithium_check_hint(const byte* h, byte k, byte omega)
unsigned int i;
/* Skip polynomial index while count is 0. */
while ((h[omega + o] == 0) && (o < k)) {
while ((o < k) && (h[omega + o] == 0)) {
o++;
}
/* Check all possible hints. */
for (i = 1; i < omega; i++) {
for (i = 1; (o < k) && (i < omega); i++) {
/* Done with polynomial if index equals count of hints. */
if (i == h[omega + o]) {
/* Next polynomial index while count is index. */