mirrors/wolfssl
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

ssl: refactoring CyaSSL_DSA_do_sign to reduce stack usage:

Browse Source 
--- variable tmpRNG moved to the heap (sizeof(RNG) saved)
This commit is contained in:
Moisés Guimarães 2014-09-12 13:28:15 -03:00
parent 3f459591c6
commit c325504de7
1 changed files with 36 additions and 23 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

59
src/ssl.c
View File

@ -11025,36 +11025,50 @@ int CyaSSL_RSA_size(const CYASSL_RSA* rsa)
int CyaSSL_DSA_do_sign(const unsigned char* d, unsigned char* sigRet, int CyaSSL_DSA_do_sign(const unsigned char* d, unsigned char* sigRet,
CYASSL_DSA* dsa) CYASSL_DSA* dsa)
{ {
RNG tmpRNG; int ret = SSL_FATAL_ERROR;
RNG* rng = &tmpRNG; RNG* rng = NULL;
#ifdef CYASSL_SMALL_STACK
RNG* tmpRNG = NULL;
#else
RNG tmpRNG[1];
#endif
CYASSL_MSG("CyaSSL_DSA_do_sign"); CYASSL_MSG("CyaSSL_DSA_do_sign");
if (d == NULL || sigRet == NULL || dsa == NULL) { if (d == NULL || sigRet == NULL || dsa == NULL)
CYASSL_MSG("Bad function arguments"); CYASSL_MSG("Bad function arguments");
return SSL_FATAL_ERROR; else if (dsa->inSet == 0)
}
if (dsa->inSet == 0) {
CYASSL_MSG("No DSA internal set"); CYASSL_MSG("No DSA internal set");
return SSL_FATAL_ERROR; else {
} #ifdef CYASSL_SMALL_STACK
tmpRNG = (RNG*)XMALLOC(sizeof(RNG), NULL, DYNAMIC_TYPE_TMP_BUFFER);
if (InitRng(&tmpRNG) != 0) { if (tmpRNG == NULL)
CYASSL_MSG("Bad RNG Init, trying global");
if (initGlobalRNG == 0) {
CYASSL_MSG("Global RNG no Init");
return SSL_FATAL_ERROR; return SSL_FATAL_ERROR;
#endif
if (InitRng(tmpRNG) == 0)
rng = tmpRNG;
else {
CYASSL_MSG("Bad RNG Init, trying global");
if (initGlobalRNG == 0)
CYASSL_MSG("Global RNG no Init");
else
rng = &globalRNG;
} }
rng = &globalRNG;
if (rng) {
if (DsaSign(d, sigRet, (DsaKey*)dsa->internal, rng) < 0)
CYASSL_MSG("DsaSign failed");
else
ret = SSL_SUCCESS;
}
#ifdef CYASSL_SMALL_STACK
XFREE(RNG, NULL, DYNAMIC_TYPE_TMP_BUFFER);
#endif
} }
if (DsaSign(d, sigRet, (DsaKey*)dsa->internal, rng) < 0) { return ret;
CYASSL_MSG("DsaSign failed");
return SSL_FATAL_ERROR;
}
return SSL_SUCCESS;
} }
#endif /* NO_DSA */ #endif /* NO_DSA */
@ -11103,9 +11117,8 @@ int CyaSSL_RSA_sign(int type, const unsigned char* m,
if (outLen == 0) if (outLen == 0)
CYASSL_MSG("Bad RSA size"); CYASSL_MSG("Bad RSA size");
else if (InitRng(tmpRNG) == 0) { else if (InitRng(tmpRNG) == 0)
rng = tmpRNG; rng = tmpRNG;
}
else { else {
CYASSL_MSG("Bad RNG Init, trying global"); CYASSL_MSG("Bad RNG Init, trying global");