mirrors/wolfssl
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

ssl: refactoring CyaSSL_HMAC to reduce stack usage:

Browse Source 
--- variable hmac moved to the heap (sizeof(Hmac) saved)
This commit is contained in:
Moisés Guimarães 2014-09-09 18:28:00 -03:00
parent 8eeadc01b9
commit 79dfb3a3c3
1 changed files with 30 additions and 18 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

48
src/ssl.c
View File

@ -7591,33 +7591,45 @@ int CyaSSL_set_compression(CYASSL* ssl)
int key_len, const unsigned char* d, int n, int key_len, const unsigned char* d, int n,
unsigned char* md, unsigned int* md_len) unsigned char* md, unsigned int* md_len)
{ {
Hmac hmac; int type;
unsigned char* ret = NULL;
#ifdef CYASSL_SMALL_STACK
Hmac* hmac;
#else
Hmac hmac[1];
#endif
CYASSL_ENTER("HMAC"); CYASSL_ENTER("HMAC");
if (!md) return NULL; /* no static buffer support */ if (!md)
return NULL; /* no static buffer support */
if (XSTRNCMP(evp_md, "MD5", 3) == 0) { if (XSTRNCMP(evp_md, "MD5", 3) == 0)
if (HmacSetKey(&hmac, MD5, (const byte*)key, key_len) != 0) type = MD5;
return NULL; else if (XSTRNCMP(evp_md, "SHA", 3) == 0)
type = MD5;
if (md_len) *md_len = MD5_DIGEST_SIZE;
}
else if (XSTRNCMP(evp_md, "SHA", 3) == 0) {
if (HmacSetKey(&hmac, SHA, (const byte*)key, key_len) != 0)
return NULL;
if (md_len) *md_len = SHA_DIGEST_SIZE;
}
else else
return NULL; return NULL;
if (HmacUpdate(&hmac, d, n) != 0) #ifdef CYASSL_SMALL_STACK
hmac = (Hmac*)XMALLOC(sizeof(Hmac), NULL, DYNAMIC_TYPE_TMP_BUFFER);
if (hmac == NULL)
return NULL; return NULL;
#endif
if (HmacFinal(&hmac, md) != 0) if (HmacSetKey(hmac, type, (const byte*)key, key_len) == 0)
return NULL; if (HmacUpdate(hmac, d, n) == 0)
if (HmacFinal(hmac, md) == 0) {
if (md_len)
*md_len = type == MD5 ? MD5_DIGEST_SIZE
: SHA_DIGEST_SIZE;
ret = md;
}
return md; #ifdef CYASSL_SMALL_STACK
XFREE(hmac, NULL, DYNAMIC_TYPE_TMP_BUFFER);
#endif
return ret;
} }
void CyaSSL_ERR_clear_error(void) void CyaSSL_ERR_clear_error(void)