mirrors/wolfssl
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Fix for scan-build warning with “->dp == NULL”. Scenario can’t happen, but adding sanity check to suppress warning.

Browse Source
This commit is contained in:
David Garske 2017-03-02 15:56:31 -08:00
parent 9db6a27921
commit 67a8626430
1 changed files with 11 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

13
wolfcrypt/src/integer.c
View File

@ -330,12 +330,16 @@ int mp_copy (mp_int * a, mp_int * b)
} }
/* grow dest */ /* grow dest */
if (b->alloc < a->used || b->dp == NULL) { if (b->alloc < a->used) {
if ((res = mp_grow (b, a->used)) != MP_OKAY) { if ((res = mp_grow (b, a->used)) != MP_OKAY) {
return res; return res;
} }
} }
/* sanity check on destination */
if (b->dp == NULL)
return MP_VAL;
/* zero b and copy the parameters over */ /* zero b and copy the parameters over */
{ {
mp_digit *tmpa, *tmpb; mp_digit *tmpa, *tmpb;
@ -1633,11 +1637,16 @@ int s_mp_sub (mp_int * a, mp_int * b, mp_int * c)
max_a = a->used; max_a = a->used;
/* init result */ /* init result */
if (c->alloc < max_a || c->dp == NULL) { if (c->alloc < max_a) {
if ((res = mp_grow (c, max_a)) != MP_OKAY) { if ((res = mp_grow (c, max_a)) != MP_OKAY) {
return res; return res;
} }
} }
/* sanity check on destination */
if (c->dp == NULL)
return MP_VAL;
olduse = c->used; olduse = c->used;
c->used = max_a; c->used = max_a;