mirrors/wolfssl
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

replace fp_init_copy to appease some compilers

Browse Source
This commit is contained in:
gojimmypi 2023-03-08 20:37:19 -08:00
parent 6e58ca3bc4
commit 30106d82ea
1 changed files with 33 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

42
wolfcrypt/src/tfm.c
View File

@ -643,7 +643,8 @@ int fp_div(fp_int *a, fp_int *b, fp_int *c, fp_int *d)
return FP_OKAY;
}
#ifdef WOLFSSL_SMALL_STACK
#ifdef WOLFSSL_SMALL_STACK /* 0 1 2 3 4 */
/* allocate 5 elements of fp_int for q, x, y, t1, t2 */
q = (fp_int*)XMALLOC(sizeof(fp_int) * 5, NULL, DYNAMIC_TYPE_BIGINT);
if (q == NULL) {
return FP_MEM;
@ -657,8 +658,18 @@ int fp_div(fp_int *a, fp_int *b, fp_int *c, fp_int *d)
fp_init(t1);
fp_init(t2);
fp_init_copy(x, a);
fp_init_copy(y, b);
/* Init a copy (y) of the input (b) and
** Init a copy (x) of the input (a)
**
** ALERT: Not calling fp_init_copy() as some compiler optimization settings
** such as -O2 will complain that (x) or (y) "may be used uninitialized".
** The fp_init() is here only to appease the compiler. */
fp_init(x);
fp_copy(a, x); /* copy (src = a) to (dst = x) */
fp_init(y);
fp_copy(b, y); /* copy (src = b) to (dst = y) */
/* fix the sign */
neg = (a->sign == b->sign) ? FP_ZPOS : FP_NEG;
@ -4457,6 +4468,7 @@ int mp_div_2d(fp_int* a, int b, fp_int* c, fp_int* d)
return MP_OKAY;
}
/* copy (src = a) to (dst = b) */
void fp_copy(const fp_int *a, fp_int *b)
{
/* if source and destination are different */
@ -4494,11 +4506,13 @@ int mp_init_copy(fp_int * a, fp_int * b)
return MP_OKAY;
}
/* Copy (dst = a) from (src = b) */
void fp_init_copy(fp_int *a, fp_int* b)
{
if (a != b) {
fp_init(a);
fp_copy(b, a);
/* Note reversed parameter order! */
fp_copy(b, a); /* copy (src = b) to (dst = a) */
}
}
@ -5737,8 +5751,13 @@ int mp_radix_size (mp_int *a, int radix, int *size)
return FP_MEM;
#endif
/* init a copy of the input */
fp_init_copy (t, a);
/* Init a copy (t) of the input (a)
**
** ALERT: Not calling fp_init_copy() as some compiler optimization settings
** such as -O2 will complain that (t) "may be used uninitialized"
** The fp_init() is here only to appease the compiler. */
fp_init(t);
fp_copy(a, t); /* copy (src = a) to (dst = t)*/
/* force temp to positive */
t->sign = FP_ZPOS;
@ -5810,8 +5829,13 @@ int mp_toradix (mp_int *a, char *str, int radix)
return FP_MEM;
#endif
/* init a copy of the input */
fp_init_copy (t, a);
/* Init a copy (t) of the input (a)
**
** ALERT: Not calling fp_init_copy() as some compiler optimization settings
** such as -O2 will complain that (t) "may be used uninitialized"
** The fp_init() is here only to appease the compiler. */
fp_init(t);
fp_copy(a, t); /* copy (src = a) to (dst = t) */
/* if it is negative output a - */
if (t->sign == FP_NEG) {
@ -5909,4 +5933,4 @@ void mp_memzero_check(mp_int* a)
}
#endif /* WOLFSSL_CHECK_MEM_ZERO */
#endif /* USE_FAST_MATH */
#endif /* USE_FAST_MATH */