From 27f5f3a3e8ba69ccdcc1c6aa0e9c2384ed134183 Mon Sep 17 00:00:00 2001
From: Hideki Miyazaki <hide@wolfssl.com>
Date: Fri, 31 Mar 2023 15:56:31 +0900
Subject: [PATCH] fix overwriting serialnum by favouriteDrink

---
 tests/api.c             | 8 ++++++++
 wolfssl/wolfcrypt/asn.h | 2 +-
 2 files changed, 9 insertions(+), 1 deletion(-)

diff --git a/tests/api.c b/tests/api.c
index ff17b5915..f49784e67 100644
--- a/tests/api.c
+++ b/tests/api.c
@@ -45103,6 +45103,14 @@ static int test_wolfSSL_make_cert(void)
     AssertIntEQ(ASN1_STRING_length(entryValue), 2);
     AssertStrEQ((const char*)ASN1_STRING_data(entryValue), "US");
 
+    /* compare Serial Number */
+    AssertIntEQ((idx = X509_NAME_get_index_by_NID(x509name, NID_serialNumber,
+                    -1)), 7);
+    AssertNotNull(entry = X509_NAME_get_entry(x509name, idx));
+    AssertNotNull(entryValue = X509_NAME_ENTRY_get_data(entry));
+    AssertIntEQ(ASN1_STRING_length(entryValue), XSTRLEN("wolfSSL12345"));
+    AssertStrEQ((const char*)ASN1_STRING_data(entryValue), "wolfSSL12345");
+
 #ifdef WOLFSSL_MULTI_ATTRIB
     /* get first and second DC and compare result */
     AssertIntEQ((idx = X509_NAME_get_index_by_NID(x509name, NID_domainComponent,
diff --git a/wolfssl/wolfcrypt/asn.h b/wolfssl/wolfcrypt/asn.h
index 90391496c..8c0b65a8e 100644
--- a/wolfssl/wolfcrypt/asn.h
+++ b/wolfssl/wolfcrypt/asn.h
@@ -686,7 +686,7 @@ enum DN_Tags {
 
     /* pilot attribute types
      * OID values of 0.9.2342.19200300.100.1.* */
-    ASN_FAVOURITE_DRINK  = 0x05, /* favouriteDrink */
+    ASN_FAVOURITE_DRINK  = 0x13, /* favouriteDrink */
     ASN_DOMAIN_COMPONENT = 0x19  /* DC */
 };