From 80e888c1c80d65590247d636e2bd22e8377c05e7 Mon Sep 17 00:00:00 2001 From: kaleb-himes Date: Tue, 9 Jun 2020 16:47:35 -0600 Subject: [PATCH 1/2] Seperate QT and DSA dependencies --- wolfcrypt/src/asn.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/wolfcrypt/src/asn.c b/wolfcrypt/src/asn.c index 226278441..36998c648 100644 --- a/wolfcrypt/src/asn.c +++ b/wolfcrypt/src/asn.c @@ -880,7 +880,7 @@ int GetInt(mp_int* mpi, const byte* input, word32* inOutIdx, word32 maxIdx) } #if (!defined(WOLFSSL_KEY_GEN) && !defined(OPENSSL_EXTRA) && defined(RSA_LOW_MEM)) \ - || defined(WOLFSSL_RSA_PUBLIC_ONLY) || (!defined(NO_DSA) && defined(WOLFSSL_QT)) + || defined(WOLFSSL_RSA_PUBLIC_ONLY) || (!defined(NO_DSA)) #if !defined(NO_RSA) && !defined(HAVE_USER_RSA) static int SkipInt(const byte* input, word32* inOutIdx, word32 maxIdx) { @@ -5103,7 +5103,7 @@ static int StoreRsaKey(DecodedCert* cert, word32 bitStringEnd) static int GetKey(DecodedCert* cert) { int length; -#if !defined(NO_DSA) && defined(WOLFSSL_QT) +#ifndef NO_DSA int tmpLen; #endif #if defined(HAVE_ECC) || defined(HAVE_NTRU) @@ -5113,7 +5113,7 @@ static int GetKey(DecodedCert* cert) if (GetSequence(cert->source, &cert->srcIdx, &length, cert->maxIdx) < 0) return ASN_PARSE_E; -#if !defined(NO_DSA) && defined(WOLFSSL_QT) +#ifndef NO_DSA tmpLen = length + 4; #endif @@ -5326,7 +5326,7 @@ static int GetKey(DecodedCert* cert) return 0; } #endif /* HAVE_ED448 */ - #if !defined(NO_DSA) && defined(WOLFSSL_QT) + #ifndef NO_DSA case DSAk: { int ret; From 2fe08e1951be54022de125b9d34f819563a34ac1 Mon Sep 17 00:00:00 2001 From: Kaleb Himes Date: Tue, 9 Jun 2020 17:10:57 -0600 Subject: [PATCH 2/2] Update comment Thanks @dgarske, great catch! --- wolfcrypt/src/asn.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/wolfcrypt/src/asn.c b/wolfcrypt/src/asn.c index 36998c648..db0942a5c 100644 --- a/wolfcrypt/src/asn.c +++ b/wolfcrypt/src/asn.c @@ -5359,7 +5359,7 @@ static int GetKey(DecodedCert* cert) cert->srcIdx += length; return 0; } - #endif /* NO_DSA && QT */ + #endif /* NO_DSA */ default: return ASN_UNKNOWN_OID_E; }