Merge pull request #2425 from JacobBarthelmeh/SanityChecks

sanity check on buffer size
This commit is contained in:
David Garske 2019-08-22 12:30:06 -07:00 committed by GitHub
commit 0e6bb4717e
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23

View File

@ -7580,6 +7580,11 @@ static int DecodeCertExtensions(DecodedCert* cert)
/* check for critical flag */
critical = 0;
if ((idx + 1) > (word32)sz) {
WOLFSSL_MSG("\tfail: malformed buffer");
return BUFFER_E;
}
if (input[idx] == ASN_BOOLEAN) {
ret = GetBoolean(input, &idx, sz);
if (ret < 0) {
@ -14443,6 +14448,11 @@ static int DecodeOcspRespExtensions(byte* source,
}
/* check for critical flag */
if ((idx + 1) > (word32)sz) {
WOLFSSL_MSG("\tfail: malformed buffer");
return BUFFER_E;
}
if (source[idx] == ASN_BOOLEAN) {
WOLFSSL_MSG("\tfound optional critical flag, moving past");
ret = GetBoolean(source, &idx, sz);