From e720b2841882caf00727bab10822223bb03c6aec Mon Sep 17 00:00:00 2001 From: David du Colombier <0intro@gmail.com> Date: Sun, 25 Jun 2023 20:48:02 +0200 Subject: [PATCH] fix clang warnings This change fixes the following warnings: cmd/wmii/div.c:80:6: warning: unsequenced modification and access to 'n' cmd/wmii/message.c:231:7: warning: variable 'l' is used uninitialized whenever '&&' condition is false cmd/wmii/message.c:240:7: warning: variable 'l' is used uninitialized whenever '&&' condition is false --- cmd/wmii/div.c | 3 ++- cmd/wmii/message.c | 2 ++ 2 files changed, 4 insertions(+), 1 deletion(-) diff --git a/cmd/wmii/div.c b/cmd/wmii/div.c index 0ad544f4..bdc9ddb0 100644 --- a/cmd/wmii/div.c +++ b/cmd/wmii/div.c @@ -77,7 +77,8 @@ drawimg(Image *img, Color cbg, Color cborder, Divide *d) { pt[n++] = Pt(w - 1, w - 1); pt[n++] = Pt(w - 1, Dy(img->r)); - pt[n++] = Pt(w, pt[n-1].y); + pt[n] = Pt(w, pt[n-1].y); + n++; pt[n++] = Pt(w, w - 1); pt[n++] = Pt(2*w - 1, 0); diff --git a/cmd/wmii/message.c b/cmd/wmii/message.c index 01276054..3b54d60b 100644 --- a/cmd/wmii/message.c +++ b/cmd/wmii/message.c @@ -228,6 +228,7 @@ static ulong msg_getulong(const char *s) { ulong l; + l = 0; if(!(s && getulong(s, &l))) error(Ebadvalue); return l; @@ -237,6 +238,7 @@ static long msg_getlong(const char *s) { long l; + l = 0; if(!(s && getlong(s, &l))) error(Ebadvalue); return l;