mirrors/weston
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity
b05cdb82f7
weston/src
History
John Sadler ca510d06dc rpi: fix segfault at startup in rpi_flippipe_init() v2 
When running with the RPi backend, Weston now segfaults at startup on the
line:

    flippipe->clk_id = output->base.compositor->presentation_clock;

in `rpi_flippipe_init()`.

This is because `output->base.compositor` is NULL. This problem did not
exist on 1.8.0, and it looks like it may have been introduced by 954f183e2f.

This commit ensures that the `compositor` is initialised in `rpi_backend`
and that flippipe init uses the compositor pointer from backend.

Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=91885

Signed-off-by: John Sadler <deathofathousandpapercuts@gmail.com>

Changes in v2:
- fix summary to not break the build
- use output->backend->compositor in rpi_flippipe_init() instead of
  output->base.compositor. The latter is set by weston_output_init()
  which gets called later than rpi_flippipe_init().

Signed-off-by: Pekka Paalanen <pekka.paalanen@collabora.co.uk>
Tested-by: John Sadler <deathofathousandpapercuts@gmail.com>
2015-09-10 10:45:03 +03:00
..
animation.c Unified multiple definitions of container_of() macro. 2015-06-15 17:11:58 -07:00
bindings.c bindings: Make run binding functions take apropriate device instead of a seat 2015-07-16 19:04:40 -07:00
clipboard.c Unified multiple definitions of container_of() macro. 2015-06-15 17:11:58 -07:00
cms-colord.c cms-colord: Fix crash at compositor shutdown. (v2) 2015-07-23 12:28:50 -07:00
cms-helper.c src: Update boilerplate from MIT X11 license to MIT Expat license 2015-06-15 13:04:18 -07:00
cms-helper.h src: Update boilerplate from MIT X11 license to MIT Expat license 2015-06-15 13:04:18 -07:00
cms-static.c cms-helper/static: Add "identity" builtin cms profile (v3) 2015-07-23 12:29:49 -07:00
compositor-drm.c Revert "compositor-drm: disable hardware cursors" 2015-09-09 10:13:05 +03:00
compositor-fbdev.c compositor-fbdev: Remove bizarre division by sizeof 2015-09-10 10:01:03 +03:00
compositor-headless.c compositor: add API to manage compositor instances 2015-07-10 11:59:08 +03:00
compositor-rdp.c Coding style fixes 2015-08-07 12:01:22 -07:00
compositor-rpi.c rpi: fix segfault at startup in rpi_flippipe_init() v2 2015-09-10 10:45:03 +03:00
compositor-wayland.c backends: don't destroy renderer and output twice 2015-08-06 16:11:09 +01:00
compositor-x11.c compositor-x11: init linux_dmabuf support 2015-08-14 15:53:26 +03:00
compositor.c dmabuf: implement linux_dmabuf extension 2015-08-14 15:53:25 +03:00
compositor.h dmabuf: implement linux_dmabuf extension 2015-08-14 15:53:25 +03:00
data-device.c input: add a weston_pointer_clear_focus() helper function 2015-08-06 16:28:30 +01:00
dbus.c src: Update boilerplate from MIT X11 license to MIT Expat license 2015-06-15 13:04:18 -07:00
dbus.h src: Update boilerplate from MIT X11 license to MIT Expat license 2015-06-15 13:04:18 -07:00
gl-renderer.c gl-renderer: gl_renderer_create display cleanup on error 2015-08-21 15:00:10 +03:00
gl-renderer.h src: Update boilerplate from MIT X11 license to MIT Expat license 2015-06-15 13:04:18 -07:00
input.c input: add a weston_pointer_clear_focus() helper function 2015-08-06 16:28:30 +01:00
launcher-util.c src: Update boilerplate from MIT X11 license to MIT Expat license 2015-06-15 13:04:18 -07:00
launcher-util.h src: Update boilerplate from MIT X11 license to MIT Expat license 2015-06-15 13:04:18 -07:00
libbacklight.c Whitespace corrections 2015-06-06 12:39:51 -07:00
libbacklight.h libbacklight: Add missing boilerplate to header 2015-06-15 13:04:18 -07:00
libinput-device.c Unified multiple definitions of container_of() macro. 2015-06-15 17:11:58 -07:00
libinput-device.h src: Update boilerplate from MIT X11 license to MIT Expat license 2015-06-15 13:04:18 -07:00
libinput-seat.c input: when destroying a seat, remove keyboard focus first 2015-08-07 12:15:39 -07:00
libinput-seat.h src: Update boilerplate from MIT X11 license to MIT Expat license 2015-06-15 13:04:18 -07:00
linux-dmabuf.c dmabuf: implement linux_dmabuf extension 2015-08-14 15:53:25 +03:00
linux-dmabuf.h dmabuf: implement linux_dmabuf extension 2015-08-14 15:53:25 +03:00
log.c log: Open log file CLOEXEC so child processes don't get the fd 2015-07-16 19:28:36 -07:00
logind-util.c logind-util: Use %u for unsigned int in snprintf 2015-07-17 14:35:50 -07:00
logind-util.h src: Update boilerplate from MIT X11 license to MIT Expat license 2015-06-15 13:04:18 -07:00
main.c main: print backends in help message in alphabetical order 2015-07-31 16:15:06 -07:00
noop-renderer.c src: Update boilerplate from MIT X11 license to MIT Expat license 2015-06-15 13:04:18 -07:00
pixman-renderer.c input: Pass the appropriate pointer type to bindings instead of a seat 2015-07-16 19:03:43 -07:00
pixman-renderer.h src: Update boilerplate from MIT X11 license to MIT Expat license 2015-06-15 13:04:18 -07:00
rpi-bcm-stubs.h rpi: Support opaque regions 2013-12-02 11:36:29 -08:00
rpi-renderer.c rpi: avoid segfault in rpir_view_compute_rects() when EGL client destroys buffer 2015-09-08 16:21:45 +03:00
rpi-renderer.h src: Update boilerplate from MIT X11 license to MIT Expat license 2015-06-15 13:04:18 -07:00
screen-share.c screen-share: don't test keyboard/pointer pointers 2015-08-06 16:04:17 +01:00
screenshooter.c input: Pass the appropriate pointer type to bindings instead of a seat 2015-07-16 19:03:43 -07:00
spring-tool.c src: Update boilerplate from MIT X11 license to MIT Expat license 2015-06-15 13:04:18 -07:00
text-backend.c input: Don't test keyboard/pointer/touch pointers 2015-07-31 15:16:09 -07:00
timeline-object.h src: Update boilerplate from MIT X11 license to MIT Expat license 2015-06-15 13:04:18 -07:00
timeline.c src: Update boilerplate from MIT X11 license to MIT Expat license 2015-06-15 13:04:18 -07:00
timeline.h src: Update boilerplate from MIT X11 license to MIT Expat license 2015-06-15 13:04:18 -07:00
vaapi-recorder.c vaapi-recorder: Drop redundant license 2015-06-15 13:04:19 -07:00
vaapi-recorder.h src: Update boilerplate from MIT X11 license to MIT Expat license 2015-06-15 13:04:18 -07:00
version.h.in src: Update boilerplate from MIT X11 license to MIT Expat license 2015-06-15 13:04:18 -07:00
vertex-clipping.c src: Update boilerplate from MIT X11 license to MIT Expat license 2015-06-15 13:04:18 -07:00
vertex-clipping.h src: Update boilerplate from MIT X11 license to MIT Expat license 2015-06-15 13:04:18 -07:00
weston-egl-ext.h gl-renderer: add dmabuf import 2015-08-14 15:53:26 +03:00
weston-launch.c weston-launch: On error putenv returns a non-zero value 2015-08-10 15:28:46 -07:00
weston-launch.h src: Update boilerplate from MIT X11 license to MIT Expat license 2015-06-15 13:04:18 -07:00
weston.desktop build: install a login manager session entry 2015-01-20 19:44:58 -08:00
weston.pc.in weston.pc: Added libexecdir and pkglibexecdir variables 2013-06-04 00:14:04 -04:00
zoom.c input: Don't test keyboard/pointer/touch pointers 2015-07-31 15:16:09 -07:00